TiA4f8R
ea07d7751b
Fix first item played in playlists when switching player type or resolution
...
The issue was caused by an ExoPlayer change, which when setting a media source, resets the current playback position and the current window index by default.
Also set player recovery in more places to fix playback position not propely set in some cases after a player type switch.
2022-01-24 21:40:16 +01:00
litetex
e127db6fa6
Simplified toast showing behavior
...
after feedback from the review
2022-01-23 15:34:11 +01:00
litetex
49b1649348
Revert "Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud"
...
This reverts commit ee19ea66b3
, reversing
changes made to 6b490ee547
.
2022-01-23 15:34:11 +01:00
XiangRongLin
cd265fc31f
Make SearchHistoryEntry.kt fields nullable to match java version ( #7674 )
2022-01-21 16:01:11 +00:00
litetex
f681b0bb5a
Merge pull request #7648 from mhmdanas/small-refactors
...
Fix false warning
2022-01-19 19:48:07 +01:00
XiangRongLin
d7fbddf6f8
Merge pull request #7668 from litetex/fix-video-reset-on-player-switch
...
Workaround: Set recovery before switching player
2022-01-19 16:45:10 +01:00
mhmdanas
402990dd9d
Fix false warning
2022-01-18 07:40:59 +03:00
litetex
41faf70da1
Workaround: Set recovery before switching player
...
Quick fix
2022-01-17 20:52:07 +01:00
litetex
15e3b6301c
Merge pull request #7662 from TiA4f8R/fix-npe-share-button-playlists
...
Fix crash when sharing a playlist which is loading
2022-01-16 19:47:55 +01:00
XiangRongLin
5b9c28b93b
Replace JUnit asserts with AssertJ in HistoryRecordManagerTest ( #7654 )
...
* Replace JUnit asserts with AssertJ in HistoryRecordManagerTest
They provide a wider range of assertions, which allow for more detailed error messages.
Also convert SearchHistoryEntry to kotlin data class for better error messages, since toString() is implemented.
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-01-16 09:10:45 +01:00
TiA4f8R
6672169707
Fix NullPointerException when sharing a playlist which is loading
...
Prevent a NullPointerException by adding a null check for currentInfo when sharing a playlist.
2022-01-15 21:19:04 +01:00
Stypox
7907182e7e
Merge pull request #7036 from Douile/fix/queue-metadata
...
Load full stream info when enqueuing a stream
2022-01-07 21:57:30 +01:00
Douile
064242d962
Remove unecessary interface InfoCallback
...
Co-authored-by: Stypox <stypox@pm.me>
Replace the unecessary callback interface InfoCallback in favour of the
standard type Consumer<SinglePlayQueue>
2022-01-03 17:52:27 +00:00
litetex
ddcbe27fd3
Fixed search not accepting key input after closing player overlay ( #7607 )
...
* Fixed search not accepting key input after closing player overlay
* Made comments easier to understand
* More comments
2022-01-03 11:52:08 +01:00
litetex
ee19ea66b3
Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud
...
Add Already playing in background toast
2021-12-31 14:54:05 +01:00
litetex
6b490ee547
Merge pull request #7582 from Jaspann/sub-channel-tumbnail-view-fix
...
Fixes view of sub-channel icon when not in use
2021-12-31 14:52:32 +01:00
Jaspann
558c9147a2
Move sub icon visibility line
2021-12-28 15:54:36 -05:00
litetex
fc0e709817
Fixed usage of wrong string
2021-12-27 00:14:04 +01:00
litetex
b67bf16d4f
Minified code
2021-12-26 23:57:54 +01:00
William Parker
fb3be544ce
Fixed code styling
2021-12-26 00:12:48 -05:00
Jaspann
53f5741317
Fixes view of sub-channel icon when not in use
2021-12-25 18:10:05 -05:00
David Kramer
07015973d2
Added ability to see pinned comment
2021-12-24 11:29:34 -06:00
Tobi
215880207e
Merge pull request #7562 from TeamNewPipe/code-quality
...
Small improvements to code quality and readability
2021-12-23 23:54:29 +01:00
vhouriet
989bcbf895
Add Already playing in background toast
2021-12-23 22:12:38 +01:00
XiangRongLin
05370dbb94
Merge pull request #7556 from Jaspann/improve-hashtags
...
Fixes hashtags that use non-English characters.
2021-12-23 11:45:52 +01:00
Robin
f6cad2d9cf
Merge pull request #7555 from litetex/remove-mediaparser
...
Remove/Revert MediaParser support (Android 11+) due to bugs
2021-12-22 17:32:28 +01:00
TobiGr
37b8a9375f
Small improvements to code quality and readability
...
Add annotations to methods and parameters.
Replace Jetbrains' @NotNull with Androidx' @NonNull annotatiation.
Make class variables static if possible.
Use constants for some Strings.
Simplify if conditions.
2021-12-21 20:55:41 +01:00
TobiGr
d71af9a625
Introduce constants for some Strings that indicate no data in Tab class
2021-12-21 20:53:17 +01:00
TobiGr
a163d5461d
Make PlayerHolder.bound private
2021-12-21 20:51:18 +01:00
Jaspann
a274baf5cd
Adds comment to HASHTAGS_PATTERN
2021-12-20 14:13:40 -05:00
Jaspann
361760be0a
Allows multilingual support in hashtags
2021-12-19 20:33:55 -05:00
litetex
eea2768633
Removed/Reverted MediaParser support (Android 11+) due to bugs
2021-12-19 20:16:10 +01:00
Robin
d3562c70f5
Merge pull request #7451 from Cheechaii/respect-cutout-in-multiwindow
...
Respect cutouts when playing in MultiWindow
2021-12-19 13:23:28 +01:00
litetex
b21d231e3a
Merge pull request #7452 from litetex/show-alert-when-file-manager-not-found
...
Show an alert-dialog when no appropriate file-manager was found
2021-12-14 20:01:02 +01:00
litetex
4058277b7a
Merge pull request #7482 from TeamNewPipe/unify-error-reporting
...
Unify error reporting and add error notification
2021-12-14 19:58:41 +01:00
XiangRongLin
dd9772cde2
Merge pull request #7491 from Stypox/fix-search-order
...
Fix order of local search results
2021-12-14 09:07:17 -05:00
litetex
b056faa97f
Merge pull request #7500 from TacoTheDank/bumpKtlint
...
Bump ktlint, Checkstyle, Java version
2021-12-12 15:07:24 +01:00
Douile
3ff00ff50e
Fix lambda code formatting
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-12 13:04:32 +00:00
Tom
baee915db5
Remove unecessary line
...
Co-authored-by: Stypox <stypox@pm.me>
2021-12-12 12:51:01 +00:00
Cheechaii
c92a90749e
Respect cutouts when playing in MultiWindow
2021-12-09 20:58:05 +01:00
litetex
e806f8c4e6
Android 10+ only allows SAF -> Respect that in the dialog
2021-12-08 20:22:26 +01:00
Stypox
8a5e2ffa57
Fix order of local search results
2021-12-08 13:59:32 +01:00
Stypox
bb49b1cfb1
Add javadoc to ErrorUtil and ErrorActivity
2021-12-07 18:14:53 +01:00
TacoTheDank
75db002369
Update ktlint to 0.43.2
2021-12-04 21:22:29 -05:00
Robin
41a0dc1abd
Disable media tunneling on Philips QM16XE
2021-12-04 22:23:09 +01:00
Stypox
950956ebf2
Also show a toast on error notification
...
since the notification is silent, also show a toast, otherwise the user is confused
2021-12-04 10:50:27 +01:00
Stypox
c8e2ab4c83
Remove PlayerErrorHandler and correctly set ErrorInfo msg
2021-12-04 10:36:36 +01:00
Stypox
397f93b079
Prevent exception from being serialized in ErrorInfo
...
The wrong @Decorator was put in the wrong place to mark the throwable fieldd as transient, now this is fixed and the exception is not serialized. So if a non-serializable throwable is passed, that's not an issue, since it's not going to be serialized. The need for EnsureExceptionSerializable is also gone.
2021-12-04 10:36:36 +01:00
Stypox
09d137f740
Add PendingIntent to ErrorUtil.createNotification
2021-12-04 10:36:36 +01:00
Stypox
81f740d409
Replace ErrorActivity with ErrorUtil
2021-12-04 10:36:36 +01:00