From f4d62d3342e6e5a2354f4d2b347d7f27cfcd0b23 Mon Sep 17 00:00:00 2001 From: Evan Lurvey <54965655+evanlurvey@users.noreply.github.com> Date: Wed, 26 Feb 2020 04:10:06 -0600 Subject: [PATCH] Fix docs and code to match in haystack tracing. --- .../content/observability/tracing/haystack.md | 64 +++++++++---------- pkg/tracing/haystack/haystack.go | 2 +- 2 files changed, 33 insertions(+), 33 deletions(-) diff --git a/docs/content/observability/tracing/haystack.md b/docs/content/observability/tracing/haystack.md index ae0676c70..99895860e 100644 --- a/docs/content/observability/tracing/haystack.md +++ b/docs/content/observability/tracing/haystack.md @@ -40,24 +40,24 @@ tracing: #### `localAgentPort` -_Require, Default=42699_ +_Require, Default=35000_ Local Agent port instructs reporter to send spans to the haystack-agent at this port. ```toml tab="File (TOML)" [tracing] [tracing.haystack] - localAgentPort = 42699 + localAgentPort = 35000 ``` ```yaml tab="File (YAML)" tracing: haystack: - localAgentPort: 42699 + localAgentPort: 35000 ``` ```bash tab="CLI" ---tracing.haystack.localAgentPort=42699 +--tracing.haystack.localAgentPort=35000 ``` #### `globalTag` @@ -91,61 +91,61 @@ Specifies the header name that will be used to store the trace ID. ```toml tab="File (TOML)" [tracing] [tracing.haystack] - traceIDHeaderName = "sample" + traceIDHeaderName = "Trace-ID" ``` ```yaml tab="File (YAML)" tracing: haystack: - traceIDHeaderName: sample + traceIDHeaderName: Trace-ID ``` ```bash tab="CLI" ---tracing.haystack.traceIDHeaderName=sample +--tracing.haystack.traceIDHeaderName=Trace-ID ``` #### `parentIDHeaderName` _Optional, Default=empty_ +Specifies the header name that will be used to store the parent ID. + +```toml tab="File (TOML)" +[tracing] + [tracing.haystack] + parentIDHeaderName = "Parent-Message-ID" +``` + +```yaml tab="File (YAML)" +tracing: + haystack: + parentIDHeaderName: Parent-Message-ID +``` + +```bash tab="CLI" +--tracing.haystack.parentIDHeaderName=Parent-Message-ID +``` + +#### `spanIDHeaderName` + +_Optional, Default=empty_ + Specifies the header name that will be used to store the span ID. ```toml tab="File (TOML)" [tracing] [tracing.haystack] - parentIDHeaderName = "sample" + spanIDHeaderName = "Message-ID" ``` ```yaml tab="File (YAML)" tracing: haystack: - parentIDHeaderName: "sample" + spanIDHeaderName: Message-ID ``` ```bash tab="CLI" ---tracing.haystack.parentIDHeaderName=sample -``` - -#### `spanIDHeaderName` - -_Optional, Default=empty_ - -Apply shared tag in a form of Key:Value to all the traces. - -```toml tab="File (TOML)" -[tracing] - [tracing.haystack] - spanIDHeaderName = "sample:test" -``` - -```yaml tab="File (YAML)" -tracing: - haystack: - spanIDHeaderName: "sample:test" -``` - -```bash tab="CLI" ---tracing.haystack.spanIDHeaderName=sample:test +--tracing.haystack.spanIDHeaderName=Message-ID ``` #### `baggagePrefixHeaderName` diff --git a/pkg/tracing/haystack/haystack.go b/pkg/tracing/haystack/haystack.go index 47b6266e6..644a27c87 100644 --- a/pkg/tracing/haystack/haystack.go +++ b/pkg/tracing/haystack/haystack.go @@ -26,7 +26,7 @@ type Config struct { // SetDefaults sets the default values. func (c *Config) SetDefaults() { - c.LocalAgentHost = "LocalAgentHost" + c.LocalAgentHost = "127.0.0.1" c.LocalAgentPort = 35000 }