baalajimaestro/traefik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix a regression on flags using spaces between key and value

Browse source
This commit is contained in:
Ludovic Fernandez 2024-02-16 09:44:06 +01:00 committed by GitHub
parent 014fdfc4ec
commit c5c61dbade
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 8 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
pkg/cli/deprecation.go
View file

@ -24,16 +24,19 @@ func (d DeprecationLoader) Load(args []string, cmd *cli.Command) (bool, error) {
} }
// logDeprecation prints deprecation hints and returns whether incompatible deprecated options need to be removed. // logDeprecation prints deprecation hints and returns whether incompatible deprecated options need to be removed.
func logDeprecation(traefikConfiguration interface{}, args []string) bool { func logDeprecation(traefikConfiguration interface{}, arguments []string) bool {
// This part doesn't handle properly a flag defined like this: // This part doesn't handle properly a flag defined like this:
// --accesslog true // --accesslog true
// where `true` could be considered as a new argument. // where `true` could be considered as a new argument.
// This is not really an issue with the deprecation loader since it will filter the unknown nodes later in this // This is not really an issue with the deprecation loader since it will filter the unknown nodes later in this function.
// function. var args []string
for i, arg := range args { for _, arg := range arguments {
if !strings.Contains(arg, "=") { if !strings.Contains(arg, "=") {
args[i] = arg + "=true" args = append(args, arg+"=true")
continue
} }
args = append(args, arg)
} }
labels, err := flag.Parse(args, nil) labels, err := flag.Parse(args, nil)