From c0ef5ce512b4924a5d287ad4ec91f72abe0b4090 Mon Sep 17 00:00:00 2001 From: Michael Date: Wed, 24 Jul 2019 12:38:03 +0200 Subject: [PATCH] Fix prometheus metrics --- pkg/metrics/prometheus.go | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/pkg/metrics/prometheus.go b/pkg/metrics/prometheus.go index bfca5489e..bca770b3c 100644 --- a/pkg/metrics/prometheus.go +++ b/pkg/metrics/prometheus.go @@ -506,11 +506,14 @@ func (h *histogram) With(labelValues ...string) metrics.Histogram { func (h *histogram) Observe(value float64) { labels := h.labelNamesValues.ToLabels() - collector := h.hv.With(labels) - collector.Observe(value) - h.collectors <- newCollector(h.name, labels, h.hv, func() { - h.hv.Delete(labels) - }) + observer := h.hv.With(labels) + observer.Observe(value) + // Do a type assertion to be sure that prometheus will be able to call the Collect method. + if collector, ok := observer.(stdprometheus.Histogram); ok { + h.collectors <- newCollector(h.name, labels, collector, func() { + h.hv.Delete(labels) + }) + } } func (h *histogram) Describe(ch chan<- *stdprometheus.Desc) {