diff --git a/docs/content/migration/v2.md b/docs/content/migration/v2.md index 84e161c93..d75e6e5c1 100644 --- a/docs/content/migration/v2.md +++ b/docs/content/migration/v2.md @@ -348,7 +348,7 @@ It is therefore necessary to update [RBAC](../reference/dynamic-configuration/ku ### Non-ASCII Domain Names -In `v2.4.8` we introduced a new check on domain names used in HTTP router rule `Host` and `HostRegexp` expressions, +In `v2.4.8`, we introduced a new check on domain names used in HTTP router rule `Host` and `HostRegexp` expressions, and in TCP router rule `HostSNI` expression. This check ensures that provided domain names don't contain non-ASCII characters. If not, an error is raised, and the associated router will be shown as invalid in the dashboard. @@ -358,3 +358,9 @@ It doesn't change the support for non-ASCII domain names in routers rules, which In order to use non-ASCII domain names in a router's rule, one should use the Punycode form of the domain name. For more information, please read the [HTTP routers rule](../routing/routers/index.md#rule) part or [TCP router rules](../routing/routers/index.md#rule_1) part of the documentation. + +## v2.4.8 to v2.4.9 + +### Tracing Span + +In `v2.4.9`, we changed span error to log only server errors (>= 500). diff --git a/pkg/tracing/tracing.go b/pkg/tracing/tracing.go index 02fab9c5d..498a26348 100644 --- a/pkg/tracing/tracing.go +++ b/pkg/tracing/tracing.go @@ -117,7 +117,7 @@ func LogRequest(span opentracing.Span, r *http.Request) { func LogResponseCode(span opentracing.Span, code int) { if span != nil { ext.HTTPStatusCode.Set(span, uint16(code)) - if code >= 400 { + if code >= http.StatusInternalServerError { ext.Error.Set(span, true) } }