baalajimaestro/traefik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Fix doc about removing headers

Browse source
This commit is contained in:
mpl 2019-04-05 15:18:04 +02:00 committed by Traefiker Bot
parent 2e19e45aa4
commit b0b8b75258
2 changed files with 10 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
docs/content/middlewares/headers.md
View file

@ -43,13 +43,10 @@ spec:
### Adding and Removing Headers ### Adding and Removing Headers
`X-Script-Name` header added to the proxied request, the `X-Custom-Request-Header` header removed from the request, and the `X-Custom-Response-Header` header removed from the response. `X-Script-Name` header added to the proxied request, the `X-Custom-Request-Header` header removed from the request,
and the `X-Custom-Response-Header` header removed from the response.
```yaml tab="Docker" Please note that is not possible to remove headers through the use of Docker labels for now.
labels:
- "traefik.http.middlewares.testHeader.Headers.CustomRequestHeaders.X-Script-Name=test"
- "traefik.http.middlewares.testHeader.Headers.CustomResponseHeaders.X-Custom-Response-Header=True"
```
```yaml tab="Kubernetes" ```yaml tab="Kubernetes"
apiVersion: traefik.containo.us/v1alpha1 apiVersion: traefik.containo.us/v1alpha1
@ -59,18 +56,20 @@ metadata:
spec: spec:
headers: headers:
CustomRequestHeaders: CustomRequestHeaders:
X-Script-Name: "test" X-Script-Name: "test" # Adds
X-Custom-Request-Header: "" # Removes
CustomResponseHeaders: CustomResponseHeaders:
X-Custom-Response-Header: "True" X-Custom-Response-Header: "" # Removes
``` ```
```toml tab="File" ```toml tab="File"
[http.middlewares] [http.middlewares]
[http.middlewares.testHeader.headers] [http.middlewares.testHeader.headers]
[http.middlewares.testHeader.headers.CustomRequestHeaders] [http.middlewares.testHeader.headers.CustomRequestHeaders]
X-Script-Name = "test" X-Script-Name = "test" # Adds
X-Custom-Request-Header = "" # Removes
[http.middlewares.testHeader.headers.CustomResponseHeaders] [http.middlewares.testHeader.headers.CustomResponseHeaders]
X-Custom-Response-Header = "True" X-Custom-Response-Header = "" # Removes
``` ```
### Using Security Headers ### Using Security Headers

2
pkg/middlewares/headers/headers.go
View file

@ -166,7 +166,7 @@ func (s *Header) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
} }
} }
// modifyRequestHeaders set or delete request headers. // modifyRequestHeaders sets or deletes request headers.
func (s *Header) modifyRequestHeaders(req *http.Request) { func (s *Header) modifyRequestHeaders(req *http.Request) {
// Loop through Custom request headers // Loop through Custom request headers
for header, value := range s.headers.CustomRequestHeaders { for header, value := range s.headers.CustomRequestHeaders {