From 4892b2b0da034f5383d6e59e9b27641049e173e3 Mon Sep 17 00:00:00 2001 From: Timo Reimann Date: Wed, 5 Jul 2017 21:30:18 +0200 Subject: [PATCH] [kubernetes] Undo the Secrets controller sync wait. When Secrets permissions have not been granted (which is likely to be the case for users not needing the basic auth feature), the watch on the Secrets API will never yield a response, thereby causing the controller to never sync successfully, and in turn causing the check for all controller synchronizations to fail consistently. Thus, no event will ever be handled. --- provider/kubernetes/client.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/provider/kubernetes/client.go b/provider/kubernetes/client.go index 4ee9097d2..971efe033 100644 --- a/provider/kubernetes/client.go +++ b/provider/kubernetes/client.go @@ -263,7 +263,7 @@ func (c *clientImpl) WatchAll(labelSelector string, stopCh <-chan struct{}) (<-c // fireEvent checks if all controllers have synced before firing // Used after startup or a reconnect func (c *clientImpl) fireEvent(event interface{}, eventCh chan interface{}) { - if !c.ingController.HasSynced() || !c.svcController.HasSynced() || !c.epController.HasSynced() || !c.secController.HasSynced() { + if !c.ingController.HasSynced() || !c.svcController.HasSynced() || !c.epController.HasSynced() { return } eventHandlerFunc(eventCh, event)