We need to flush the end of the body when retry is streamed
This commit is contained in:
parent
23c1a9ca8e
commit
3e13ebec93
2 changed files with 19 additions and 0 deletions
|
@ -56,6 +56,7 @@ func (retry *Retry) ServeHTTP(rw http.ResponseWriter, r *http.Request) {
|
||||||
// It's a stream request and the body gets already sent to the client.
|
// It's a stream request and the body gets already sent to the client.
|
||||||
// Therefore we should not send the response a second time.
|
// Therefore we should not send the response a second time.
|
||||||
if recorder.streamingResponseStarted {
|
if recorder.streamingResponseStarted {
|
||||||
|
recorder.Flush()
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
|
@ -134,3 +134,21 @@ type countingRetryListener struct {
|
||||||
func (l *countingRetryListener) Retried(req *http.Request, attempt int) {
|
func (l *countingRetryListener) Retried(req *http.Request, attempt int) {
|
||||||
l.timesCalled++
|
l.timesCalled++
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestRetryWithFlush(t *testing.T) {
|
||||||
|
next := http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
|
||||||
|
rw.WriteHeader(200)
|
||||||
|
rw.Write([]byte("FULL "))
|
||||||
|
rw.(http.Flusher).Flush()
|
||||||
|
rw.Write([]byte("DATA"))
|
||||||
|
})
|
||||||
|
|
||||||
|
retry := NewRetry(1, next, &countingRetryListener{})
|
||||||
|
responseRecorder := httptest.NewRecorder()
|
||||||
|
|
||||||
|
retry.ServeHTTP(responseRecorder, &http.Request{})
|
||||||
|
|
||||||
|
if responseRecorder.Body.String() != "FULL DATA" {
|
||||||
|
t.Errorf("Wrong body %q want %q", responseRecorder.Body.String(), "FULL DATA")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
Loading…
Add table
Reference in a new issue