Merge branch 'validate-govet' of https://github.com/vdemeester/traefik into vdemeester-validate-govet
This commit is contained in:
commit
396a8f9360
2 changed files with 35 additions and 1 deletions
5
Makefile
5
Makefile
|
@ -32,11 +32,14 @@ test-integration: build
|
||||||
$(DOCKER_RUN_TRAEFIK) ./script/make.sh generate binary test-integration
|
$(DOCKER_RUN_TRAEFIK) ./script/make.sh generate binary test-integration
|
||||||
|
|
||||||
validate: build
|
validate: build
|
||||||
$(DOCKER_RUN_TRAEFIK) ./script/make.sh validate-gofmt
|
$(DOCKER_RUN_TRAEFIK) ./script/make.sh validate-gofmt validate-govet
|
||||||
|
|
||||||
validate-gofmt: build
|
validate-gofmt: build
|
||||||
$(DOCKER_RUN_TRAEFIK) ./script/make.sh validate-gofmt
|
$(DOCKER_RUN_TRAEFIK) ./script/make.sh validate-gofmt
|
||||||
|
|
||||||
|
validate-govet: build
|
||||||
|
$(DOCKER_RUN_TRAEFIK) ./script/make.sh validate-govet
|
||||||
|
|
||||||
build: dist
|
build: dist
|
||||||
docker build -t "$(TRAEFIK_DEV_IMAGE)" -f build.Dockerfile .
|
docker build -t "$(TRAEFIK_DEV_IMAGE)" -f build.Dockerfile .
|
||||||
|
|
||||||
|
|
31
script/validate-govet
Executable file
31
script/validate-govet
Executable file
|
@ -0,0 +1,31 @@
|
||||||
|
#!/bin/bash
|
||||||
|
|
||||||
|
source "$(dirname "$BASH_SOURCE")/.validate"
|
||||||
|
|
||||||
|
IFS=$'\n'
|
||||||
|
files=( $(validate_diff --diff-filter=ACMR --name-only -- '*.go' | grep -v '^Godeps/' || true) )
|
||||||
|
unset IFS
|
||||||
|
|
||||||
|
errors=()
|
||||||
|
for f in "${files[@]}"; do
|
||||||
|
# we use "git show" here to validate that what's committed passes go vet
|
||||||
|
failedVet=$(go tool vet -printf=false "$f")
|
||||||
|
if [ "$failedVet" ]; then
|
||||||
|
errors+=( "$failedVet" )
|
||||||
|
fi
|
||||||
|
done
|
||||||
|
|
||||||
|
if [ ${#errors[@]} -eq 0 ]; then
|
||||||
|
echo 'Congratulations! All Go source files have been vetted.'
|
||||||
|
else
|
||||||
|
{
|
||||||
|
echo "Errors from govet:"
|
||||||
|
for err in "${errors[@]}"; do
|
||||||
|
echo "$err"
|
||||||
|
done
|
||||||
|
echo
|
||||||
|
echo 'Please fix the above errors. You can test via "go vet" and commit the result.'
|
||||||
|
echo
|
||||||
|
} >&2
|
||||||
|
false
|
||||||
|
fi
|
Loading…
Reference in a new issue