baalajimaestro/traefik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Change to a more flexible PR review process

Browse source 
Signed-off-by: Emile Vauge <emile@vauge.com>
This commit is contained in:
Emile Vauge 2017-06-23 15:12:23 +02:00 committed by Ludovic Fernandez
parent ceec81011b
commit 34e60a8404
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
.github/MAINTAINER.md vendored
View file

@ -80,7 +80,9 @@ The `status/*` labels represent the desired state in the workflow.
* `status/2-needs-review`: need a code/documentation review. **(only for PR)** * `status/2-needs-review`: need a code/documentation review. **(only for PR)**
* `status/3-needs-merge`: ready to merge. **(only for PR)** * `status/3-needs-merge`: ready to merge. **(only for PR)**
Note: ## PR review process:
* The status `needs-design-review` is only used in complex/heavy PRs.
* From `1` to `2`: 2 design LGTM needed in comment. * If needed, a specific maintainer can be required to make a review (according to its knowledge areas)
* From `2` to `3`: PR need 2 approvals. * The status `needs-design-review` is only used in complex/heavy/tricky PRs.
* From `1` to `2`: 1 design LGTM in comment, by a senior maintainer, if needed.
* From `2` to `3`: 3 LGTM by any maintainer.