baalajimaestro/traefik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Adjust forward auth to avoid connection leak

Browse source
This commit is contained in:
Weida Hong 2023-09-09 18:36:05 +08:00 committed by GitHub
parent 561c580701
commit 3216c8ab10
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/middlewares/auth/forward.go
View file

@ -126,6 +126,7 @@ func (fa *forwardAuth) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
rw.WriteHeader(http.StatusInternalServerError) rw.WriteHeader(http.StatusInternalServerError)
return return
} }
defer forwardResponse.Body.Close()
body, readError := io.ReadAll(forwardResponse.Body) body, readError := io.ReadAll(forwardResponse.Body)
if readError != nil { if readError != nil {
@ -136,7 +137,6 @@ func (fa *forwardAuth) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
rw.WriteHeader(http.StatusInternalServerError) rw.WriteHeader(http.StatusInternalServerError)
return return
} }
defer forwardResponse.Body.Close()
// Pass the forward response's body and selected headers if it // Pass the forward response's body and selected headers if it
// didn't return a response within the range of [200, 300). // didn't return a response within the range of [200, 300).