baalajimaestro/traefik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages 1 Wiki Activity Actions

Merge pull request #82 from vdemeester/pr-78

Browse source 
Carry #78 Pass websocket headers to backend
This commit is contained in:
Vincent Demeester 2015-10-29 22:56:51 +01:00
commit 287d5c59da
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
middlewares/websocketproxy.go
View file

@ -101,6 +101,9 @@ func (w *WebsocketProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
for _, cookie := range req.Header[http.CanonicalHeaderKey("Cookie")] { for _, cookie := range req.Header[http.CanonicalHeaderKey("Cookie")] {
requestHeader.Add("Cookie", cookie) requestHeader.Add("Cookie", cookie)
} }
for _, auth := range req.Header[http.CanonicalHeaderKey("Authorization")] {
requestHeader.Add("Authorization", auth)
}
// Pass X-Forwarded-For headers too, code below is a part of // Pass X-Forwarded-For headers too, code below is a part of
// httputil.ReverseProxy. See http://en.wikipedia.org/wiki/X-Forwarded-For // httputil.ReverseProxy. See http://en.wikipedia.org/wiki/X-Forwarded-For
@ -124,13 +127,16 @@ func (w *WebsocketProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
requestHeader.Set("X-Forwarded-Proto", "https") requestHeader.Set("X-Forwarded-Proto", "https")
} }
//frontend Origin != backend Origin
requestHeader.Del("Origin")
// Connect to the backend URL, also pass the headers we get from the requst // Connect to the backend URL, also pass the headers we get from the requst
// together with the Forwarded headers we prepared above. // together with the Forwarded headers we prepared above.
// TODO: support multiplexing on the same backend connection instead of // TODO: support multiplexing on the same backend connection instead of
// opening a new TCP connection time for each request. This should be // opening a new TCP connection time for each request. This should be
// optional: // optional:
// http://tools.ietf.org/html/draft-ietf-hybi-websocket-multiplexing-01 // http://tools.ietf.org/html/draft-ietf-hybi-websocket-multiplexing-01
connBackend, resp, err := dialer.Dial(backendURL.String(), nil) connBackend, resp, err := dialer.Dial(backendURL.String(), requestHeader)
if err != nil { if err != nil {
log.Errorf("Websocketproxy: couldn't dial to remote backend url %s, %s, %+v", backendURL.String(), err, resp) log.Errorf("Websocketproxy: couldn't dial to remote backend url %s, %s, %+v", backendURL.String(), err, resp)
http.Error(rw, "Remote backend unreachable", http.StatusBadGateway) http.Error(rw, "Remote backend unreachable", http.StatusBadGateway)