From 00e05718118905a37a390a1f7e78938f84d4a64b Mon Sep 17 00:00:00 2001 From: Ludovic Fernandez Date: Tue, 23 Jan 2018 16:30:07 +0100 Subject: [PATCH] Rename TLSConfigurations to TLS. --- autogen/gentemplates/gen.go | 8 +++--- docs/configuration/backends/file.md | 16 +++++------ docs/user-guide/kv-config.md | 28 +++++++++---------- examples/consul-config.sh | 12 ++++---- examples/etcd-config.sh | 24 ++++++++-------- integration/consul_test.go | 16 +++++------ integration/etcd3_test.go | 24 ++++++++-------- integration/etcd_test.go | 16 +++++------ integration/fixtures/acme/certificates.toml | 4 +-- integration/fixtures/https/dynamic_https.toml | 4 +-- integration/https_test.go | 2 +- provider/file/file.go | 4 +-- provider/file/file_test.go | 24 ++++++++-------- server/server.go | 6 ++-- server/server_test.go | 4 +-- templates/kv.tmpl | 8 +++--- tls/tls.go | 4 +-- types/types.go | 6 ++-- 18 files changed, 105 insertions(+), 105 deletions(-) diff --git a/autogen/gentemplates/gen.go b/autogen/gentemplates/gen.go index e6c160953..313db391b 100644 --- a/autogen/gentemplates/gen.go +++ b/autogen/gentemplates/gen.go @@ -522,7 +522,7 @@ func templatesKubernetesTmpl() (*asset, error) { var _templatesKvTmpl = []byte(`{{$frontends := List .Prefix "/frontends/" }} {{$backends := List .Prefix "/backends/"}} -{{$tlsconfiguration := List .Prefix "/tlsconfiguration/"}} +{{$tls := List .Prefix "/tls/"}} [backends]{{range $backends}} {{$backend := .}} @@ -587,13 +587,13 @@ var _templatesKvTmpl = []byte(`{{$frontends := List .Prefix "/frontends/" }} {{end}} {{end}} -{{range $tlsconfiguration}} +{{range $tls}} {{$entryPoints := SplitGet . "/entrypoints"}} -[[tlsConfiguration]] +[[tls]] entryPoints = [{{range $entryPoints}} "{{.}}", {{end}}] - [tlsConfiguration.certificate] + [tls.certificate] certFile = """{{Get "" . "/certificate" "/certfile"}}""" keyFile = """{{Get "" . "/certificate" "/keyfile"}}""" {{end}} diff --git a/docs/configuration/backends/file.md b/docs/configuration/backends/file.md index 2fd1809df..2df402e0c 100644 --- a/docs/configuration/backends/file.md +++ b/docs/configuration/backends/file.md @@ -84,15 +84,15 @@ defaultEntryPoints = ["http", "https"] rule = "Path:/test" # HTTPS certificate -[[tlsConfiguration]] +[[tls]] entryPoints = ["https"] - [tlsConfiguration.certificate] + [tls.certificate] certFile = "path/to/my.cert" keyFile = "path/to/my.key" -[[tlsConfiguration]] +[[tls]] entryPoints = ["https"] - [tlsConfiguration.certificate] + [tls.certificate] certFile = "path/to/my/other.cert" keyFile = "path/to/my/other.key" ``` @@ -163,15 +163,15 @@ filename = "rules.toml" rule = "Path:/test" # HTTPS certificate -[[tlsConfiguration]] +[[tls]] entryPoints = ["https"] - [tlsConfiguration.certificate] + [tls.certificate] certFile = "path/to/my.cert" keyFile = "path/to/my.key" -[[tlsConfiguration]] +[[tls]] entryPoints = ["https"] - [tlsConfiguration.certificate] + [tls.certificate] certFile = "path/to/my/other.cert" keyFile = "path/to/my/other.key" diff --git a/docs/user-guide/kv-config.md b/docs/user-guide/kv-config.md index 41a6e7ef1..21fea7d20 100644 --- a/docs/user-guide/kv-config.md +++ b/docs/user-guide/kv-config.md @@ -274,14 +274,14 @@ Here is the toml configuration we would like to store in the store : backend = "backend2" rule = "Path:/test" -[[tlsConfiguration]] +[[tls]] entryPoints = ["https"] - [tlsConfiguration.certificate] + [tls.certificate] certFile = "path/to/your.cert" keyFile = "path/to/your.key" -[[tlsConfiguration]] +[[tls]] entryPoints = ["https","other-https"] - [tlsConfiguration.certificate] + [tls.certificate] certFile = """-----BEGIN CERTIFICATE----- -----END CERTIFICATE-----""" @@ -335,19 +335,19 @@ And there, the same dynamic configuration in a KV Store (using `prefix = "traefi - certificate 1 -| Key | Value | -|----------------------------------------------------|--------------------| -| `/traefik/tlsconfiguration/1/entrypoints` | `https` | -| `/traefik/tlsconfiguration/1/certificate/certfile` | `path/to/your.cert`| -| `/traefik/tlsconfiguration/1/certificate/keyfile` | `path/to/your.key` | +| Key | Value | +|---------------------------------------|--------------------| +| `/traefik/tls/1/entrypoints` | `https` | +| `/traefik/tls/1/certificate/certfile` | `path/to/your.cert`| +| `/traefik/tls/1/certificate/keyfile` | `path/to/your.key` | - certificate 2 -| Key | Value | -|----------------------------------------------------|-----------------------| -| `/traefik/tlsconfiguration/2/entrypoints` | `https,other-https` | -| `/traefik/tlsconfiguration/2/certificate/certfile` | `` | -| `/traefik/tlsconfiguration/2/certificate/certfile` | `` | +| Key | Value | +|---------------------------------------|-----------------------| +| `/traefik/tls/2/entrypoints` | `https,other-https` | +| `/traefik/tls/2/certificate/certfile` | `` | +| `/traefik/tls/2/certificate/certfile` | `` | ### Atomic configuration changes diff --git a/examples/consul-config.sh b/examples/consul-config.sh index 94509e710..ee9066eeb 100755 --- a/examples/consul-config.sh +++ b/examples/consul-config.sh @@ -26,11 +26,11 @@ curl -i -H "Accept: application/json" -X PUT -d "Path:/test" ht # certificate 1 -curl -i -H "Accept: application/json" -X PUT -d "https" http://localhost:8500/v1/kv/traefik/tlsconfiguration/pair1/entrypoints -curl -i -H "Accept: application/json" -X PUT -d "/tmp/test1.crt" http://localhost:8500/v1/kv/traefik/tlsconfiguration/pair1/certificate/certfile -curl -i -H "Accept: application/json" -X PUT -d "/tmp/test1.key" http://localhost:8500/v1/kv/traefik/tlsconfiguration/pair1/certificate/keyfile +curl -i -H "Accept: application/json" -X PUT -d "https" http://localhost:8500/v1/kv/traefik/tls/pair1/entrypoints +curl -i -H "Accept: application/json" -X PUT -d "/tmp/test1.crt" http://localhost:8500/v1/kv/traefik/tls/pair1/certificate/certfile +curl -i -H "Accept: application/json" -X PUT -d "/tmp/test1.key" http://localhost:8500/v1/kv/traefik/tls/pair1/certificate/keyfile # certificate 2 -curl -i -H "Accept: application/json" -X PUT -d "http,https" http://localhost:8500/v1/kv/traefik/tlsconfiguration/pair2/entrypoints -curl -i -H "Accept: application/json" -X PUT -d "/tmp/test2.crt" http://localhost:8500/v1/kv/traefik/tlsconfiguration/pair2/certificate/certfile -curl -i -H "Accept: application/json" -X PUT -d "/tmp/test2.key" http://localhost:8500/v1/kv/traefik/tlsconfiguration/pair2/certificate/keyfile +curl -i -H "Accept: application/json" -X PUT -d "http,https" http://localhost:8500/v1/kv/traefik/tls/pair2/entrypoints +curl -i -H "Accept: application/json" -X PUT -d "/tmp/test2.crt" http://localhost:8500/v1/kv/traefik/tls/pair2/certificate/certfile +curl -i -H "Accept: application/json" -X PUT -d "/tmp/test2.key" http://localhost:8500/v1/kv/traefik/tls/pair2/certificate/keyfile diff --git a/examples/etcd-config.sh b/examples/etcd-config.sh index 6a5279957..0bb0b69c7 100755 --- a/examples/etcd-config.sh +++ b/examples/etcd-config.sh @@ -28,14 +28,14 @@ function insert_etcd2_data() { curl -i -H "Accept: application/json" -X PUT -d value="Path:/test" http://localhost:2379/v2/keys/traefik/frontends/frontend2/routes/test_2/rule # certificate 1 - curl -i -H "Accept: application/json" -X PUT -d value="https" http://localhost:2379/v2/keys/traefik/tlsconfiguration/pair1/entrypoints - curl -i -H "Accept: application/json" -X PUT -d value="/tmp/test1.crt" http://localhost:2379/v2/keys/traefik/tlsconfiguration/pair1/certificate/certfile - curl -i -H "Accept: application/json" -X PUT -d value="/tmp/test1.key" http://localhost:2379/v2/keys/traefik/tlsconfiguration/pair1/certificate/keyfile + curl -i -H "Accept: application/json" -X PUT -d value="https" http://localhost:2379/v2/keys/traefik/tls/pair1/entrypoints + curl -i -H "Accept: application/json" -X PUT -d value="/tmp/test1.crt" http://localhost:2379/v2/keys/traefik/tls/pair1/certificate/certfile + curl -i -H "Accept: application/json" -X PUT -d value="/tmp/test1.key" http://localhost:2379/v2/keys/traefik/tls/pair1/certificate/keyfile # certificate 2 - curl -i -H "Accept: application/json" -X PUT -d value="http,https" http://localhost:2379/v2/keys/traefik/tlsconfiguration/pair2/entrypoints - curl -i -H "Accept: application/json" -X PUT -d value="/tmp/test2.crt" http://localhost:2379/v2/keys/traefik/tlsconfiguration/pair2/certificate/certfile - curl -i -H "Accept: application/json" -X PUT -d value="/tmp/test2.key" http://localhost:2379/v2/keys/traefik/tlsconfiguration/pair2/certificate/keyfile + curl -i -H "Accept: application/json" -X PUT -d value="http,https" http://localhost:2379/v2/keys/traefik/tls/pair2/entrypoints + curl -i -H "Accept: application/json" -X PUT -d value="/tmp/test2.crt" http://localhost:2379/v2/keys/traefik/tls/pair2/certificate/certfile + curl -i -H "Accept: application/json" -X PUT -d value="/tmp/test2.key" http://localhost:2379/v2/keys/traefik/tls/pair2/certificate/keyfile } # @@ -71,14 +71,14 @@ function insert_etcd3_data() { docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/frontends/frontend2/routes/test_2/rule" "Path:/test" # certificate 1 - docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tlsconfiguration/pair1/entrypoints" "https" - docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tlsconfiguration/pair1/certificate/certfile" "/tmp/test1.crt" - docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tlsconfiguration/pair1/certificate/keyfile" "/tmp/test1.key" + docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tls/pair1/entrypoints" "https" + docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tls/pair1/certificate/certfile" "/tmp/test1.crt" + docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tls/pair1/certificate/keyfile" "/tmp/test1.key" # certificate 2 - docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tlsconfiguration/pair2/entrypoints" "https" - docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tlsconfiguration/pair2/certificate/certfile" "/tmp/test2.crt" - docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tlsconfiguration/pair2/certificate/keyfile" "/tmp/test2.key" + docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tls/pair2/entrypoints" "https" + docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tls/pair2/certificate/certfile" "/tmp/test2.crt" + docker container run --rm -ti -e ETCDCTL_DIAL_="TIMEOUT 10s" -e ETCDCTL_API="3" tenstartups/etcdctl --endpoints=[$etcd_ip:2379] put "/traefik/tls/pair2/certificate/keyfile" "/tmp/test2.key" } function show_usage() { diff --git a/integration/consul_test.go b/integration/consul_test.go index 112944dfb..049102ef3 100644 --- a/integration/consul_test.go +++ b/integration/consul_test.go @@ -564,15 +564,15 @@ func (s *ConsulSuite) TestSNIDynamicTlsConfig(c *check.C) { } tlsconfigure1 := map[string]string{ - "traefik/tlsconfiguration/snitestcom/entrypoints": "https", - "traefik/tlsconfiguration/snitestcom/certificate/keyfile": string(snitestComKey), - "traefik/tlsconfiguration/snitestcom/certificate/certfile": string(snitestComCert), + "traefik/tls/snitestcom/entrypoints": "https", + "traefik/tls/snitestcom/certificate/keyfile": string(snitestComKey), + "traefik/tls/snitestcom/certificate/certfile": string(snitestComCert), } tlsconfigure2 := map[string]string{ - "traefik/tlsconfiguration/snitestorg/entrypoints": "https", - "traefik/tlsconfiguration/snitestorg/certificate/keyfile": string(snitestOrgKey), - "traefik/tlsconfiguration/snitestorg/certificate/certfile": string(snitestOrgCert), + "traefik/tls/snitestorg/entrypoints": "https", + "traefik/tls/snitestorg/certificate/keyfile": string(snitestOrgKey), + "traefik/tls/snitestorg/certificate/certfile": string(snitestOrgCert), } // config backends,frontends and first tls keypair @@ -613,7 +613,7 @@ func (s *ConsulSuite) TestSNIDynamicTlsConfig(c *check.C) { // wait for consul err = try.Do(60*time.Second, func() error { - _, err := s.kv.Get("traefik/tlsconfiguration/snitestcom/certificate/keyfile", nil) + _, err := s.kv.Get("traefik/tls/snitestcom/certificate/keyfile", nil) return err }) c.Assert(err, checker.IsNil) @@ -642,7 +642,7 @@ func (s *ConsulSuite) TestSNIDynamicTlsConfig(c *check.C) { // wait for consul err = try.Do(60*time.Second, func() error { - _, err := s.kv.Get("traefik/tlsconfiguration/snitestorg/certificate/keyfile", nil) + _, err := s.kv.Get("traefik/tls/snitestorg/certificate/keyfile", nil) return err }) c.Assert(err, checker.IsNil) diff --git a/integration/etcd3_test.go b/integration/etcd3_test.go index 1fce96a91..ebd9ecf80 100644 --- a/integration/etcd3_test.go +++ b/integration/etcd3_test.go @@ -474,15 +474,15 @@ func (s *Etcd3Suite) TestSNIDynamicTlsConfig(c *check.C) { } tlsconfigure1 := map[string]string{ - "/traefik/tlsconfiguration/snitestcom/entrypoints": "https", - "/traefik/tlsconfiguration/snitestcom/certificate/keyfile": string(snitestComKey), - "/traefik/tlsconfiguration/snitestcom/certificate/certfile": string(snitestComCert), + "/traefik/tls/snitestcom/entrypoints": "https", + "/traefik/tls/snitestcom/certificate/keyfile": string(snitestComKey), + "/traefik/tls/snitestcom/certificate/certfile": string(snitestComCert), } tlsconfigure2 := map[string]string{ - "/traefik/tlsconfiguration/snitestorg/entrypoints": "https", - "/traefik/tlsconfiguration/snitestorg/certificate/keyfile": string(snitestOrgKey), - "/traefik/tlsconfiguration/snitestorg/certificate/certfile": string(snitestOrgCert), + "/traefik/tls/snitestorg/entrypoints": "https", + "/traefik/tls/snitestorg/certificate/keyfile": string(snitestOrgKey), + "/traefik/tls/snitestorg/certificate/certfile": string(snitestOrgCert), } // config backends,frontends and first tls keypair @@ -523,7 +523,7 @@ func (s *Etcd3Suite) TestSNIDynamicTlsConfig(c *check.C) { // wait for etcd err = try.Do(60*time.Second, func() error { - _, err := s.kv.Get("/traefik/tlsconfiguration/snitestcom/certificate/keyfile", nil) + _, err := s.kv.Get("/traefik/tls/snitestcom/certificate/keyfile", nil) return err }) c.Assert(err, checker.IsNil) @@ -557,7 +557,7 @@ func (s *Etcd3Suite) TestSNIDynamicTlsConfig(c *check.C) { // wait for etcd err = try.Do(60*time.Second, func() error { - _, err := s.kv.Get("/traefik/tlsconfiguration/snitestorg/certificate/keyfile", nil) + _, err := s.kv.Get("/traefik/tls/snitestorg/certificate/keyfile", nil) return err }) c.Assert(err, checker.IsNil) @@ -609,9 +609,9 @@ func (s *Etcd3Suite) TestDeleteSNIDynamicTlsConfig(c *check.C) { } tlsconfigure1 := map[string]string{ - "/traefik/tlsconfiguration/snitestcom/entrypoints": "https", - "/traefik/tlsconfiguration/snitestcom/certificate/keyfile": string(snitestComKey), - "/traefik/tlsconfiguration/snitestcom/certificate/certfile": string(snitestComCert), + "/traefik/tls/snitestcom/entrypoints": "https", + "/traefik/tls/snitestcom/certificate/keyfile": string(snitestComKey), + "/traefik/tls/snitestcom/certificate/certfile": string(snitestComCert), } // config backends,frontends and first tls keypair @@ -637,7 +637,7 @@ func (s *Etcd3Suite) TestDeleteSNIDynamicTlsConfig(c *check.C) { // wait for etcd err = try.Do(60*time.Second, func() error { - _, err := s.kv.Get("/traefik/tlsconfiguration/snitestcom/certificate/keyfile", nil) + _, err := s.kv.Get("/traefik/tls/snitestcom/certificate/keyfile", nil) return err }) c.Assert(err, checker.IsNil) diff --git a/integration/etcd_test.go b/integration/etcd_test.go index d0470729a..986a7065d 100644 --- a/integration/etcd_test.go +++ b/integration/etcd_test.go @@ -490,15 +490,15 @@ func (s *EtcdSuite) TestSNIDynamicTlsConfig(c *check.C) { } tlsconfigure1 := map[string]string{ - "/traefik/tlsconfiguration/snitestcom/entrypoints": "https", - "/traefik/tlsconfiguration/snitestcom/certificate/keyfile": string(snitestComKey), - "/traefik/tlsconfiguration/snitestcom/certificate/certfile": string(snitestComCert), + "/traefik/tls/snitestcom/entrypoints": "https", + "/traefik/tls/snitestcom/certificate/keyfile": string(snitestComKey), + "/traefik/tls/snitestcom/certificate/certfile": string(snitestComCert), } tlsconfigure2 := map[string]string{ - "/traefik/tlsconfiguration/snitestorg/entrypoints": "https", - "/traefik/tlsconfiguration/snitestorg/certificate/keyfile": string(snitestOrgKey), - "/traefik/tlsconfiguration/snitestorg/certificate/certfile": string(snitestOrgCert), + "/traefik/tls/snitestorg/entrypoints": "https", + "/traefik/tls/snitestorg/certificate/keyfile": string(snitestOrgKey), + "/traefik/tls/snitestorg/certificate/certfile": string(snitestOrgCert), } // config backends,frontends and first tls keypair @@ -539,7 +539,7 @@ func (s *EtcdSuite) TestSNIDynamicTlsConfig(c *check.C) { // wait for etcd err = try.Do(60*time.Second, func() error { - _, err := s.kv.Get("/traefik/tlsconfiguration/snitestcom/certificate/keyfile", nil) + _, err := s.kv.Get("/traefik/tls/snitestcom/certificate/keyfile", nil) return err }) c.Assert(err, checker.IsNil) @@ -573,7 +573,7 @@ func (s *EtcdSuite) TestSNIDynamicTlsConfig(c *check.C) { // wait for etcd err = try.Do(60*time.Second, func() error { - _, err := s.kv.Get("/traefik/tlsconfiguration/snitestorg/certificate/keyfile", nil) + _, err := s.kv.Get("/traefik/tls/snitestorg/certificate/keyfile", nil) return err }) c.Assert(err, checker.IsNil) diff --git a/integration/fixtures/acme/certificates.toml b/integration/fixtures/acme/certificates.toml index 5e0693f96..c0bdc831b 100644 --- a/integration/fixtures/acme/certificates.toml +++ b/integration/fixtures/acme/certificates.toml @@ -9,8 +9,8 @@ [frontends.frontend.routes.test] rule = "Host:traefik.acme.wtf" -[[tlsConfiguration]] +[[tls]] entryPoints = ["https"] - [tlsConfiguration.certificate] + [tls.certificate] certFile = "fixtures/acme/ssl/wildcard.crt" keyFile = "fixtures/acme/ssl/wildcard.key" \ No newline at end of file diff --git a/integration/fixtures/https/dynamic_https.toml b/integration/fixtures/https/dynamic_https.toml index aa513ba6d..ad530081a 100644 --- a/integration/fixtures/https/dynamic_https.toml +++ b/integration/fixtures/https/dynamic_https.toml @@ -16,9 +16,9 @@ [frontends.frontend2.routes.test_2] rule = "Host:snitest.org" -[[tlsConfiguration]] +[[tls]] entryPoints = ["https"] - [tlsConfiguration.certificate] + [tls.certificate] certFile = """-----BEGIN CERTIFICATE----- MIIC/zCCAeegAwIBAgIJALAYHG/vGqWEMA0GCSqGSIb3DQEBBQUAMBYxFDASBgNV BAMMC3NuaXRlc3Qub3JnMB4XDTE1MTEyMzIyMDU0NFoXDTI1MTEyMDIyMDU0NFow diff --git a/integration/https_test.go b/integration/https_test.go index 2582dfcda..dad461fff 100644 --- a/integration/https_test.go +++ b/integration/https_test.go @@ -624,7 +624,7 @@ func modifyCertificateConfFileContent(c *check.C, certFileName, confFileName, en // If certificate file is not provided, just truncate the configuration file if len(certFileName) > 0 { tlsConf := types.Configuration{ - TLSConfiguration: []*traefikTls.Configuration{ + TLS: []*traefikTls.Configuration{ { Certificate: &traefikTls.Certificate{ CertFile: traefikTls.FileOrContent("fixtures/https/" + certFileName + ".cert"), diff --git a/provider/file/file.go b/provider/file/file.go index 06e25bb2c..d32c022dc 100644 --- a/provider/file/file.go +++ b/provider/file/file.go @@ -186,7 +186,7 @@ func loadFileConfigFromDirectory(directory string, configuration *types.Configur } } - for _, conf := range c.TLSConfiguration { + for _, conf := range c.TLS { if _, exists := configTLSMaps[conf]; exists { log.Warnf("TLS Configuration %v already configured, skipping", conf) } else { @@ -196,7 +196,7 @@ func loadFileConfigFromDirectory(directory string, configuration *types.Configur } for conf := range configTLSMaps { - configuration.TLSConfiguration = append(configuration.TLSConfiguration, conf) + configuration.TLS = append(configuration.TLS, conf) } return configuration, nil } diff --git a/provider/file/file_test.go b/provider/file/file_test.go index af622d741..649fc32ae 100644 --- a/provider/file/file_test.go +++ b/provider/file/file_test.go @@ -26,7 +26,7 @@ func TestProvideSingleFileAndWatch(t *testing.T) { tempDir, "simple.toml", createFrontendConfiguration(expectedNumFrontends), createBackendConfiguration(expectedNumBackends), - createTLSConfiguration(expectedNumTLSConf)) + createTLS(expectedNumTLSConf)) configurationChan, signal := createConfigurationRoutine(t, &expectedNumFrontends, &expectedNumBackends, &expectedNumTLSConf) @@ -45,7 +45,7 @@ func TestProvideSingleFileAndWatch(t *testing.T) { tempDir, "simple.toml", createFrontendConfiguration(expectedNumFrontends), createBackendConfiguration(expectedNumBackends), - createTLSConfiguration(expectedNumTLSConf)) + createTLS(expectedNumTLSConf)) err = waitForSignal(signal, 2*time.Second, "single frontend, backend, TLS configuration") assert.NoError(t, err) @@ -63,7 +63,7 @@ func TestProvideSingleFileAndNotWatch(t *testing.T) { tempDir, "simple.toml", createFrontendConfiguration(expectedNumFrontends), createBackendConfiguration(expectedNumBackends), - createTLSConfiguration(expectedNumTLSConf)) + createTLS(expectedNumTLSConf)) configurationChan, signal := createConfigurationRoutine(t, &expectedNumFrontends, &expectedNumBackends, &expectedNumTLSConf) @@ -82,7 +82,7 @@ func TestProvideSingleFileAndNotWatch(t *testing.T) { tempDir, "simple.toml", createFrontendConfiguration(expectedNumFrontends), createBackendConfiguration(expectedNumBackends), - createTLSConfiguration(expectedNumTLSConf)) + createTLS(expectedNumTLSConf)) // Must fail because we don't watch the changes err = waitForSignal(signal, 2*time.Second, "single frontend, backend and TLS configuration") @@ -99,7 +99,7 @@ func TestProvideDirectoryAndWatch(t *testing.T) { tempFile1 := createRandomFile(t, tempDir, createFrontendConfiguration(expectedNumFrontends)) tempFile2 := createRandomFile(t, tempDir, createBackendConfiguration(expectedNumBackends)) - tempFile3 := createRandomFile(t, tempDir, createTLSConfiguration(expectedNumTLSConf)) + tempFile3 := createRandomFile(t, tempDir, createTLS(expectedNumTLSConf)) configurationChan, signal := createConfigurationRoutine(t, &expectedNumFrontends, &expectedNumBackends, &expectedNumTLSConf) @@ -145,7 +145,7 @@ func TestProvideDirectoryAndNotWatch(t *testing.T) { createRandomFile(t, tempDir, createFrontendConfiguration(expectedNumFrontends)) tempFile2 := createRandomFile(t, tempDir, createBackendConfiguration(expectedNumBackends)) - createRandomFile(t, tempTLSDir, createTLSConfiguration(expectedNumTLSConf)) + createRandomFile(t, tempTLSDir, createTLS(expectedNumTLSConf)) configurationChan, signal := createConfigurationRoutine(t, &expectedNumFrontends, &expectedNumBackends, &expectedNumTLSConf) @@ -167,7 +167,7 @@ func TestProvideDirectoryAndNotWatch(t *testing.T) { } -func createConfigurationRoutine(t *testing.T, expectedNumFrontends *int, expectedNumBackends *int, expectedNumTLSConfigurations *int) (chan types.ConfigMessage, chan interface{}) { +func createConfigurationRoutine(t *testing.T, expectedNumFrontends *int, expectedNumBackends *int, expectedNumTLSes *int) (chan types.ConfigMessage, chan interface{}) { configurationChan := make(chan types.ConfigMessage) signal := make(chan interface{}) @@ -177,7 +177,7 @@ func createConfigurationRoutine(t *testing.T, expectedNumFrontends *int, expecte assert.Equal(t, "file", data.ProviderName) assert.Len(t, data.Configuration.Frontends, *expectedNumFrontends) assert.Len(t, data.Configuration.Backends, *expectedNumBackends) - assert.Len(t, data.Configuration.TLSConfiguration, *expectedNumTLSConfigurations) + assert.Len(t, data.Configuration.TLS, *expectedNumTLSes) signal <- nil } }) @@ -297,13 +297,13 @@ func createBackendConfiguration(n int) string { return conf } -// createTLSConfiguration Helper -func createTLSConfiguration(n int) string { +// createTLS Helper +func createTLS(n int) string { var conf string for i := 1; i <= n; i++ { - conf += fmt.Sprintf(`[[TLSConfiguration]] + conf += fmt.Sprintf(`[[TLS]] EntryPoints = ["https"] - [TLSConfiguration.Certificate] + [TLS.Certificate] CertFile = "integration/fixtures/https/snitest%[1]d.com.cert" KeyFile = "integration/fixtures/https/snitest%[1]d.com.key" `, i) diff --git a/server/server.go b/server/server.go index 971bb49a8..76729409e 100644 --- a/server/server.go +++ b/server/server.go @@ -357,7 +357,7 @@ func (s *Server) preLoadConfiguration(configMsg types.ConfigMessage) { currentConfigurations := s.currentConfigurations.Get().(types.Configurations) jsonConf, _ := json.Marshal(configMsg.Configuration) log.Debugf("Configuration received from provider %s: %s", configMsg.ProviderName, string(jsonConf)) - if configMsg.Configuration == nil || configMsg.Configuration.Backends == nil && configMsg.Configuration.Frontends == nil && configMsg.Configuration.TLSConfiguration == nil { + if configMsg.Configuration == nil || configMsg.Configuration.Backends == nil && configMsg.Configuration.Frontends == nil && configMsg.Configuration.TLS == nil { log.Infof("Skipping empty Configuration for provider %s", configMsg.ProviderName) } else if reflect.DeepEqual(currentConfigurations[configMsg.ProviderName], configMsg.Configuration) { log.Infof("Skipping same configuration for provider %s", configMsg.ProviderName) @@ -462,8 +462,8 @@ func (s *Server) loadHTTPSConfiguration(configurations types.Configurations) (ma newEPCertificates := make(map[string]*traefikTls.DomainsCertificates) // Get all certificates for _, configuration := range configurations { - if configuration.TLSConfiguration != nil && len(configuration.TLSConfiguration) > 0 { - if err := traefikTls.SortTLSConfigurationPerEntryPoints(configuration.TLSConfiguration, newEPCertificates); err != nil { + if configuration.TLS != nil && len(configuration.TLS) > 0 { + if err := traefikTls.SortTLSPerEntryPoints(configuration.TLS, newEPCertificates); err != nil { return nil, err } } diff --git a/server/server_test.go b/server/server_test.go index 919b910ca..72a0e5f42 100644 --- a/server/server_test.go +++ b/server/server_test.go @@ -463,7 +463,7 @@ func TestServerLoadConfigHealthCheckOptions(t *testing.T) { HealthCheck: healthCheck, }, }, - TLSConfiguration: []*tls.Configuration{ + TLS: []*tls.Configuration{ { Certificate: &tls.Certificate{ CertFile: localhostCert, @@ -644,7 +644,7 @@ func TestServerLoadConfigEmptyBasicAuth(t *testing.T) { }, }, }, - TLSConfiguration: []*tls.Configuration{ + TLS: []*tls.Configuration{ { Certificate: &tls.Certificate{ CertFile: localhostCert, diff --git a/templates/kv.tmpl b/templates/kv.tmpl index fc4ab782f..21de5604e 100644 --- a/templates/kv.tmpl +++ b/templates/kv.tmpl @@ -1,6 +1,6 @@ {{$frontends := List .Prefix "/frontends/" }} {{$backends := List .Prefix "/backends/"}} -{{$tlsconfiguration := List .Prefix "/tlsconfiguration/"}} +{{$tls := List .Prefix "/tls/"}} [backends]{{range $backends}} {{$backend := .}} @@ -65,13 +65,13 @@ {{end}} {{end}} -{{range $tlsconfiguration}} +{{range $tls}} {{$entryPoints := SplitGet . "/entrypoints"}} -[[tlsConfiguration]] +[[tls]] entryPoints = [{{range $entryPoints}} "{{.}}", {{end}}] - [tlsConfiguration.certificate] + [tls.certificate] certFile = """{{Get "" . "/certificate" "/certfile"}}""" keyFile = """{{Get "" . "/certificate" "/keyfile"}}""" {{end}} diff --git a/tls/tls.go b/tls/tls.go index 1798da12d..d25d99eef 100644 --- a/tls/tls.go +++ b/tls/tls.go @@ -86,8 +86,8 @@ func (r *RootCAs) Type() string { return "rootcas" } -// SortTLSConfigurationPerEntryPoints converts TLS configuration sorted by Certificates into TLS configuration sorted by EntryPoints -func SortTLSConfigurationPerEntryPoints(configurations []*Configuration, epConfiguration map[string]*DomainsCertificates) error { +// SortTLSPerEntryPoints converts TLS configuration sorted by Certificates into TLS configuration sorted by EntryPoints +func SortTLSPerEntryPoints(configurations []*Configuration, epConfiguration map[string]*DomainsCertificates) error { if epConfiguration == nil { epConfiguration = make(map[string]*DomainsCertificates) } diff --git a/types/types.go b/types/types.go index 2f337e65d..7439ceae6 100644 --- a/types/types.go +++ b/types/types.go @@ -197,9 +197,9 @@ type Configurations map[string]*Configuration // Configuration of a provider. type Configuration struct { - Backends map[string]*Backend `json:"backends,omitempty"` - Frontends map[string]*Frontend `json:"frontends,omitempty"` - TLSConfiguration []*traefikTls.Configuration `json:"tlsConfiguration,omitempty"` + Backends map[string]*Backend `json:"backends,omitempty"` + Frontends map[string]*Frontend `json:"frontends,omitempty"` + TLS []*traefikTls.Configuration `json:"tls,omitempty"` } // ConfigMessage hold configuration information exchanged between parts of traefik.