traefik/pkg/middlewares/headers/secure_test.go

package headers

import (
	"net/http"
	"net/http/httptest"
	"testing"

	"github.com/containous/traefik/v2/pkg/config/dynamic"
	"github.com/stretchr/testify/assert"
)

// Middleware tests based on https://github.com/unrolled/secure

func Test_newSecure_sslForceHost(t *testing.T) {
	type expected struct {
		statusCode int
		location   string
	}

	testCases := []struct {
		desc string
		host string
		cfg  dynamic.Headers
		expected
	}{
		{
			desc: "http should return a 301",
			host: "http://powpow.example.com",
			cfg: dynamic.Headers{
				SSLRedirect:  true,
				SSLForceHost: true,
				SSLHost:      "powpow.example.com",
			},
			expected: expected{
				statusCode: http.StatusMovedPermanently,
				location:   "https://powpow.example.com",
			},
		},
		{
			desc: "http sub domain should return a 301",
			host: "http://www.powpow.example.com",
			cfg: dynamic.Headers{
				SSLRedirect:  true,
				SSLForceHost: true,
				SSLHost:      "powpow.example.com",
			},
			expected: expected{
				statusCode: http.StatusMovedPermanently,
				location:   "https://powpow.example.com",
			},
		},
		{
			desc: "https should return a 200",
			host: "https://powpow.example.com",
			cfg: dynamic.Headers{
				SSLRedirect:  true,
				SSLForceHost: true,
				SSLHost:      "powpow.example.com",
			},
			expected: expected{statusCode: http.StatusOK},
		},
		{
			desc: "https sub domain should return a 301",
			host: "https://www.powpow.example.com",
			cfg: dynamic.Headers{
				SSLRedirect:  true,
				SSLForceHost: true,
				SSLHost:      "powpow.example.com",
			},
			expected: expected{
				statusCode: http.StatusMovedPermanently,
				location:   "https://powpow.example.com",
			},
		},
		{
			desc: "http without force host and sub domain should return a 301",
			host: "http://www.powpow.example.com",
			cfg: dynamic.Headers{
				SSLRedirect:  true,
				SSLForceHost: false,
				SSLHost:      "powpow.example.com",
			},
			expected: expected{
				statusCode: http.StatusMovedPermanently,
				location:   "https://powpow.example.com",
			},
		},
		{
			desc: "https without force host and sub domain should return a 301",
			host: "https://www.powpow.example.com",
			cfg: dynamic.Headers{
				SSLRedirect:  true,
				SSLForceHost: false,
				SSLHost:      "powpow.example.com",
			},
			expected: expected{statusCode: http.StatusOK},
		},
	}

	next := http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
		_, _ = rw.Write([]byte("OK"))
	})

	for _, test := range testCases {
		t.Run(test.desc, func(t *testing.T) {
			mid := newSecure(next, test.cfg, "mymiddleware")

			req := httptest.NewRequest(http.MethodGet, test.host, nil)

			rw := httptest.NewRecorder()

			mid.ServeHTTP(rw, req)

			assert.Equal(t, test.expected.statusCode, rw.Result().StatusCode)
			assert.Equal(t, test.expected.location, rw.Header().Get("Location"))
		})
	}
}

func Test_newSecure_modifyResponse(t *testing.T) {
	testCases := []struct {
		desc     string
		cfg      dynamic.Headers
		expected http.Header
	}{
		{
			desc: "FeaturePolicy",
			cfg: dynamic.Headers{
				FeaturePolicy: "vibrate 'none';",
			},
			expected: http.Header{"Feature-Policy": []string{"vibrate 'none';"}},
		},
		{
			desc: "STSSeconds",
			cfg: dynamic.Headers{
				STSSeconds:     1,
				ForceSTSHeader: true,
			},
			expected: http.Header{"Strict-Transport-Security": []string{"max-age=1"}},
		},
		{
			desc: "STSSeconds and STSPreload",
			cfg: dynamic.Headers{
				STSSeconds:     1,
				ForceSTSHeader: true,
				STSPreload:     true,
			},
			expected: http.Header{"Strict-Transport-Security": []string{"max-age=1; preload"}},
		},
		{
			desc: "CustomFrameOptionsValue",
			cfg: dynamic.Headers{
				CustomFrameOptionsValue: "foo",
			},
			expected: http.Header{"X-Frame-Options": []string{"foo"}},
		},
		{
			desc: "FrameDeny",
			cfg: dynamic.Headers{
				FrameDeny: true,
			},
			expected: http.Header{"X-Frame-Options": []string{"DENY"}},
		},
		{
			desc: "ContentTypeNosniff",
			cfg: dynamic.Headers{
				ContentTypeNosniff: true,
			},
			expected: http.Header{"X-Content-Type-Options": []string{"nosniff"}},
		},
	}

	emptyHandler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) })

	for _, test := range testCases {
		test := test
		t.Run(test.desc, func(t *testing.T) {
			t.Parallel()

			secure := newSecure(emptyHandler, test.cfg, "mymiddleware")

			req := httptest.NewRequest(http.MethodGet, "/foo", nil)

			rw := httptest.NewRecorder()

			secure.ServeHTTP(rw, req)

			assert.Equal(t, test.expected, rw.Result().Header)
		})
	}
}