From bea683e3bf92e9dd3cbe7346d47197549b460b3e Mon Sep 17 00:00:00 2001 From: Soroush Javadi Date: Thu, 10 Aug 2023 20:27:49 +0330 Subject: [PATCH] cmd: check GetBlobsPath error (#317) The error returned by `server.GetBlobsPath` in `showLayer` was never checked. Check the error and return if not nil. Also, make newlines at the end of error messages consistent and fix a typo. --- cmd/cmd.go | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/cmd/cmd.go b/cmd/cmd.go index 8f9f1968..803988ae 100644 --- a/cmd/cmd.go +++ b/cmd/cmd.go @@ -318,12 +318,16 @@ func generate(cmd *cobra.Command, model, prompt string) error { func showLayer(l *server.Layer) { filename, err := server.GetBlobsPath(l.Digest) - bts, err := os.ReadFile(filename) if err != nil { - fmt.Printf("Couldn't read layer") + fmt.Println("Couldn't get layer's path") return } - fmt.Printf(string(bts) + "\n") + bts, err := os.ReadFile(filename) + if err != nil { + fmt.Println("Couldn't read layer") + return + } + fmt.Println(string(bts)) } func generateInteractive(cmd *cobra.Command, model string) error { @@ -460,7 +464,7 @@ func generateInteractive(cmd *cobra.Command, model string) error { mp := server.ParseModelPath(model) manifest, err := server.GetManifest(mp) if err != nil { - fmt.Printf("error: couldn't get a manifestfor this model") + fmt.Println("error: couldn't get a manifest for this model") continue } switch args[1] {