baalajimaestro/ollama
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

types/model: add FilepathNoBuild (#3680)

Browse source 
Also, add test for DisplayLongest.

Also, plumb fill param to ParseName in MustParseName
This commit is contained in:
Blake Mizerany 2024-04-16 18:35:43 -07:00 committed by GitHub
parent fb9580df85
commit 9df6c85c3a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 42 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
types/model/name.go
View file

@ -185,8 +185,8 @@ func parseMask(s string) Name {
return r return r
} }
func MustParseName(s, defaults string) Name { func MustParseName(s, fill string) Name {
r := ParseName(s, "") r := ParseName(s, fill)
if !r.IsValid() { if !r.IsValid() {
panic("invalid Name: " + s) panic("invalid Name: " + s)
} }
@ -643,6 +643,15 @@ func (r Name) Filepath() string {
return filepath.Join(r.parts[:]...) return filepath.Join(r.parts[:]...)
} }
// FilepathNoBuild returns a complete, canonicalized, relative file path using
// the parts of a complete Name, but without the build part.
func (r Name) FilepathNoBuild() string {
for i := range PartBuild {
r.parts[i] = strings.ToLower(r.parts[i])
}
return filepath.Join(r.parts[:PartBuild]...)
}
// isValidPart reports if s contains all valid characters for the given // isValidPart reports if s contains all valid characters for the given
// part kind. // part kind.
func isValidPart(kind PartKind, s string) bool { func isValidPart(kind PartKind, s string) bool {

44
types/model/name_test.go
View file

@ -318,6 +318,13 @@ func TestNameGoString(t *testing.T) {
} }
} }
func TestDisplayLongest(t *testing.T) {
g := ParseName("example.com/library/mistral:latest+Q4_0", FillNothing).DisplayLongest()
if g != "example.com/library/mistral:latest" {
t.Errorf("got = %q; want %q", g, "example.com/library/mistral:latest")
}
}
func TestDisplayShortest(t *testing.T) { func TestDisplayShortest(t *testing.T) {
cases := []struct { cases := []struct {
in string in string
@ -478,30 +485,36 @@ func TestNamePath(t *testing.T) {
} }
} }
func TestNameFromFilepath(t *testing.T) { func TestNameFilepath(t *testing.T) {
cases := []struct { cases := []struct {
in string in string
want string want string
wantNoBuild string
}{ }{
{ {
in: "example.com/library/mistral:latest+Q4_0", in: "example.com/library/mistral:latest+Q4_0",
want: "example.com/library/mistral/latest/Q4_0", want: "example.com/library/mistral/latest/Q4_0",
wantNoBuild: "example.com/library/mistral/latest",
}, },
{ {
in: "Example.Com/Library/Mistral:Latest+Q4_0", in: "Example.Com/Library/Mistral:Latest+Q4_0",
want: "example.com/library/mistral/latest/Q4_0", want: "example.com/library/mistral/latest/Q4_0",
wantNoBuild: "example.com/library/mistral/latest",
}, },
{ {
in: "Example.Com/Library/Mistral:Latest+Q4_0", in: "Example.Com/Library/Mistral:Latest+Q4_0",
want: "example.com/library/mistral/latest/Q4_0", want: "example.com/library/mistral/latest/Q4_0",
wantNoBuild: "example.com/library/mistral/latest",
}, },
{ {
in: "example.com/library/mistral:latest", in: "example.com/library/mistral:latest",
want: "example.com/library/mistral/latest", want: "example.com/library/mistral/latest",
wantNoBuild: "example.com/library/mistral/latest",
}, },
{ {
in: "", in: "",
want: "", want: "",
wantNoBuild: "",
}, },
} }
for _, tt := range cases { for _, tt := range cases {
@ -513,6 +526,11 @@ func TestNameFromFilepath(t *testing.T) {
if g != tt.want { if g != tt.want {
t.Errorf("got = %q; want %q", g, tt.want) t.Errorf("got = %q; want %q", g, tt.want)
} }
g = p.FilepathNoBuild()
g = filepath.ToSlash(g)
if g != tt.wantNoBuild {
t.Errorf("got = %q; want %q", g, tt.wantNoBuild)
}
}) })
} }
} }