From 7e8f7c835859b54abe50dc855f90357db27c7059 Mon Sep 17 00:00:00 2001 From: Bruce MacDonald Date: Mon, 8 Jan 2024 14:41:01 -0500 Subject: [PATCH] remove ggml automatic re-pull (#1856) --- cmd/cmd.go | 16 +--------------- server/images.go | 26 -------------------------- 2 files changed, 1 insertion(+), 41 deletions(-) diff --git a/cmd/cmd.go b/cmd/cmd.go index 14293cab..794e8780 100644 --- a/cmd/cmd.go +++ b/cmd/cmd.go @@ -149,7 +149,7 @@ func RunHandler(cmd *cobra.Command, args []string) error { name := args[0] // check if the model exists on the server - model, err := client.Show(cmd.Context(), &api.ShowRequest{Name: name}) + _, err = client.Show(cmd.Context(), &api.ShowRequest{Name: name}) var statusError api.StatusError switch { case errors.As(err, &statusError) && statusError.StatusCode == http.StatusNotFound: @@ -158,20 +158,6 @@ func RunHandler(cmd *cobra.Command, args []string) error { } case err != nil: return err - default: - // the model was found, check if it is in the correct format - if model.Details.Format != "" && model.Details.Format != "gguf" { - // pull and retry to see if the model has been updated - parts := strings.Split(name, string(os.PathSeparator)) - if len(parts) == 1 { - // this is a library model, log some info - fmt.Fprintln(os.Stderr, "This model is no longer compatible with Ollama. Pulling a new version...") - } - if err := PullHandler(cmd, []string{name}); err != nil { - fmt.Printf("Error: %s\n", err) - return fmt.Errorf("unsupported model, please update this model to gguf format") // relay the original error - } - } } return RunGenerate(cmd, args) diff --git a/server/images.go b/server/images.go index 98e40e18..346ff592 100644 --- a/server/images.go +++ b/server/images.go @@ -478,32 +478,6 @@ func CreateModel(ctx context.Context, name, modelFileDir string, commands []pars return err } - // if the model is not in gguf format, pull the base model to try and get it in gguf format - if fromConfig.ModelFormat != "gguf" { - fn(api.ProgressResponse{Status: "updating base model"}) - parent, err := GetModel(c.Args) - if err != nil { - return err - } - - originalModel := parent.OriginalModel - if originalModel == "" { - originalModel = parent.ShortName - } - if err := PullModel(ctx, originalModel, &RegistryOptions{}, fn); err != nil { - log.Printf("error pulling parent model: %v", err) - } - - // Reset the file pointer to the beginning of the file - _, err = fromConfigFile.Seek(0, 0) - if err != nil { - return fmt.Errorf("update from config after pull: %w", err) - } - if err := json.NewDecoder(fromConfigFile).Decode(&fromConfig); err != nil { - return err - } - } - // if the model is still not in gguf format, error out if fromConfig.ModelFormat != "gguf" { return fmt.Errorf("%s is not in gguf format, this base model is not compatible with this version of ollama", c.Args)