From 798b107f19ed832d33a6816f11363b42888aaed3 Mon Sep 17 00:00:00 2001 From: Ryo Machida <55428929+machimachida@users.noreply.github.com> Date: Wed, 15 May 2024 03:18:10 +0900 Subject: [PATCH] Fixed the API endpoint /api/tags when the model list is empty. (#4424) * Fixed the API endpoint /api/tags to return {models: []} instead of {models: null} when the model list is empty. * Update server/routes.go --------- Co-authored-by: Jeffrey Morgan --- server/routes.go | 2 +- server/routes_test.go | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/server/routes.go b/server/routes.go index aaa461c2..123ef9a3 100644 --- a/server/routes.go +++ b/server/routes.go @@ -725,7 +725,7 @@ func (s *Server) ListModelsHandler(c *gin.Context) { return } - var models []api.ModelResponse + models := []api.ModelResponse{} if err := filepath.Walk(manifests, func(path string, info os.FileInfo, _ error) error { if !info.IsDir() { rel, err := filepath.Rel(manifests, path) diff --git a/server/routes_test.go b/server/routes_test.go index 896dc27b..e144c957 100644 --- a/server/routes_test.go +++ b/server/routes_test.go @@ -95,6 +95,7 @@ func Test_Routes(t *testing.T) { err = json.Unmarshal(body, &modelList) assert.Nil(t, err) + assert.NotNil(t, modelList.Models) assert.Equal(t, 0, len(modelList.Models)) }, },