fix: store accurate model parameter size (#4058)

- add test for number formatting
- fix bug where 1B and 1M were not stored correctly
- display 2 decimal points for million param sizes
- display 1 decimal point for billion param sizes
This commit is contained in:
Bruce MacDonald 2024-05-07 14:41:53 -07:00 committed by GitHub
parent 34bea2e272
commit 527e9be058
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 48 additions and 6 deletions

View file

@ -13,12 +13,20 @@ const (
func HumanNumber(b uint64) string { func HumanNumber(b uint64) string {
switch { switch {
case b > Billion: case b >= Billion:
return fmt.Sprintf("%.0fB", math.Round(float64(b)/Billion)) number := float64(b) / Billion
case b > Million: if number == math.Floor(number) {
return fmt.Sprintf("%.0fM", math.Round(float64(b)/Million)) return fmt.Sprintf("%.0fB", number) // no decimals if whole number
case b > Thousand: }
return fmt.Sprintf("%.0fK", math.Round(float64(b)/Thousand)) return fmt.Sprintf("%.1fB", number) // one decimal if not a whole number
case b >= Million:
number := float64(b) / Million
if number == math.Floor(number) {
return fmt.Sprintf("%.0fM", number) // no decimals if whole number
}
return fmt.Sprintf("%.2fM", number) // two decimals if not a whole number
case b >= Thousand:
return fmt.Sprintf("%.0fK", float64(b)/Thousand)
default: default:
return fmt.Sprintf("%d", b) return fmt.Sprintf("%d", b)
} }

34
format/format_test.go Normal file
View file

@ -0,0 +1,34 @@
package format
import (
"testing"
)
func TestHumanNumber(t *testing.T) {
type testCase struct {
input uint64
expected string
}
testCases := []testCase{
{0, "0"},
{1000000, "1M"},
{125000000, "125M"},
{500500000, "500.50M"},
{500550000, "500.55M"},
{1000000000, "1B"},
{2800000000, "2.8B"},
{2850000000, "2.9B"},
{1000000000000, "1000B"},
}
for _, tc := range testCases {
t.Run(tc.expected, func(t *testing.T) {
result := HumanNumber(tc.input)
if result != tc.expected {
t.Errorf("Expected %s, got %s", tc.expected, result)
}
})
}
}