Commit graph

152 commits

Author SHA1 Message Date
opusforlife2
090c063644
Address Bopol's review
Changed the location, added option to delete, and also fixed a tiny grammar thingy.
2021-06-24 15:15:12 +00:00
opusforlife2
ec40c8ed1e
Merge pull request #6482 from Stypox/build-instructions
Update Build instructions to make it easier for contributors to start contributing.
2021-06-24 15:02:59 +00:00
Stypox
25914b0263
Third round of review 2021-06-24 10:46:53 +02:00
XiangRongLin
b996fa7eef Add comments explaining decisions in test-android ci job 2021-06-23 20:16:23 +02:00
XiangRongLin
5ebf3726ed Comment out test-android CI job 2021-06-23 20:14:27 +02:00
opusforlife2
a9e85abd7f
Ask for screenshots/video of UI changes
If the PR author has changed the UI of the app, they should include screenshots or a video so that developers and users alike can pinpoint exactly what changed.
2021-06-20 21:15:25 +00:00
Stypox
0db3406ad8
Fix SonarLint references and explanation 2021-06-18 12:26:50 +02:00
Stypox
8b3e32b6eb
First round of review 2021-06-17 20:47:22 +02:00
Stypox
6063ff063b
CONTRIBUTING.md: add "Build instructions" section and improve ordering 2021-06-13 21:06:59 +02:00
Tobi
81d00f2e97
Run CI on PRs which target the master branch
This is a fix for the release PRs
2021-06-05 17:34:27 +02:00
TiA4f8R
fe7536e374
Change NewPipe IRC links in the contribution guidelines (#6415)
* Change NewPipe IRC links in the contribution guidelines

* Remove redundant line break

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>

Co-authored-by: Mohammed Anas <32234660+mhmdanas@users.noreply.github.com>
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2021-06-02 16:27:08 +00:00
Tobi
e8d518cd6c
Add Libera webchat link 2021-05-28 11:59:27 +02:00
TiA4f8R
23ee9b7867
Update Matrix link of NewPipe IRC from Freenode to Libera.chat 2021-05-27 22:07:45 +02:00
Tobi
26c535db84
Change IRC link
Move from freenode webchat to libera chat
2021-05-27 09:56:27 +02:00
litetex
10b1da135e
Update ci.yml 2021-05-23 14:54:49 +02:00
TacoTheDank
c74162c586 Update actions/setup-java to v2 2021-04-14 11:13:05 -04:00
Tobi
8f0323fb8d
Merge pull request #5360 from XiangRongLin/instrumented_tests
Run Instrumented tests in CI pipeline
2021-03-31 10:08:05 +02:00
Tobi
00fbfb5a56
Merge pull request #5866 from TacoTheDank/update-gradle-wrapper
Update gradle wrapper
2021-03-30 10:36:48 +02:00
XiangRongLin
0dbb212d13 Add instrumented tests to CI workflow 2021-03-29 10:18:12 +02:00
Stypox
9f59d4baa3 Add note about "Fixes" prefix to auto-link issues 2021-03-28 13:41:33 +02:00
Tobi
a7c0f37904
Disable sonar job
For some reason, sonar started to analyse very old PRs. This comments out the sonar job until further investigation is done.
2021-03-24 19:10:00 +01:00
TacoTheDank
cae63a7ada Add gradle wrapper validation action 2021-03-20 21:47:19 -04:00
XiangRongLin
72818ffa42 Add sonar plugin and github actions file for sonar analysis
Copied from sonarcloud.io setup page with minor adjustments. Adjusted branch to 'dev' and updated versions
2021-03-20 13:58:17 +01:00
Poolitzer
3a61ab59f2
adding master to push trigger
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
2021-03-09 11:21:40 +01:00
Poolitzer
1db3c57ef0
change master to dev 2021-03-08 13:19:18 +01:00
Poolitzer
eeaf3496d5
Fix: CI only on master 2021-03-08 13:15:22 +01:00
Tobi
70f421b787
Add links to Matrix and IRC chat when opening new issues (#5764) 2021-03-08 09:43:05 +00:00
XiangRongLin
522d6d8b01
Re-add APK testing section to PR template (#5465)
Because normal users don't know that the CI process produces an APK and where it is.
2021-01-30 10:18:58 +00:00
Stypox
0d33f8b460
Merge pull request #5284 from mhmdanas/remove-pr-template-testing-apk-section
Remove APK testing section from PR template
2021-01-16 09:09:03 +01:00
XiangRongLin
41968918bb Checkout branch in CI process for pull requests
This way the debug build app id contains the branch name again.
2021-01-14 19:39:40 +01:00
opusforlife2
24c1cfbf72
Checklist is compulsory: feature request template 2021-01-01 18:42:07 +00:00
opusforlife2
31899d2ab9
Checklist is compulsory: bug report template 2021-01-01 18:40:20 +00:00
mhmdanas
c550779472 Remove APK testing section from PR template
This is because the our workflows build debug APKs now.
2020-12-26 21:35:07 +03:00
FireMasterK
a00ac6b9ca
Migrate to GitHub actions from Travis. 2020-12-09 12:25:57 +05:30
Allan Nordhøy
3ad14e4adf
Contributing guidelines reworked (#4318)
* Contributing guidelines reworked

Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: bopol <bopol@e.email>
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
2020-11-28 12:00:00 +01:00
TobiGr
863ce65b10 Fix Issue Template config 2020-10-24 20:44:22 +02:00
opusforlife2
b7c1e88b59
Create config.yaml to prevent blank issues 2020-10-23 14:37:59 +00:00
opusforlife2
cf9da556a8
Refined instructions for feature request template 2020-10-23 07:55:31 +00:00
opusforlife2
1550fc4398
Refined instructions for bug report template 2020-10-23 07:32:04 +00:00
Allan Nordhøy
e1104570a9
Pull request template reworked (#4317)
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2020-10-14 21:30:30 +02:00
opusforlife2
2e28fad102
Added checkbox example 2020-10-07 07:40:55 +00:00
opusforlife2
69760200dd
Added checkbox example 2020-10-07 07:39:49 +00:00
Tobias Groza
a918eaac3f
Add device info fields to bug report template (#4415) 2020-10-05 19:38:30 +02:00
Tobias Groza
10e95bf1b1
Merge pull request #4379 from opusforlife2/update_FR_template
Add check boxes to Feature Request template
2020-10-04 15:55:40 +02:00
Stypox
dd6392e380
Replace per with for every 2020-10-04 15:47:20 +02:00
opusforlife2
b8f7ba62c7
Use @Stypox 's suggestion
Co-authored-by: Stypox <stypox@pm.me>
2020-10-04 12:30:44 +00:00
opusforlife2
25b318ba00
Add check boxes
People seem to ignore instructions in comments
2020-10-04 12:24:56 +00:00
opusforlife2
9add51b59d
Add checkboxes instead of long comments
People just seemed to ignore them.
2020-10-04 12:03:14 +00:00
Keegan
fb9905a89e
Add need for contributors to discuss possible changes
This was discussed in IRC, and should help prevent the occurrence of problems where people spend hours on a feature only for it to be rejected for miscellaneous reasons.
2020-08-14 11:27:06 -05:00
Tobias Groza
fbb5c8cdd6
Update bug_report.md 2020-08-02 09:37:52 +02:00
Tobias Groza
d3b6781bb8
Update bug report template
DO NOT REPORT THAT CRASH ANY MORE. WE ARE GETTING SPAMMED11!!!1
2020-07-28 10:56:06 +02:00
Tobias Groza
2c453c7691
Merge pull request #3357 from opusforlife2/improve-bug-report-template
Made the bug report template less daunting
2020-04-06 21:51:07 +02:00
opusforlife2
12405f4059
Made the bug report template less daunting
The biggest problem was that the reporter needed to delete a lot of text to be able to give a clean report. Now most of that is comments.
2020-04-04 11:22:00 +00:00
B0pol
8d6965713c Update .github/CONTRIBUTING.md
Co-Authored-By: Tobias Groza <TobiGr@users.noreply.github.com>
2020-04-04 12:37:51 +02:00
bopol
fe2858bc75 update contributing.md 2020-04-04 12:14:32 +02:00
opusforlife2
713bf58c44
Add reminder to link Issues/PRs 2020-03-28 11:49:46 +00:00
opusforlife2
a7af21958f
Make feature request template easier to fill out 2020-03-28 10:54:20 +00:00
opusforlife2
8fed3df681
Update PULL_REQUEST_TEMPLATE.md
Minor modifications
2020-03-28 09:58:43 +00:00
TobiGr
50fd10ecd6 Remove titles from issue templates and fix typo 2020-03-19 22:50:48 +01:00
Tobias Groza
49c6aa2d74
Update .github/ISSUE_TEMPLATE/feature_request.md
Co-Authored-By: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2020-03-19 18:03:33 +01:00
poolitzer
02ef0b0818 a document is not nice 2020-03-18 19:44:37 -07:00
Poolitzer
e83e755fe1
dropping markdown links in comments
Co-Authored-By: Tobias Groza <TobiGr@users.noreply.github.com>
2020-03-18 19:42:03 -07:00
poolitzer
4e37a762d2 Further minor improvements 2020-03-04 20:31:36 -08:00
Poolitzer
2ca580dc16
minor improvements of sentences
Co-Authored-By: Stypox <stypox@pm.me>
2020-03-04 20:21:44 -08:00
Poolitzer
3f118a7239
appending dots
Co-Authored-By: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2020-03-02 21:08:34 -08:00
Poolitzer
d265382ddf
missed this
because GitHub thought its funny to hide it for a reason.

Co-Authored-By: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2020-03-02 20:56:03 -08:00
poolitzer
08dffad160 opus4improvements 2020-03-02 20:52:50 -08:00
poolitzer
afebd9b724 improvements 2020-03-02 16:38:23 -08:00
poolitzer
e2cb927e1f Merge branch 'templates' of https://github.com/Poolitzer/NewPipe into templates 2020-02-28 15:32:20 -08:00
poolitzer
46165f4a4f adding version section to bug report 2020-02-28 15:32:14 -08:00
Poolitzer
d9a8e4d797
NewPipe is an app though :(
And its our app!

Co-Authored-By: Tobias Groza <TobiGr@users.noreply.github.com>
2020-02-26 19:50:11 -08:00
poolitzer
1d9ffffc49 Minor improvements 2020-02-24 14:18:48 -08:00
poolitzer
01c1fa0393 B0pol suggested improvements 2020-02-23 16:16:18 -08:00
Poolitzer
30f66d012e
Update PULL_REQUEST_TEMPLATE.md 2020-02-22 20:16:14 -08:00
poolitzer
495b495f27 deleting old template 2020-02-22 20:03:38 -08:00
Poolitzer
01dcf550cf Update issue templates 2020-02-22 19:56:56 -08:00
Roger
1b0a958436
Create FUNDING.yml 2019-08-13 22:10:04 -04:00
Brian
fab5f26e09
Correct 'description' spelling 2019-01-12 04:41:16 +13:00
Christian Schabesberger
ea4e8805b7 disable stalebot again 2018-12-03 23:30:28 +01:00
Christian Schabesberger
c1168693fa add stalebot confic 2018-12-01 09:35:42 +01:00
Christian Schabesberger
22b20c15de update contribution guidelines 2018-12-01 09:21:57 +01:00
Christian Schabesberger
a208a22bc2 add link to the incredible bugreport converter 2018-06-29 14:03:15 +02:00
Christian Schabesberger
f96bc95053
Update CONTRIBUTING.md 2018-06-05 11:03:48 +02:00
Christian Schabesberger
23c1b66f6c
add note to contribution description 2018-05-14 13:24:35 +02:00
Schabi
c8a91fbb25 add note to check if bugs exist in latest version 2018-03-28 09:58:09 +02:00
Arjen Singels
1c20a4d9eb
Update CONTRIBUTING.md
fixed typo.
2017-11-08 13:58:01 +02:00
TobiGr
441b510775 Fix plurals not showing number of views, videos and subscribers
Fix typo in pull request template
2017-11-07 14:48:48 +01:00
Christian Schabesberger
3ac3cedc19 add fdroid build server node to contribution.md 2017-10-23 15:16:34 +02:00
Christian Schabesberger
894a63ed82 Merge branch 'dev' into master 2017-10-18 11:56:11 +02:00
TheAssassin
35b4110a7a Fix half finished paragraph 2017-10-15 18:42:49 +02:00
Fablab user
4b78a9366d s/TEAMPLATE/TEMPLATE/g
remove old teamplate
2017-09-23 21:17:08 +02:00
Christian Schabesberger
d564199e88 add sigle issue signle thread rule 2017-09-19 20:41:45 -03:00
Christian Schabesberger
6068043fd4 Fix pullrequest teamplate markdown issue 2017-09-09 19:04:30 +02:00
TheAssassin
9e2ed10144 Fix bugs in CONTRIBUTING.md
Spelling and grammar bugs, a few additions here and there, make it sound like a team project instead of a one-man show.
2017-08-02 23:34:46 +02:00
Christian Schabesberger
27e5ce7f9b update sentry linkg 2017-08-02 23:19:34 +02:00
Coffeemakr
b03723c3fb Code improvements
* Replace unchecked casts with checked casts
 * remove Utility.finViewById
 * Fix return activity checking
 * Create UserAction enum
 * Fix typos
 * Add instrumented test for error info
 * ErrorInfo make fields final
 * Log exception using logger
 * Add inherited annotations
 * Resolve deprecation warnings
 * Remove unused methods from utility
 * Reformat code
 * Remove unused methods from Utility and improve getFileExt
 * Create OnScrollBelowItemsListener
2017-06-28 18:56:05 +02:00
Christian Schabesberger
7f73612b9f add use english into contribution notes 2017-05-23 11:11:12 +02:00
Christian Schabesberger
130757ee99 Update CONTRIBUTING.md 2017-02-12 00:16:41 +01:00
Christian Schabesberger
5020a4f9dc add mailinglist to contributing 2017-02-11 22:26:00 +01:00
Christian Schabesberger
3bd477631c fixed spelling error 2016-11-18 22:08:53 +01:00