Stypox
7646c683b5
Merge pull request #7989 from litetex/refactor-playback-parameter-dialog
...
Rewrote ``PlaybackParameterDialog``
2022-04-30 17:53:26 +02:00
Yingwei Zheng
127a27315e
Fix keyboard showing after the search box acquiring focus ( #8227 )
...
* Fix keyboard showing after the search box acquiring focus
* Fix the underlying problem as described in the issue #7647
2022-04-18 16:05:42 +02:00
litetex
1dc146322c
Merged `DrawableResolver
into
ThemeHelper
`
2022-04-16 21:21:57 +02:00
litetex
b9190eddfe
Update DrawableResolver.kt
...
Nicer import 😉
2022-04-16 21:21:55 +02:00
litetex
44dada9e60
Use better Kotlin syntax
...
From the PR review
2022-04-16 21:21:54 +02:00
litetex
4b06536582
Reworked switching to semitones
...
Using an expandable Tab-like component instead of a combobox
2022-04-16 21:21:51 +02:00
Robin
a528cee5f4
Merge pull request #8127 from litetex/fix-SparseItemUtil
...
Fix `SparseItemUtil` so we don't enqueue twice
2022-04-07 17:21:18 +02:00
litetex
6b1a6d264b
Better naming
2022-04-02 15:44:06 +02:00
Mauricio Colli
99d62381b9
Fix download dialog selector layout and add some tests
2022-04-02 15:25:08 +02:00
litetex
b5fa93eda0
Fix SparseItemUtil
loading
...
* Added a missing `return` statement
* `fetchUploaderUrlIfSparse` now has a similar layout to `fetchItemInfoIfSparse`
2022-03-30 21:11:15 +02:00
Stypox
6e8c9f92cb
Merge branch 'dev' into pr2335
2022-03-19 22:29:10 +01:00
litetex
6d2b5d976d
Merge pull request #8068 from TacoTheDank/lintCleaning
...
Some lint cleaning
2022-03-19 14:37:34 +01:00
litetex
57231382a6
Merge pull request #8066 from TacoTheDank/simpleSeekbarChange
...
Create stub implementation for OnSeekBarChangeListener
2022-03-19 14:37:10 +01:00
TacoTheDank
cf213affa2
Annotate some NonNulls, some lint cleaning
2022-03-18 13:15:44 -04:00
TacoTheDank
979a320347
Delete some unused code
2022-03-17 23:26:34 -04:00
TacoTheDank
86f335b01f
Create stub implementation for OnSeekBarChangeListener
2022-03-17 21:49:04 -04:00
litetex
37aca3f1c7
Merge pull request #7981 from Stypox/sparse-items-deduplic
...
Deduplicate code for fetching stream info when sparse
2022-03-16 15:18:10 +01:00
Stypox
9b4a67276a
Fix comments and rearrange code
2022-03-15 15:20:25 +01:00
TacoTheDank
b8b97fa6d4
Convert NewVersionWorker to Kotlin
2022-03-03 13:34:35 -05:00
TacoTheDank
0f175de599
Kotlin-ize ReleaseVersionUtil, merge with NewVersionManager
2022-03-03 13:21:50 -05:00
TacoTheDank
1602befc51
Move utility methods out of CheckForNewAppVersion
2022-03-03 13:19:06 -05:00
Stypox
162a838afc
Deduplicate code for fetching stream info when sparse
...
Fixes #7941
2022-03-03 16:54:40 +01:00
litetex
37517c7dd1
Merge pull request #7570 from TeamNewPipe/improvement/infoItemDialogBuilder
...
Refactor generating InfoItemDialog's
2022-02-26 16:18:39 +01:00
litetex
a95318a4f9
Merge pull request #7349 from TiA4f8R/seamless-transition-players
...
Add seamless transition between background and video players when putting the app in background (for video-only streams and audio-only streams only)
2022-02-26 16:16:18 +01:00
Stypox
5fea12d8eb
Small code improvements
...
Removed some non-translatable strings and just hardcoded them in the code, like it's being done for other string separators. This also deduplicates some code by using Localization.
Used some Kotlin feature to reduce code.
2022-02-26 10:40:24 +01:00
TobiGr
ee477b25e5
Move StreamDialogEntry.openChannelFragment to NavigationHelper
2022-02-20 20:26:27 +01:00
TobiGr
277f21d5b2
Move Classes related to InfoItemDIalog into own package
2022-02-20 20:17:04 +01:00
TobiGr
a7d5d9a1d6
Fix rebase
2022-02-20 20:17:04 +01:00
TobiGr
fd0d76e866
Apply feedback
...
Return this in InfoIrtemDialog.Builder methoods.
Move null checks for InfoIrtemDialog.Builder into constructor.
Fix and add some more docs.
2022-02-20 20:17:04 +01:00
TobiGr
ef0d562702
Use ErrorActivity to notifiy about errors occourred while loading channel details
2022-02-20 20:17:04 +01:00
TobiGr
962fe9c36d
Use Context instead of Activity
...
Improve docs
2022-02-20 20:17:04 +01:00
TobiGr
80157fc1be
Refactor generating InfoItemDialog's
...
This commit refactors the way `InfoItemDialog`s are generated. This is necessary because the old way used the `StreamDialogEntry` enum for most of the dialogs' content generation process. This required static variables and methods to store the entries which are used for the dialog to be build (See e.g.`enabledEntries` and methods like `generateCommands()`). In other words, `StreamDialogEntry` wasn't an enumeration anymore.
To address this issue, a `Builder` is introduced for the `InfoItemDialog`'s genration. The builder also comes with some default entries and and a specific order. Both can be used, but are not enforced.
A second problem that introduced a structure which was atypical for an enumeration was the usage of non-final attributes within `StreamDialogEntry` instances. These were needed, because the default actions needed to overriden in some cases.
To address this problem, the `StreamDialogEntry` enumeration was renamed to `StreamDialogDefaultEntry` and a new `StreamDialogEntry` class is used instead.
2022-02-20 20:17:04 +01:00
litetex
7a356412d5
Fixed typo
2022-02-20 19:40:01 +01:00
litetex
a489f40b76
Fixed checkstyle problems
...
Unable to compile!
* Cleaned up ``getMostCompactAudioIndex`` and ``getHighestQualityAudioIndex`` into a new method ``getAudioIndexByHighestRank``
* Removed unreadable code and use Java Streams API
* Tests work as expected
2022-02-20 19:38:40 +01:00
litetex
8ed87e7fbb
Improved `ListHelper#getSortedStreamVideosList
`
2022-02-20 19:38:40 +01:00
TiA4f8R
79f8270c35
Prefer video-only streams to video streams
...
Prefering video-only streams to video streams for our player will allow us to make seamless transitions on 360 and 720p qualities on YouTube.
External players and the downloader are not affected by this change.
2022-02-20 19:38:40 +01:00
Stypox
62abfa96b8
Solve Java warning "Raw use of parameterized class"
2022-02-19 17:30:38 +01:00
TobiGr
ff8e44e4f3
Merge branch 'dev' into feature/notifications
2022-02-19 12:34:44 +01:00
litetex
dfa606ef49
Merge pull request #7586 from litetex/add-preference-search
...
Made preferences searchable
2022-01-30 17:08:04 +01:00
ktprograms
1e652b159e
Load uploaderUrl when showing Channel Details from Play Queue
...
This checks if the uploaderUrl is in the database, if not it gets the
uploaderUrl and puts it in the database. This is similar to the fetching
of uploaderUrl when it doesn't exist done in #6919 .
Also use createNotification when error occurs in getStreamInfo.
2022-01-25 11:00:34 +08:00
litetex
f3be89b503
Abstracted methods for the Android keyboard
2022-01-24 21:08:39 +01:00
Stypox
d5cfcb28fc
Merge branch 'dev' into pr2335
2022-01-24 10:25:07 +01:00
litetex
e127db6fa6
Simplified toast showing behavior
...
after feedback from the review
2022-01-23 15:34:11 +01:00
litetex
49b1649348
Revert "Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud"
...
This reverts commit ee19ea66b3
, reversing
changes made to 6b490ee547
.
2022-01-23 15:34:11 +01:00
Stypox
7907182e7e
Merge pull request #7036 from Douile/fix/queue-metadata
...
Load full stream info when enqueuing a stream
2022-01-07 21:57:30 +01:00
litetex
6dcde96f85
Fixed some Sonarlint warnings
2022-01-05 15:31:55 +01:00
Douile
064242d962
Remove unecessary interface InfoCallback
...
Co-authored-by: Stypox <stypox@pm.me>
Replace the unecessary callback interface InfoCallback in favour of the
standard type Consumer<SinglePlayQueue>
2022-01-03 17:52:27 +00:00
Stypox
cd95ec4e12
Merge branch 'dev' into pr2335
2021-12-31 19:20:18 +01:00
Stypox
fcd2d63df4
Don't show any channel notification thumbnail if it could not be loaded
2021-12-31 18:38:35 +01:00
litetex
fc0e709817
Fixed usage of wrong string
2021-12-27 00:14:04 +01:00