instead use service.stopService() which inturn calls stopSelf() and
triggers hopefully onDestroy() to be called. Eventually we have to make
sure that all ServiceConnections are closed to successfully stop the service
now!
Cleanup within stopService() and not only onDestroy()
So we make sure that all listeners can react to onServiceStopped()
and close their ServiceConnections. Afterwards the android framework
is ready to stop the Service.
It seems due to #6394 updating the FragmentX library there was a
change to the order of lifecycle calls, as such onResume() was no longer
before onCreateOptionsMenu() creating a null pointer exception when
using service in onCreateOptionsMenu() as it is only set in onResume().
By moving the initialization of service to onStart() which still happens
before onCreateOptionsMenu() this crash can be avoided. This commit also
adds a check for a null service to prevent future crashes for similar
issues.
If the PR author has changed the UI of the app, they should include screenshots or a video so that developers and users alike can pinpoint exactly what changed.
System is now not restarted with `System.exit(0)`.
Instead it is done properly by finishing the activity and restarting the activity. This allows preference changes which are queued up asynchronously through `apply` to be applied.
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Kurdish)
Currently translated at 1.9% (1 of 51 strings)
Translated using Weblate (Sardinian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Kurdish (Central))
Currently translated at 87.8% (586 of 667 strings)
Translated using Weblate (Estonian)
Currently translated at 92.2% (615 of 667 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Japanese)
Currently translated at 99.8% (666 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Punjabi)
Currently translated at 3.9% (2 of 51 strings)
Translated using Weblate (Greek)
Currently translated at 31.3% (16 of 51 strings)
Translated using Weblate (Bengali)
Currently translated at 89.6% (598 of 667 strings)
Translated using Weblate (Bengali (India))
Currently translated at 54.1% (361 of 667 strings)
Translated using Weblate (Interlingua)
Currently translated at 41.0% (274 of 667 strings)
Translated using Weblate (Punjabi)
Currently translated at 98.9% (660 of 667 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Slovak)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Serbian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 31.3% (16 of 51 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Serbian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Hebrew)
Currently translated at 47.0% (24 of 51 strings)
Translated using Weblate (Interlingua)
Currently translated at 39.8% (266 of 667 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 27.4% (14 of 51 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Polish)
Currently translated at 99.8% (666 of 667 strings)
Translated using Weblate (Ukrainian)
Currently translated at 99.4% (663 of 667 strings)
Translated using Weblate (Japanese)
Currently translated at 98.3% (656 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 99.2% (662 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Santali)
Currently translated at 14.2% (95 of 667 strings)
Translated using Weblate (Arabic)
Currently translated at 66.6% (34 of 51 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Polish)
Currently translated at 99.7% (665 of 667 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 99.8% (666 of 667 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (French)
Currently translated at 98.9% (660 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (667 of 667 strings)
Co-authored-by: AioiLight <info@aioilight.space>
Co-authored-by: Ajeje Brazorf <lmelonimamo@yahoo.it>
Co-authored-by: Andrij Mizyk <andmizyk@gmail.com>
Co-authored-by: C. Rüdinger <Mail-an-CR@web.de>
Co-authored-by: David Braz <davidbrazps2@gmail.com>
Co-authored-by: Digiwizkid <subhadiplayek@gmail.com>
Co-authored-by: Emin Tufan Çetin <etcetin@gmail.com>
Co-authored-by: Eric <spice2wolf@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: JY3 <GeeyunJY3@gmail.com>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: Karl Tammik <karltammik@protonmail.com>
Co-authored-by: Ldm Public <ldmpub@gmail.com>
Co-authored-by: Marian Hanzel <marulinko@gmail.com>
Co-authored-by: Michal L <michalrmsmi@wp.pl>
Co-authored-by: MohammedSR Vevo <mohammednajmidin@gmail.com>
Co-authored-by: Prasanta-Hembram <Prasantahembram720@gmail.com>
Co-authored-by: Rex_sa <rex.sa@pm.me>
Co-authored-by: Santiago <abridgement_phasiron@aleeas.com>
Co-authored-by: Software In Interlingua <softinterlingua@gmail.com>
Co-authored-by: SomeRetardedThatTranslatesStuff <the.eumitosis@simplelogin.fr>
Co-authored-by: THANOS SIOURDAKIS <siourdakisthanos@gmail.com>
Co-authored-by: Tari <tumbleweed@tuta.io>
Co-authored-by: TobiGr <tobigr@mail.de>
Co-authored-by: Vasilis K <skyhirules@gmail.com>
Co-authored-by: VfBFan <drop0815@posteo.de>
Co-authored-by: WaldiS <sto@tutanota.de>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: Yngvar Skjaldulfsson <irrorate_browns@slmail.me>
Co-authored-by: bomzhellino <adm.bomzh@gmail.com>
Co-authored-by: chr56 <chr0056@gmail.com>
Co-authored-by: gnu-ewm <gnu.ewm@protonmail.com>
Co-authored-by: nautilusx <translate@disroot.org>
Co-authored-by: pjammo <adrianoghr@hotmail.it>
Co-authored-by: thami simo <simo.azad@gmail.com>
Co-authored-by: zeritti <woodenmo@posteo.de>
Co-authored-by: zmni <zmni@outlook.com>
Co-authored-by: Обилић <mudo2233@tutanota.com>
Co-authored-by: Слободан Симић(Slobodan Simić) <slsimic@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ar/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/el/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/he/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/ku/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pa/
Translation: NewPipe/Metadata
Translated using Weblate (English)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (German)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (French)
Currently translated at 98.9% (660 of 667 strings)
Translated using Weblate (Serbian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Japanese)
Currently translated at 99.8% (666 of 667 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Slovak)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Czech)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Arabic)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Indonesian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Ukrainian)
Currently translated at 99.4% (663 of 667 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Portuguese (Brazil))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Sardinian)
Currently translated at 100.0% (667 of 667 strings)
Translated using Weblate (Bengali)
Currently translated at 93.1% (621 of 667 strings)
E/WindowManager: android.view.WindowLeaked: Activity org.schabi.newpipe.RouterActivity has leaked window DecorView@d99fe3b[] that was originally added here
at android.view.ViewRootImpl.<init>(ViewRootImpl.java:418)
