Stypox
6a0c5a874c
Fix ContentSettingsManager tests
2021-06-08 10:40:45 +02:00
Stypox
1e09a1768e
Revert all commits related to ContentSettingsFragment
...
Revert "Annotate methode parameters as NonNull"
This reverts commit 004907d306
.
Revert "Commit path immediately when import backup"
This reverts commit 05eb0d0fbe
.
Revert "Set ImportExportDataPath only on successful import"
This reverts commit f13a1b04e6
.
Revert "Set ImportExportDataPath only on successful export"
This reverts commit fd4408e572
.
Revert "Invert if condition in ContentSettingsFragment.setImportExportDataPath for better readability"
This reverts commit 92ab9cae27
.
Revert "Move ContentSettingsFragment.isValidPath to helpers and add unit test for it."
This reverts commit fa2b11b768
.
Revert "Save backup import/export location for feature import/exports"
This reverts commit 82f43ac6a6
.
Remove FilePathHelperTest file
2021-06-08 10:40:44 +02:00
TobiGr
abc354f516
Use reqireContext(), requireActivity() instead of getters
2021-06-05 16:13:12 +02:00
Zhiheng Xu
c0f47195a2
Remove Enclosed.class runner
...
Does not affect Gradle tests and only benefits IDE workflow
2021-05-24 13:03:52 -04:00
Zhiheng Xu
40f66977c7
Rewrite addToHistory test without using reflection
2021-05-24 12:20:19 -04:00
Zhiheng Xu
e518c0dc14
Rename mockPlayQueue(…) to makePlayQueue(…)
2021-05-24 12:20:19 -04:00
Zhiheng Xu
bf8e8798d9
Add test for setIndex
2021-05-24 12:20:19 -04:00
Zhiheng Xu
08949ee347
Refactor static methods to package private
...
Stops Android Studio from "recognizing" them as tests
2021-05-24 12:20:19 -04:00
Eric Xu
363bbf5fd3
Test getItem(int)
2021-05-24 12:20:19 -04:00
Eric Xu
77f6940336
Refactor making a PlayQueueItem to static method
2021-05-24 12:20:19 -04:00
Eric Xu
8d0f2d371d
Test PlayQueue.setIndex(...)
2021-05-24 12:20:19 -04:00
Eric Xu
882b235a78
Test PlayQueue equals
2021-05-24 12:20:19 -04:00
XiangRongLin
376e5c1546
Remove unnecessary conversion between file and path
2021-05-21 20:24:11 +02:00
Alireza Tofighi
e8ad947d37
Split up FilePathHelperTest tests in simpler methods
2021-05-21 22:44:38 +04:30
Alireza Tofighi
067528211f
Add more tests for FilePathUtils.isValidDirectoryPath for better coverage
2021-05-21 20:28:42 +04:30
Alireza Tofighi
fa2b11b768
Move ContentSettingsFragment.isValidPath to helpers and add unit test for it.
2021-05-21 20:21:58 +04:30
krlvm
32a159d48f
Fix error in tests
2021-03-27 18:11:39 +03:00
Isira Seneviratne
74e20a8c52
Use PrettyTime's new formatUnrounded(OffsetDateTime) method.
...
Also change the types of the relevant variables from Calendar to OffsetDateTime.
2021-03-18 06:38:12 +05:30
Stypox
553b80164b
Move all error-related classes into error package
2021-03-07 17:49:28 +01:00
XiangRongLin
2926cb7682
Respect expires header when checking for new version
...
It was called to many times and acted similar to a DOS attack.
2021-01-23 09:02:11 +01:00
Stypox
10c35f354e
Merge pull request #5225 from XiangRongLin/extract_settings_import
...
Extract settings import
2021-01-14 15:18:36 +01:00
Stypox
9ee7740fcc
Merge pull request #4947 from Isira-Seneviratne/Convert_ExceptionUtils_to_extensions
...
Rewrite ExceptionUtils methods as extension functions.
2021-01-14 14:54:37 +01:00
XiangRongLin
031585be3f
Add comment about unexpected assertion
2021-01-13 17:25:00 +01:00
Isira Seneviratne
50dcf308a2
Add extension functions that accept reified types.
2021-01-11 16:49:46 +05:30
Isira Seneviratne
486e720e00
Rewrite ExceptionUtils methods as extension functions.
2021-01-11 16:49:45 +05:30
XiangRongLin
50a026183d
Make Localization.relativeTime testable
...
Problem is global state in static variable prettyTime. But for performance reasons on Android that is preferred.
Now allow injecting prettyTime dependency by making init function public.
2021-01-06 14:48:34 +01:00
XiangRongLin
716d795970
cleanup
2021-01-03 20:32:16 +01:00
XiangRongLin
fcfdcd1025
Fix ensureDbDirectoryExists
2021-01-03 20:32:16 +01:00
XiangRongLin
af119db1d7
Extract settings file deletion
2021-01-03 20:32:16 +01:00
XiangRongLin
122e80fae9
Remove subclasses from ContentSettingsManagerTest
...
ExportTest provides no value.
ImportTest creates temporary files even if not needed.
2021-01-03 20:32:16 +01:00
XiangRongLin
8fceffd6fd
Introduce NewPipeFileLocator class
2021-01-03 20:32:16 +01:00
XiangRongLin
f778c48923
Add basic tests for settings import
2021-01-03 20:32:16 +01:00
XiangRongLin
ea91a62c89
Adjust ExportTest to new DI with FileLocator
2021-01-03 20:32:16 +01:00
Stypox
28802805f8
Merge pull request #5204 from XiangRongLin/fix_before_all
...
Use @BeforeClass for ContentSettingsManagerTest.beforeClass
2020-12-19 14:33:37 +01:00
Stypox
96862cbcb3
Merge pull request #5208 from Stypox/recaptcha-pbj
...
Remove pbj=1 parameter from YouYube urls in recaptcha activity
2020-12-18 18:28:44 +01:00
Stypox
10f79e1307
Remove pbj=1 parameter from YouYube urls in recaptcha activity
2020-12-17 21:02:13 +01:00
XiangRongLin
e0ee3dce40
Use @BeforeClass for ContentSettingsManagerTest.beforeClass
2020-12-17 09:40:04 +01:00
Stypox
d46c7eb8fe
Merge pull request #5059 from XiangRongLin/content_settings_manager
...
Extract export database logic into own class
2020-12-15 10:34:32 +01:00
Stypox
c2210330b6
Show radio instead of Youtube logo in mixes
...
YouTube mixes have YouTube as a creator, though YouTube's logo is not safe to use as it is a trademark (better safe than sorry)
2020-12-14 19:22:00 +01:00
Isira Seneviratne
c0d6c8aeb3
Add a workaround for a possible null offset ID.
2020-12-10 15:23:30 +05:30
Tobias Groza
db9f20a22f
Merge pull request #4961 from TeamNewPipe/lint
...
Fix some Lint errors
2020-12-07 11:19:01 +01:00
XiangRongLin
f7f00293cc
Extract export database logic into own class
...
- Separate it from the UI.
- Add happy path unit test.
2020-12-04 18:30:29 +01:00
Stypox
f0ca916432
Update most dependencies
2020-11-22 14:03:10 +01:00
TobiGr
7a8dab2d58
Fix typos
2020-11-22 10:39:00 +01:00
TacoTheDank
773bde14ab
Lint: 'size() == 0' replaceable with 'isEmpty()'
2020-11-18 17:54:16 -05:00
wb9688
87228673b4
Use final where possible
2020-08-16 10:25:09 +02:00
wb9688
b0415a5289
Auto-format using Ktlint
2020-05-01 20:13:21 +02:00
Mauricio Colli
a1b9892c77
Move exception utils to a separate class and add tests for it
2020-04-09 13:22:18 -03:00
wb9688
fda5405e48
Improve code style to be more consistent
2020-04-02 15:57:50 +02:00
Mauricio Colli
f133bbf499
Introduce a proper way to find urls in a string input
2020-03-28 14:06:09 -03:00