This commit calls getStreamInfo causing a full network fetch of stream
info (I believe only if required) when adding a stream item to the
queue. This should prevent UI issues of missing metadata when queueing
videos that have been fast-loaded and are missing metadata.
Fixes#7035
* added mvp play next button in long press menu; new intent handling, new long press dialog entry, new dialog functions, new strings
* changed line length for checkstyle pass
* cleaned comments, moved strings
* Update app/src/main/res/values/strings.xml
to make long press entry more descriptive
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
* Update app/src/main/res/values/strings.xml
Co-authored-by: Stypox <stypox@pm.me>
* replace redundant nextOnVideoPlayer methods
Co-authored-by: Stypox <stypox@pm.me>
* add enqueueNextOnPlayer and enqueueOnPlayer without selectOnAppend and RESUME_PLAYBACK/ deprecate enqueueNextOn*Player and enqueueOn*Player methods
add getPlayerIntent, getPlayerEnqueueIntent and getPlayerEnqueueNextIntent without selectOnAppend and RESUME_PLAYBACK/ deprecate those with
add section comments
* removed deprecated methods
removed redundant methods
* removed deprecated methods
removed redundant methods
* replaced APPEND_ONLY, removed SELECT_ON_APPEND / replaced remaining enqueueOn*Player methods
* now works with playlists
* renamed dialog entry
* checking for >1 items in the queue using the PlayerHolder
* making enqueue*OnPlayer safe to call when no video is playing (defaulting to audio)
* corrected strings
* improve getQueueSize in PlayerHolder
* long press to enqueue only if queue isnt empty
* add Whitespace
Co-authored-by: Stypox <stypox@pm.me>
* clarify comments / add spaces
* PlayerType as parameter of the enqueueOnPlayer method
add Helper method
* using the helper function everywhere (except for the background and popup long-press actions (also on playlists, history, ...)), so basically nowhere
/ passing checkstyle
* assimilated the enqueue*OnPlayer methods
* removed redundant comment, variable
* simplify code line
Co-authored-by: Stypox <stypox@pm.me>
* move if
* replace workaround for isPlayerOpen()
Co-authored-by: Stypox <stypox@pm.me>
* replaced workarounds (getType), corrected static access with getInstance
* remove unused imports
* changed method call to original, new method doesnt exist yet.
* Use getter method instead of property access syntax.
* improve conditional for play next entry
Co-authored-by: Stypox <stypox@pm.me>
* show play next btn in feed fragment
Co-authored-by: Stypox <stypox@pm.me>
* add play next to local playlist and statistics fragment
Co-authored-by: Stypox <stypox@pm.me>
* formating
Co-authored-by: Stypox <stypox@pm.me>
* correcting logic
Co-authored-by: Stypox <stypox@pm.me>
* remove 2 year old unused string, formating
Co-authored-by: Stypox <stypox@pm.me>
* correct enqueue (next) conditionals, default to background if no player is open. Dont generally default to background play.
* remove player open checks from button long press enqueue actions
* improve log msg
* Rename next to enqueue_next
* Refactor kotlin
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Stypox <stypox@pm.me>
Currently translated at 56.1% (32 of 57 strings)
Translated using Weblate (Estonian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Vietnamese)
Currently translated at 99.8% (618 of 619 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Japanese)
Currently translated at 99.5% (616 of 619 strings)
Translated using Weblate (Ukrainian)
Currently translated at 77.1% (44 of 57 strings)
Translated using Weblate (Portuguese (Portugal))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Sardinian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Galician)
Currently translated at 94.9% (588 of 619 strings)
Translated using Weblate (Lithuanian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Persian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Slovak)
Currently translated at 96.2% (596 of 619 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (French)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (German)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (English)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Polish)
Currently translated at 52.6% (30 of 57 strings)
Translated using Weblate (Hebrew)
Currently translated at 47.3% (27 of 57 strings)
Translated using Weblate (Ukrainian)
Currently translated at 61.4% (35 of 57 strings)
Translated using Weblate (Portuguese (Portugal))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Portuguese)
Currently translated at 99.6% (617 of 619 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (57 of 57 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Persian)
Currently translated at 15.7% (9 of 57 strings)
Translated using Weblate (Ukrainian)
Currently translated at 54.3% (31 of 57 strings)
Translated using Weblate (Lithuanian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (619 of 619 strings)
Co-authored-by: Agnieszka C <aga_04@o2.pl>
Co-authored-by: AioiLight <info@aioilight.space>
Co-authored-by: Ajeje Brazorf <lmelonimamo@yahoo.it>
Co-authored-by: Danial Behzadi <dani.behzi@ubuntu.com>
Co-authored-by: Gediminas Murauskas <muziejusinfo@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Igor Nedoboy <i.nedoboy@mail.ru>
Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Co-authored-by: Jakub <online.reg1@pm.me>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: Priit Jõerüüt <hwlate@joeruut.com>
Co-authored-by: Vasilis K <skyhirules@gmail.com>
Co-authored-by: WB <web0nst@tuta.io>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: bruh <quangtrung02hn16@gmail.com>
Co-authored-by: chr56 <chr0056@gmail.com>
Co-authored-by: nzgha <nzghafoss.ldxwe@slmail.me>
Co-authored-by: pjammo <adrianoghr@hotmail.it>
Co-authored-by: ssantos <ssantos@web.de>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fa/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/he/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/
Translation: NewPipe/Metadata
Currently translated at 56.1% (32 of 57 strings)
Translated using Weblate (Estonian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Vietnamese)
Currently translated at 99.8% (618 of 619 strings)
Translated using Weblate (Polish)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Portuguese)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Japanese)
Currently translated at 99.5% (616 of 619 strings)
Translated using Weblate (Ukrainian)
Currently translated at 77.1% (44 of 57 strings)
Translated using Weblate (Portuguese (Portugal))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Sardinian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Galician)
Currently translated at 94.9% (588 of 619 strings)
Translated using Weblate (Lithuanian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Hebrew)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Persian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Turkish)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Slovak)
Currently translated at 96.2% (596 of 619 strings)
Translated using Weblate (Greek)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (French)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (German)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (English)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Polish)
Currently translated at 52.6% (30 of 57 strings)
Translated using Weblate (Hebrew)
Currently translated at 47.3% (27 of 57 strings)
Translated using Weblate (Ukrainian)
Currently translated at 61.4% (35 of 57 strings)
Translated using Weblate (Portuguese (Portugal))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Portuguese)
Currently translated at 99.6% (617 of 619 strings)
Translated using Weblate (Chinese (Simplified))
Currently translated at 100.0% (57 of 57 strings)
Translated using Weblate (Chinese (Traditional))
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Persian)
Currently translated at 15.7% (9 of 57 strings)
Translated using Weblate (Ukrainian)
Currently translated at 54.3% (31 of 57 strings)
Translated using Weblate (Lithuanian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (619 of 619 strings)
Translated using Weblate (Spanish)
Currently translated at 100.0% (619 of 619 strings)
Co-authored-by: Agnieszka C <aga_04@o2.pl>
Co-authored-by: AioiLight <info@aioilight.space>
Co-authored-by: Ajeje Brazorf <lmelonimamo@yahoo.it>
Co-authored-by: Danial Behzadi <dani.behzi@ubuntu.com>
Co-authored-by: Gediminas Murauskas <muziejusinfo@gmail.com>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Igor Nedoboy <i.nedoboy@mail.ru>
Co-authored-by: Ihor Hordiichuk <igor_ck@outlook.com>
Co-authored-by: Jakub <online.reg1@pm.me>
Co-authored-by: Jeff Huang <s8321414@gmail.com>
Co-authored-by: Priit Jõerüüt <hwlate@joeruut.com>
Co-authored-by: Vasilis K <skyhirules@gmail.com>
Co-authored-by: WB <web0nst@tuta.io>
Co-authored-by: Yaron Shahrabani <sh.yaron@gmail.com>
Co-authored-by: bruh <quangtrung02hn16@gmail.com>
Co-authored-by: chr56 <chr0056@gmail.com>
Co-authored-by: nzgha <nzghafoss.ldxwe@slmail.me>
Co-authored-by: pjammo <adrianoghr@hotmail.it>
Co-authored-by: ssantos <ssantos@web.de>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/es/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fa/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/he/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/pl/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/zh_Hans/
Translation: NewPipe/Metadata
Just like in the issue 7062, https://github.com/TeamNewPipe/NewPipe/issues/7062, this doesn't affect UI as it updates every one second anyway, but reduces very heavy android widget progress bar high cpu usage. With every 500s there is 6% cpu usage and with 1s only 4%. However further changes will have to be made to disable updating of player progress bar when screen is off to further reduce power consumption. With this, total power savings would be 20% in mAh consumption.
