XiangRongLin
e98838ad7e
Invert usage of manager.isExpired()
...
When it's expired it means, that the app should get the data. Meaning it should not abort prematurely by returning null.
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
2021-01-30 09:32:17 +01:00
Stypox
02db971b7c
Set all default settings at the beginning
2021-01-28 18:28:29 +01:00
Stypox
fdb0f01b38
Add Objects.requireNotNull to warning which is surely not null
2021-01-28 14:35:47 +01:00
Stypox
376cba696e
Remove useless getString for default setting value
2021-01-28 14:35:00 +01:00
Stypox
cade272501
Use PlayerHelper.retrieveResizeModeFromPrefs in Player
2021-01-28 14:33:50 +01:00
Stypox
4f828fbe00
Fix always minimizing to popup player
2021-01-28 14:33:12 +01:00
XiangRongLin
2926cb7682
Respect expires header when checking for new version
...
It was called to many times and acted similar to a DOS attack.
2021-01-23 09:02:11 +01:00
Tobias Groza
cafc64534b
Merge pull request #5458 from Stypox/fix-popup-x
...
Fix popup closing x button animation
2021-01-22 10:01:12 +01:00
Stypox
327fc742d3
Fix channel subscribe button causing crash in main page tab
...
The binding was being set to null on onDestroyView() instead of in onDestroy()
2021-01-21 15:31:50 +01:00
Stypox
10ec67854e
Fix number being shown instead of corresponding string resorce in feed
2021-01-20 10:44:44 +01:00
Stypox
e327f7ba2c
Fix popup closing x button animation
2021-01-19 09:34:21 +01:00
TiA4f8R
9a65f02d5b
Fix crash when no browser is present and use an ACTION_CHOOSER intent in the app update notification ( #5429 )
...
Fix crash when no browser is present and use an ACTION_CHOOSER intent for app update notification
Show a Toast when no app is present on user's device to open a content in an app and in a browser and use an ACTION_CHOOSER intent with the ACTION_VIEW intent put as an extra intent in the update notification.
2021-01-18 21:45:36 +01:00
XiangRongLin
5814743d59
Merge pull request #5430 from Stypox/fix-feed
...
Fix reload feed button does nothing
2021-01-18 12:59:58 +01:00
Stypox
fa7613b8d1
Refactor feed fragment
2021-01-18 11:43:05 +01:00
Stypox
d3d05d613d
Fix reload feed button does nothing
...
initListeners was being called before the bindings were assigned, and therefore the click listener was never setup
2021-01-18 11:42:25 +01:00
XiangRongLin
23b5cd5b72
Merge pull request #5442 from Stypox/fix-close-popup
...
Prevent IllegalArgumentException when closing popup
2021-01-18 09:39:02 +01:00
Stypox
d4a33603ab
Prevent IllegalArgumentException when closing popup
2021-01-18 08:27:49 +01:00
Stypox
3868243c2a
Animate secondary controls toggle
2021-01-17 15:59:29 +01:00
Stypox
243f539439
Use KoreUtil function
2021-01-17 15:46:00 +01:00
Stypox
71d92c8d1b
Hide tab layout in detail fragment when there is no space
2021-01-17 15:42:54 +01:00
Stypox
e840d42fb9
Add content description to detail fragment tabs
2021-01-17 15:38:12 +01:00
Stypox
750c4ffbd3
Add preference to hide description tab in video details
2021-01-17 15:36:42 +01:00
Stypox
4c3ba0fe3d
Add icons to VideoDetailFragment tab layout for better accessibility
2021-01-17 15:34:24 +01:00
Stypox
a314f55a17
Move description to a tab alongside related streams and comments
2021-01-17 15:26:25 +01:00
Stypox
78a9811fe3
Add a secondary control panel to video detail fragment
...
It is shown when the user expands the description
It contains share, open in browser and play in kodi
2021-01-17 15:12:29 +01:00
Isira Seneviratne
fe92abde0e
Use view binding in VideoDetailFragment.
2021-01-17 09:57:40 +05:30
Isira Seneviratne
01396923f1
Use the base Groupie library in ChannelItem.
2021-01-16 18:59:49 +05:30
Isira Seneviratne
e0de66b1be
Fix some issues.
2021-01-16 18:59:48 +05:30
Isira Seneviratne
77675b361f
Use BindableItem in PickerSubscriptionItem.
2021-01-16 18:59:45 +05:30
Isira Seneviratne
e2dd058430
Use BindableItem in PickerIconItem.
2021-01-16 18:55:42 +05:30
Isira Seneviratne
a188125982
Use BindableItem in HeaderWithMenuItem.
2021-01-16 18:55:42 +05:30
Isira Seneviratne
9e5f079cf2
Use BindableItem in HeaderItem.
2021-01-16 18:55:41 +05:30
Isira Seneviratne
51a948bfcf
Use BindableItem in FeedImportExportItem.
2021-01-16 18:55:41 +05:30
Isira Seneviratne
9d27d49c1f
Use BindableItem in FeedGroupReorderItem.
2021-01-16 18:55:41 +05:30
Isira Seneviratne
761f6568fa
Use BindableItem in FeedGroupCarouselItem.
2021-01-16 18:55:40 +05:30
Isira Seneviratne
ee94b296ae
Use BindableItem in FeedGroupCardItem.
2021-01-16 18:55:40 +05:30
Isira Seneviratne
b387946d34
Use BindableItem in FeedGroupAddItem.
2021-01-16 18:55:39 +05:30
Isira Seneviratne
46afe5153f
Use BindableItem in EmptyPlaceholderItem.
2021-01-16 18:55:38 +05:30
Stypox
594f0b10ba
Move TextLinkifier computation out of main thread
2021-01-16 13:23:42 +01:00
TiA4f8R
79e98db3bd
Apply the requested changes and little improvements
...
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
Apply the requested changes and do little improvements
Apply the requested changes, use ShareUtils.shareText to share an stream in the play queue and optimize imports for Java files, using Android Studio functionality.
2021-01-16 13:23:42 +01:00
TiA4f8R
a57fd69fb4
External sharing improvements
...
Improve NewPipe's share on some devices + fix crash when no browser is set on some devices
Catching ActivityNotFoundException when trying to open the default browser
Use an ACTION_CHOOSER intent and put as an extra intent the intent to
open an URI / share an URI when no default app is set.
Add a LinkHelper class which set a custom action when clicking web links
in the description of a content. This class also helps to implement a confirmation dialog when trying to open web links in an external app.
2021-01-16 13:23:06 +01:00
Isira Seneviratne
920e560b4b
Convert AnimationUtils functions to extension functions.
2021-01-16 14:49:37 +05:30
Robin
98ed80d305
Merge pull request #5274 from vkay94/stream-segments
...
Add stream segments to player controls
2021-01-15 10:59:34 +01:00
Stypox
c216f29fb0
Merge pull request #5418 from Isira-Seneviratne/Unify_constants
...
Combine the two Constants files into one file.
2021-01-15 09:20:08 +01:00
Isira Seneviratne
14ddf37988
Combine the two Constants files into one file.
2021-01-15 12:13:47 +05:30
Isira Seneviratne
87568b6590
Fix the crash that occurs on navigating back to the main fragment.
2021-01-15 06:54:20 +05:30
vkay94
37aa41afae
Add stream segments to player
2021-01-14 21:58:19 +01:00
Tobias Groza
8fd48a88be
Merge pull request #4939 from Atemu/dont-exit-fullscreen-on-rotation
...
VideoDetailFragment: Don't exit fullscreen on rotation in tablet UI
2021-01-14 16:25:51 +01:00
Stypox
10c35f354e
Merge pull request #5225 from XiangRongLin/extract_settings_import
...
Extract settings import
2021-01-14 15:18:36 +01:00
Stypox
9ee7740fcc
Merge pull request #4947 from Isira-Seneviratne/Convert_ExceptionUtils_to_extensions
...
Rewrite ExceptionUtils methods as extension functions.
2021-01-14 14:54:37 +01:00
Stypox
94b086de20
Merge pull request #4814 from Isira-Seneviratne/Use_view_binding_in_fragments
...
Use view binding in fragments.
2021-01-14 14:40:19 +01:00
Robin
c90696e67e
Merge pull request #5371 from Stypox/merge-player
...
Merge player classes into a single one
2021-01-14 10:43:11 +01:00
Stypox
059bb7622d
Merge and rename into PlayQueueActivity
2021-01-14 10:25:48 +01:00
Stypox
cece83328a
Fix wrong speed indicator in queue activity
2021-01-14 10:25:48 +01:00
Stypox
4a12b0ab2d
Revert hiding detail fragment tabs when in fullscreen
2021-01-14 10:25:48 +01:00
Stypox
f6e2dd1480
Merge player classes into a single one
2021-01-14 10:25:44 +01:00
Isira Seneviratne
f04b5fd42f
Use view binding in FeedGroupReorderDialog.
2021-01-14 11:16:08 +05:30
Isira Seneviratne
5994cd8ea2
Use view binding in FeedGroupDialog.
2021-01-14 11:16:07 +05:30
Isira Seneviratne
83f33a7d1b
Use view binding in SubscriptionFragment.
2021-01-14 11:16:06 +05:30
Isira Seneviratne
f80e1bd214
Use view binding in FeedFragment.
2021-01-14 11:16:05 +05:30
Isira Seneviratne
97672f06de
Use view binding in SearchFragment.
2021-01-14 11:16:04 +05:30
Isira Seneviratne
6039484a02
Use view binding in ChannelFragment.
2021-01-14 11:16:03 +05:30
Isira Seneviratne
7682ebd245
Use view binding in DownloadDialog.
2021-01-14 11:16:01 +05:30
Isira Seneviratne
7c581ec108
Use view binding in LicenseFragment.
2021-01-14 11:16:00 +05:30
Isira Seneviratne
910d22daa6
Use view binding in MainFragment.
2021-01-14 11:15:58 +05:30
Isira Seneviratne
979102a2d9
Return ViewBinding instead of View in BaseListFragment's getListHeader() and getListFooter() methods.
2021-01-14 11:15:57 +05:30
Isira Seneviratne
98be89a20a
Return ViewBinding instead of View in BaseLocalListFragment's getListHeader() and getListFooter() methods.
2021-01-14 11:15:54 +05:30
Robin
0264383ad2
Merge pull request #5358 from XiangRongLin/testable_prettytime
...
Make Localization.relativeTime testable
2021-01-13 22:44:11 +01:00
Isira Seneviratne
fa75c79d34
Use view binding (PlayerPopupCloseOverlayBinding) in VideoPlayerImpl.
2021-01-13 20:44:00 +01:00
Isira Seneviratne
0c86a4e608
Use view binding (PlayerBinding) in VideoPlayer.
2021-01-13 20:43:56 +01:00
Tobias Groza
92a87a5ed2
Merge pull request #5310 from khimaros/list-play-kodi
...
add list item to play video on kodi
2021-01-13 17:02:56 +01:00
Isira Seneviratne
50dcf308a2
Add extension functions that accept reified types.
2021-01-11 16:49:46 +05:30
Isira Seneviratne
486e720e00
Rewrite ExceptionUtils methods as extension functions.
2021-01-11 16:49:45 +05:30
bopol
5c4d72ec42
Merge remote-tracking branch 'upstream/dev' into sepiasearch
2021-01-10 15:53:20 +01:00
Robin
6b2f084cda
Merge pull request #5331 from mbarashkov/hardware-keyboard-space-shortcut
...
In Fullscreen playback, toggle play/pause with hardware space button
2021-01-07 17:09:27 +01:00
Mikhail Barashkov
907106156f
When in Fullscreen playback mode, toggle play/pause with the hardware Space button.
2021-01-07 17:32:16 +02:00
XiangRongLin
50a026183d
Make Localization.relativeTime testable
...
Problem is global state in static variable prettyTime. But for performance reasons on Android that is preferred.
Now allow injecting prettyTime dependency by making init function public.
2021-01-06 14:48:34 +01:00
XiangRongLin
716d795970
cleanup
2021-01-03 20:32:16 +01:00
XiangRongLin
fcfdcd1025
Fix ensureDbDirectoryExists
2021-01-03 20:32:16 +01:00
XiangRongLin
af119db1d7
Extract settings file deletion
2021-01-03 20:32:16 +01:00
XiangRongLin
122e80fae9
Remove subclasses from ContentSettingsManagerTest
...
ExportTest provides no value.
ImportTest creates temporary files even if not needed.
2021-01-03 20:32:16 +01:00
XiangRongLin
8fceffd6fd
Introduce NewPipeFileLocator class
2021-01-03 20:32:16 +01:00
XiangRongLin
19cd3a17df
Move isValidZipFile to ZipHelper
2021-01-03 20:32:16 +01:00
XiangRongLin
ea91a62c89
Adjust ExportTest to new DI with FileLocator
2021-01-03 20:32:16 +01:00
XiangRongLin
cef791ba1b
Introduce NewPipeFileLocator class
...
It handles locating specific NewPipe files based on the home directory of the app.
2021-01-03 20:32:16 +01:00
XiangRongLin
f78a7fa630
Extract import database logic in ContentSettingsManager
2021-01-03 20:32:16 +01:00
khimaros
ac59382b84
pass serviceId instead of item, reduce duplication
2021-01-02 11:24:33 -08:00
Isira Seneviratne
14a2171035
Use Objects.requireNonNull().
2021-01-02 09:36:33 +05:30
Stypox
1b4bde4e78
Merge pull request #5221 from B0pol/notifications
...
Dynamically get package name
2021-01-01 18:05:43 +01:00
TacoTheDank
71add5a7c2
Update displayed licenses
2020-12-31 19:26:41 -05:00
Robin
ce2719d77e
Merge pull request #5317 from XiangRongLin/timestamp
...
Fix urls with timestamps not being played
2020-12-31 12:46:40 +01:00
Robin
8193a0df63
Merge pull request #5065 from TacoTheDank/androidx-media-audioreactor
...
Use AndroidX Media compat in AudioReactor
2020-12-31 10:55:11 +01:00
khimaros
48a5107296
address pull request feedback
2020-12-30 14:45:14 -08:00
TacoTheDank
ebd589c9cb
Use AndroidX Media compat in AudioReactor
2020-12-30 17:10:57 -05:00
XiangRongLin
1f15368b7b
Fix urls with timestamps not being played
...
Else path is now executed, when a timestamp (item.getRecoveryPosition) is present
2020-12-30 21:07:30 +01:00
Stypox
8fe1a76ec6
Merge pull request #5301 from EricLemieux/fix-npe-play-button
...
Fix null pointer exception in play button method
2020-12-30 17:48:40 +01:00
khimaros
83faf119a9
add list item to play video on kodi
...
closes : #5157
2020-12-29 18:53:32 -08:00
Eric Lemieux
0a05534c84
Fix null pointer exception in play button method
...
When the play queue was null, and this method was called a null pointer
exception would be thrown. This change adds an additional check to see
if the play queue is not null before making additional changes.
2020-12-29 14:51:24 -05:00
Robin
137fbb34d9
Merge pull request #5283 from urlordjames/brightfix
...
disable restoring brightness if brightness gesture is disabled
2020-12-29 17:37:53 +01:00
urlordjames
d45ce19b04
Fix #4481
2020-12-28 09:46:10 -05:00