TobiGr
433c6dc33b
Fix OnErrorNotImplementedException in SearchFragment.initSuggestionObserver()
...
Hopefully also fix the cause of the original error.
2021-09-05 19:54:28 +02:00
TobiGr
298e96b821
Fix updating the wrong tabs when changing settings while running the minimized player in VideoDetailFragment
...
The comments tab was updated although the settings for the description tab were changed.
2021-09-04 22:36:47 +02:00
Stypox
ed408b2094
Move fullscreen-related comments to javadocs
2021-09-01 20:13:27 +02:00
Stypox
cf9b482be2
Completely close player when changing stream w/o autoplay
2021-09-01 20:13:27 +02:00
Stypox
1d935b46f9
Open fullscreen when switching from popup to main player
2021-09-01 20:13:24 +02:00
Stypox
520ac2e935
Fix bottom sheet state after automatic fullscreen
2021-09-01 20:12:14 +02:00
Stypox
c6316abbce
Fix opening directly fullscreen on tablets
2021-09-01 20:12:09 +02:00
Stypox
2dfe837c35
Extract isLandscape and isInMultiWindow to DeviceUtils
2021-09-01 20:09:08 +02:00
Stypox
3c2ea7697c
Add option to directly open fullscreen when the main player starts
2021-09-01 20:08:37 +02:00
Stypox
cfdcb92fa3
Always use our strings, not android ones
2021-08-30 16:37:01 +02:00
Stypox
87e7d95966
Do not show suggestions error snackbar for interrupted I/O
...
Fix formatting
2021-08-24 18:16:17 +02:00
Stypox
1d33e7ab49
Allow choosing which types of search suggestions to show
...
local, remote, both, none
Replacing the old on-off setting
2021-08-24 18:16:16 +02:00
Stypox
6eaff5ca6a
Apply review: move thumbnail loading out of Player
2021-08-24 10:56:25 +02:00
Stypox
fcef783bbb
Replace UniversalImageLoader with Picasso
2021-08-24 10:56:25 +02:00
Stypox
f8caed139a
Use custom cancel string everywhere
...
to fix missing somali translation for android.R.string.cancel
2021-08-04 18:58:35 +02:00
Stypox
fa8630ddae
Use url comparison between queue items when disabling preloading
...
From #4562 : Disable player stream preloading only if the current stream is going to be replaced for sure (see this). equals() was implemented for PlayQueueItems, so that (only) the url is compared when checking them.
2021-07-21 18:09:18 +02:00
litetex
36c198fc33
One textview is enough for disabled comments
...
Ref: https://github.com/TeamNewPipe/NewPipe/pull/6483#discussion_r654793920
2021-07-17 13:14:50 +02:00
litetex
81107df53f
Added comments disabled functionallity
2021-07-17 13:10:44 +02:00
Tobi
14dab85ff0
Merge pull request #6566 from evermind-zz/various-fixes-for-upstream
...
Convert PlayerHolder to Singleton; cleanup in VideoDetailFragment; Player/MainPlayer do not call onDestroy() directly
2021-07-14 09:46:04 +02:00
Tobi
96f5cd9f17
Merge pull request #6463 from Stypox/metadata-tags
...
Improved metadata layout, better tags accessibility
2021-07-12 16:18:11 +02:00
evermind
48c2c156cb
convert PlayerHolder to Singleton, handle context within, bugfix ServiceConnection leak
...
- bugfix: have ServiceConnection created only once!
- select the context within the PlayerHolder to start, stop, bind or unbind the service
-> we have to make sure the Service is started AND stopped within the same context
-> so let PlayerHolder be the one to select the context
- remove removeListener() and replace the call with setListener(null)
- Compatibility: use ContextCompat.startForegroundService instead of startService()
2021-07-06 12:31:26 +02:00
evermind
435813355f
use viewBinding correctly
2021-07-06 07:56:05 +02:00
evermind
e30a552b6c
remove duplicated code for toggle Fullscreen
2021-07-06 07:56:00 +02:00
evermind
22a4a4b2df
move null checks for player and playerService to helper methods
...
- code is easier to read
- duplication of code reduced
2021-07-06 07:55:52 +02:00
Douile
384ca66205
#6522 : Fix null pointer exception when displaying SearchFragment
...
It seems due to #6394 updating the FragmentX library there was a
change to the order of lifecycle calls, as such onResume() was no longer
before onCreateOptionsMenu() creating a null pointer exception when
using service in onCreateOptionsMenu() as it is only set in onResume().
By moving the initialization of service to onStart() which still happens
before onCreateOptionsMenu() this crash can be avoided. This commit also
adds a check for a null service to prevent future crashes for similar
issues.
2021-06-22 16:52:02 +01:00
TacoTheDank
79deff3261
Annotate some overridden methods and parameters as NonNull
2021-06-19 18:37:02 -04:00
Tobi
be676ad93c
Merge pull request #3371 from mauriciocolli/feed-hide-played-items
...
Add ability to hide played items in a feed
2021-06-18 09:18:48 +02:00
Stypox
4698d07323
Do not hide feed buttons (show/hide & help) behind three-dots menu
2021-06-14 19:02:57 +02:00
Stypox
40a2df847b
Move tags layout at the bottom, use multiple lines
2021-06-13 21:56:06 +02:00
Stypox
edfe0f9c30
Fix disposables handling for text linkifier
...
also use differently Markwon methods to convert plain text to markdown
2021-06-11 12:12:12 +02:00
Stypox
eef418a757
Improve text linkifier function parameters
2021-06-11 12:12:11 +02:00
TiA4f8R
d6decc05d7
Move some classes to a new subpackage and adress requested changes
...
Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils.
Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage.
Remove unused param showPreviewText in shareText method of ShareUtils class.
Add initial work to be able to display an image preview of the content shared (not for downloads).
Use a better regular expression to parse timestamps in plain text descriptions.
2021-06-11 12:12:02 +02:00
TiA4f8R
d85afd6435
Initial work to add the image of the content in the share sheet
...
Also do some fixes when sharing a file in downloads and some improvements in JavaDocs of ShareUtils class.
2021-06-11 12:12:00 +02:00
TiA4f8R
ae9349e36c
Initial work: add support for opening timestamps in plain text descriptions
...
This commit adds support for opening plain text timestamps by parsing the description text using a regular expression, add a click listener for each timestamp which opens the popup player at the indicated time in the timestamp.
In order to do this, playOnPopup method of the URLHandler class. Also, handleUrl method of this class has been renamed to canHandleUrl.
2021-06-11 12:11:55 +02:00
Stypox
0113ad5e14
Correctly save stream progress at the end of a video
2021-06-09 15:53:51 +02:00
Tobi
63c9308f59
Merge pull request #5946 from Stypox/metadata
...
Show content metadata below the description
2021-06-03 20:51:33 +02:00
TiA4f8R
b4d6015464
Add the Open in browser option when long-pressing a stream for local and online playlists and for history
2021-06-03 13:21:31 +02:00
TiA4f8R
b9aaafdb30
Add Open in browser option to long-press menu
...
Add Open in browser option to long-press menu when long pressing a stream and a subscription
2021-06-03 13:15:08 +02:00
Tobi
71aa6c6e92
Merge pull request #6309 from mhmdanas/fix-channel-details-long-press-menu-on-feeds
...
Add "Show channel details" option in remote (non-local) playlists
2021-06-03 12:25:50 +02:00
Tobi
f98d2631e5
Merge pull request #6242 from evermind-zz/fixes-for-upstream
...
fix Rotation crash on „Video not available“ page (#5941 )
2021-06-03 12:22:23 +02:00
Stypox
d025ef11f8
Sort tags in metadata section
2021-06-02 21:23:42 +02:00
Stypox
14256137e8
Use chips to show tags in metadata section
...
Clicking on chips opens the search fragment
Long clicking copies to clipboard
2021-06-02 16:15:02 +02:00
Stypox
bc3e43ac58
Add button to allow selecting text in the description
...
Since now selection is disabled by default, this fixes #5453
2021-06-02 14:36:34 +02:00
Stypox
d0d5373be9
Allow copying metadata to clipboard
2021-06-02 14:19:25 +02:00
Stypox
997267bad1
Show video metadata below the decription
2021-06-02 14:19:25 +02:00
Zhiheng Xu
ea1b910d7e
Simplify code
2021-05-26 12:01:58 -04:00
Zhiheng Xu
8f4c6fb6ac
Add comment
2021-05-26 12:01:58 -04:00
Zhiheng Xu
9b1861417c
Add formatting removal on paste for search
...
Closes #5912
2021-05-26 12:01:58 -04:00
mhmdanas
b2b9938484
Put show channel details option in more long-press menus
2021-05-15 19:20:27 +03:00
evermind
a012e26d63
fix Rotation crash on „Video not available“ page ( #5941 )
...
The EmptyFragment should not have a constructor at all.
Now a static methods creates the Fragment and arguments
are handled via a Bundle.
2021-05-05 08:55:54 +02:00