bopol
c398308872
Merge pull request #6539 from TeamNewPipe/screenshots_for_UI_changes
...
Ask for screenshots/video of UI changes in PR template
2021-06-24 17:25:15 +02:00
opusforlife2
090c063644
Address Bopol's review
...
Changed the location, added option to delete, and also fixed a tiny grammar thingy.
2021-06-24 15:15:12 +00:00
opusforlife2
ec40c8ed1e
Merge pull request #6482 from Stypox/build-instructions
...
Update Build instructions to make it easier for contributors to start contributing.
2021-06-24 15:02:59 +00:00
Stypox
25914b0263
Third round of review
2021-06-24 10:46:53 +02:00
XiangRongLin
b996fa7eef
Add comments explaining decisions in test-android ci job
2021-06-23 20:16:23 +02:00
XiangRongLin
5ebf3726ed
Comment out test-android CI job
2021-06-23 20:14:27 +02:00
opusforlife2
a9e85abd7f
Ask for screenshots/video of UI changes
...
If the PR author has changed the UI of the app, they should include screenshots or a video so that developers and users alike can pinpoint exactly what changed.
2021-06-20 21:15:25 +00:00
Stypox
0db3406ad8
Fix SonarLint references and explanation
2021-06-18 12:26:50 +02:00
Stypox
8b3e32b6eb
First round of review
2021-06-17 20:47:22 +02:00
Stypox
6063ff063b
CONTRIBUTING.md: add "Build instructions" section and improve ordering
2021-06-13 21:06:59 +02:00
Tobi
81d00f2e97
Run CI on PRs which target the master branch
...
This is a fix for the release PRs
2021-06-05 17:34:27 +02:00
TiA4f8R
fe7536e374
Change NewPipe IRC links in the contribution guidelines ( #6415 )
...
* Change NewPipe IRC links in the contribution guidelines
* Remove redundant line break
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: Mohammed Anas <32234660+mhmdanas@users.noreply.github.com>
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2021-06-02 16:27:08 +00:00
Tobi
e8d518cd6c
Add Libera webchat link
2021-05-28 11:59:27 +02:00
TiA4f8R
23ee9b7867
Update Matrix link of NewPipe IRC from Freenode to Libera.chat
2021-05-27 22:07:45 +02:00
Tobi
26c535db84
Change IRC link
...
Move from freenode webchat to libera chat
2021-05-27 09:56:27 +02:00
litetex
10b1da135e
Update ci.yml
2021-05-23 14:54:49 +02:00
TacoTheDank
c74162c586
Update actions/setup-java to v2
2021-04-14 11:13:05 -04:00
Tobi
8f0323fb8d
Merge pull request #5360 from XiangRongLin/instrumented_tests
...
Run Instrumented tests in CI pipeline
2021-03-31 10:08:05 +02:00
Tobi
00fbfb5a56
Merge pull request #5866 from TacoTheDank/update-gradle-wrapper
...
Update gradle wrapper
2021-03-30 10:36:48 +02:00
XiangRongLin
0dbb212d13
Add instrumented tests to CI workflow
2021-03-29 10:18:12 +02:00
Stypox
9f59d4baa3
Add note about "Fixes" prefix to auto-link issues
2021-03-28 13:41:33 +02:00
Tobi
a7c0f37904
Disable sonar job
...
For some reason, sonar started to analyse very old PRs. This comments out the sonar job until further investigation is done.
2021-03-24 19:10:00 +01:00
TacoTheDank
cae63a7ada
Add gradle wrapper validation action
2021-03-20 21:47:19 -04:00
XiangRongLin
72818ffa42
Add sonar plugin and github actions file for sonar analysis
...
Copied from sonarcloud.io setup page with minor adjustments. Adjusted branch to 'dev' and updated versions
2021-03-20 13:58:17 +01:00
Poolitzer
3a61ab59f2
adding master to push trigger
...
Co-authored-by: Tobi <TobiGr@users.noreply.github.com>
2021-03-09 11:21:40 +01:00
Poolitzer
1db3c57ef0
change master to dev
2021-03-08 13:19:18 +01:00
Poolitzer
eeaf3496d5
Fix: CI only on master
2021-03-08 13:15:22 +01:00
Tobi
70f421b787
Add links to Matrix and IRC chat when opening new issues ( #5764 )
2021-03-08 09:43:05 +00:00
XiangRongLin
522d6d8b01
Re-add APK testing section to PR template ( #5465 )
...
Because normal users don't know that the CI process produces an APK and where it is.
2021-01-30 10:18:58 +00:00
Stypox
0d33f8b460
Merge pull request #5284 from mhmdanas/remove-pr-template-testing-apk-section
...
Remove APK testing section from PR template
2021-01-16 09:09:03 +01:00
XiangRongLin
41968918bb
Checkout branch in CI process for pull requests
...
This way the debug build app id contains the branch name again.
2021-01-14 19:39:40 +01:00
opusforlife2
24c1cfbf72
Checklist is compulsory: feature request template
2021-01-01 18:42:07 +00:00
opusforlife2
31899d2ab9
Checklist is compulsory: bug report template
2021-01-01 18:40:20 +00:00
mhmdanas
c550779472
Remove APK testing section from PR template
...
This is because the our workflows build debug APKs now.
2020-12-26 21:35:07 +03:00
FireMasterK
a00ac6b9ca
Migrate to GitHub actions from Travis.
2020-12-09 12:25:57 +05:30
Allan Nordhøy
3ad14e4adf
Contributing guidelines reworked ( #4318 )
...
* Contributing guidelines reworked
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
Co-authored-by: bopol <bopol@e.email>
Co-authored-by: Tobias Groza <TobiGr@users.noreply.github.com>
2020-11-28 12:00:00 +01:00
TobiGr
863ce65b10
Fix Issue Template config
2020-10-24 20:44:22 +02:00
opusforlife2
b7c1e88b59
Create config.yaml to prevent blank issues
2020-10-23 14:37:59 +00:00
opusforlife2
cf9da556a8
Refined instructions for feature request template
2020-10-23 07:55:31 +00:00
opusforlife2
1550fc4398
Refined instructions for bug report template
2020-10-23 07:32:04 +00:00
Allan Nordhøy
e1104570a9
Pull request template reworked ( #4317 )
...
Co-authored-by: opusforlife2 <53176348+opusforlife2@users.noreply.github.com>
2020-10-14 21:30:30 +02:00
opusforlife2
2e28fad102
Added checkbox example
2020-10-07 07:40:55 +00:00
opusforlife2
69760200dd
Added checkbox example
2020-10-07 07:39:49 +00:00
Tobias Groza
a918eaac3f
Add device info fields to bug report template ( #4415 )
2020-10-05 19:38:30 +02:00
Tobias Groza
10e95bf1b1
Merge pull request #4379 from opusforlife2/update_FR_template
...
Add check boxes to Feature Request template
2020-10-04 15:55:40 +02:00
Stypox
dd6392e380
Replace per
with for every
2020-10-04 15:47:20 +02:00
opusforlife2
b8f7ba62c7
Use @Stypox 's suggestion
...
Co-authored-by: Stypox <stypox@pm.me>
2020-10-04 12:30:44 +00:00
opusforlife2
25b318ba00
Add check boxes
...
People seem to ignore instructions in comments
2020-10-04 12:24:56 +00:00
opusforlife2
9add51b59d
Add checkboxes instead of long comments
...
People just seemed to ignore them.
2020-10-04 12:03:14 +00:00
Keegan
fb9905a89e
Add need for contributors to discuss possible changes
...
This was discussed in IRC, and should help prevent the occurrence of problems where people spend hours on a feature only for it to be rejected for miscellaneous reasons.
2020-08-14 11:27:06 -05:00