litetex
2acaefdb2a
Fixed scrolling not working when rotating device
2022-02-17 20:59:41 +01:00
litetex
9c2cdd2513
Removed useless code
...
→ https://github.com/TeamNewPipe/NewPipe/pull/7659#discussion_r793752985
2022-02-17 20:59:40 +01:00
litetex
01683aa816
Code improvements
2022-02-17 20:59:39 +01:00
litetex
85f701b94e
Fixed listener not re-registering after e.g. a new search is started
2022-02-17 20:59:38 +01:00
litetex
ff7cfe4715
Reverted to loading behavior of #7638 and improved it
...
The previous/reverted behavior caused unwanted data transmission:
* Removed loading via handleResults/loadMoreItems-callback because the RecyclerView is apparently not immediately updated in the UI when the data is set which causes one load of data to much.
2022-02-17 20:59:38 +01:00
litetex
d3cd3d62b4
Tried to repair #4475 and #3368
...
* Always recreate the footer so that it's not possible to attach the same instance twice
* Removed support for creating a custom footer as it's never used
* Supply the header with an supplier
* This might not fix the problem completely as we currently can only create the header once inside Channel, Playlist and RelatedItems-Fragment - allowing creation of multiple headers might be done in the future if the issues still arise
* Other minor fixes
2022-02-17 20:59:36 +01:00
litetex
91c67b085b
Code improvements
...
Removed - partial - stupid code.
2022-02-17 20:59:35 +01:00
litetex
cd8c7ec3c0
Removed InfoListAdapter from checkstyle-suppressions
...
because if you modify something in the code the suppressions-file no longer matches
2022-02-17 20:59:34 +01:00
litetex
2c51a7970d
Improved InfoListAdapter
...
* Removed unused code
* Cleaned it up
* Made code more readable
2022-02-17 20:59:33 +01:00
litetex
fb362022f7
Load enough initial data into BaseListFragment
2022-02-17 20:59:33 +01:00
Martin
616fb47983
Merge branch 'TeamNewPipe:dev' into dev
2022-02-17 10:20:44 +01:00
Robin
9f8e8c0856
Merge pull request #7679 from TacoTheDank/reportSenderKotlin
...
Update ACRA library
2022-02-14 15:35:00 +01:00
Tobi
5e593f687d
Merge pull request #7860 from litetex/fix-settings-search-language
...
Use the correct app language when searching in the settings
2022-02-11 21:20:08 +01:00
litetex
3223ec04e3
Use the correct app language when searching in the settings
2022-02-11 20:58:44 +01:00
TiA4f8R
608e73e2f2
Set workaround for playback position reset when switching to main player with content thumbnail
...
The workaround set before was not applied when switching to main player with content thumbnail from popup or background player. This commit fixes this by applying the workaround when switching to main player with content thumbnail from popup or background player.
2022-02-11 19:32:13 +01:00
litetex
be95d7fe0f
Merge pull request #7704 from Stypox/fix-stream-menu-crash
...
Fix crash when long-pressing stream while player is starting
2022-02-09 19:53:09 +01:00
martin
906ee75278
Fixed checkstyle violation
2022-02-05 12:31:07 +01:00
martin
4049abf2c0
Addressed comment in PR
2022-02-04 16:15:55 +01:00
martin
47798febed
fetch and merge
2022-02-04 15:34:00 +01:00
TacoTheDank
79060f0bfe
Update ACRA library
2022-02-02 13:12:29 -05:00
TiA4f8R
52cc4a0a05
Add JavaDoc for PlayerDataSource.PLAYLIST_STUCK_TARGET_DURATION_COEFFICIENT
2022-01-30 20:42:02 +01:00
TiA4f8R
e103e4817c
Apply suggested changes and remove the CustomHlsPlaylistTracker class
2022-01-30 20:42:02 +01:00
TiA4f8R
d0637a8832
Suppress SonarLint NullPointerException warnings in CustomHlsPlaylistTracker
...
They seem to be wrong, by looking at the class work and at the return of CustomHlsPlaylistTracker's methods.
2022-01-30 20:42:02 +01:00
TiA4f8R
94f774b82d
Use a custom HlsPlaylistTracker, based on DefaultHlsPlaylistTracker to allow more stucking on HLS livestreams
...
ExoPlayer's default behavior is to use a multiplication of target segment by a coefficient (3,5).
This coefficient (and this behavior) cannot be customized without using a custom HlsPlaylistTracker right now.
New behavior is to wait 15 seconds before throwing a PlaylistStuckException.
This should improve a lot HLS live streaming on (very) low-latency livestreams with buffering issues, especially on YouTube with their HLS manifests.
2022-01-30 20:42:01 +01:00
TiA4f8R
651b79d3ed
Catch properly BehindLiveWindowExceptions
...
Instead of trying to reload the play queue manager and then throwing an error, BehindLiveWindowExceptions now make the app seek to the default playback position, like recommended by ExoPlayer.
The buffering state is shown in this case.
Error handling of other exceptions is not changed.
2022-01-30 20:42:01 +01:00
litetex
dfa606ef49
Merge pull request #7586 from litetex/add-preference-search
...
Made preferences searchable
2022-01-30 17:08:04 +01:00
litetex
2886bc3b01
Merge pull request #4833 from vkay94/youtube-rewind-forward
...
YouTube's Fast Forward/Rewind behavior
2022-01-30 17:07:15 +01:00
Stypox
71c5aaa11e
Do not show enqueue button if play queue not ready
2022-01-27 17:11:16 +01:00
Stypox
17c0fffd73
Merge pull request #7538 from ktprograms/fix-queue-channel-details-not-in-db
...
Load uploaderUrl when showing Channel Details from Play Queue
2022-01-26 09:58:32 +01:00
litetex
8a069b497f
Code cleanup
...
Co-authored-by: Stypox <stypox@pm.me>
2022-01-25 20:47:53 +01:00
litetex
af79479716
Fixed "Changing the seeks duration does not update the displayed seconds"
2022-01-25 20:44:49 +01:00
Stypox
5108d75682
Fix NPE and add some @Nullables
...
Fix NullPointerException in PlayerHolder.getQueueSize() and add `@Nullable` here and there so that the linter reports risks of NPEs
2022-01-25 17:37:20 +01:00
ktprograms
1e652b159e
Load uploaderUrl when showing Channel Details from Play Queue
...
This checks if the uploaderUrl is in the database, if not it gets the
uploaderUrl and puts it in the database. This is similar to the fetching
of uploaderUrl when it doesn't exist done in #6919 .
Also use createNotification when error occurs in getStreamInfo.
2022-01-25 11:00:34 +08:00
TiA4f8R
ea07d7751b
Fix first item played in playlists when switching player type or resolution
...
The issue was caused by an ExoPlayer change, which when setting a media source, resets the current playback position and the current window index by default.
Also set player recovery in more places to fix playback position not propely set in some cases after a player type switch.
2022-01-24 21:40:16 +01:00
litetex
82de35d724
Use view binding inside `PreferenceViewHolder`
2022-01-24 21:08:52 +01:00
litetex
f55e8ea3aa
Use ViewBinding
2022-01-24 21:08:52 +01:00
litetex
7067ebdd12
Fixed imports
2022-01-24 21:08:51 +01:00
litetex
03bb2123f2
Removed breadcrumbs customization
2022-01-24 21:08:51 +01:00
litetex
e2f449f0c8
Code improvements
...
* Renamed methods so that they are more understandable
* Removed ``SearchIndexItem``
2022-01-24 21:08:50 +01:00
litetex
b16e972710
Improved doc
2022-01-24 21:08:50 +01:00
litetex
37cd71328c
Moved `FuzzyScore` to original Apache package
2022-01-24 21:08:49 +01:00
litetex
9b2c86a37b
Improved documentation
2022-01-24 21:08:48 +01:00
litetex
ce4dd33eab
Fixed problems with Android's lifecycle (restore)
2022-01-24 21:08:48 +01:00
litetex
c5a06243a6
Fixed variable name
2022-01-24 21:08:47 +01:00
litetex
bebd2b449c
Removed unused import
2022-01-24 21:08:46 +01:00
litetex
658168eb8d
Fixed some sonar warnings
2022-01-24 21:08:45 +01:00
litetex
6b23df0659
Made debug settings searchable (debug only)
...
* Consolidated main-setttings into a single file
* Debug settings are only enabled in the DEBUG build
* Moved LeakCanary (debug) specific stuff into a small class that's only shipped with the debug build
* Other minor fixes
2022-01-24 21:08:45 +01:00
litetex
d59314801c
Code rework
2022-01-24 21:08:44 +01:00
litetex
0f45c69388
Code cleanup + indexing improvements
...
* Removed unused method
* Only index all settings once -> Saves performance
* Fixed some SonarLint reported problems
2022-01-24 21:08:44 +01:00
litetex
52542e04e8
Added fuzzy searching + Some minor code refactoring
2022-01-24 21:08:43 +01:00
litetex
7fc0a3841a
Fine tuning
2022-01-24 21:08:42 +01:00
litetex
22db4175f3
Moved reset-reCAPTCHA-cookie to cache tab and made it read-only
...
so that the search works as expected
2022-01-24 21:08:42 +01:00
litetex
07fb319e88
Applied code changes for preference search framework
2022-01-24 21:08:41 +01:00
litetex
12a78a826d
Added preference search "framework"
2022-01-24 21:08:40 +01:00
litetex
4a061f20ed
Code cleanup
2022-01-24 21:08:39 +01:00
litetex
f3be89b503
Abstracted methods for the Android keyboard
2022-01-24 21:08:39 +01:00
litetex
12acaf29dd
Added credit to the project which inspired the preference search
2022-01-24 21:08:38 +01:00
litetex
683d9816cb
Removed dead code
2022-01-24 21:08:38 +01:00
litetex
e127db6fa6
Simplified toast showing behavior
...
after feedback from the review
2022-01-23 15:34:11 +01:00
litetex
49b1649348
Revert "Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud"
...
This reverts commit ee19ea66b36b490ee547
2022-01-23 15:34:11 +01:00
litetex
54ef604569
Improved docs
2022-01-21 22:49:25 +01:00
litetex
30ce906f72
Apply seek conditions based on direction
...
* When rewinding: Check if <0,5s
* When fast-forwarding: Check if player has completed or the current playback has ended
This allows rewinding on the endscreen
2022-01-21 22:49:25 +01:00
litetex
1c20eabb48
Code cleanup
2022-01-21 22:49:25 +01:00
litetex
f8c52c4dac
Fixed SonarLint problems
...
* Removed alphaRelativeDuration as there is no use for it
2022-01-21 22:49:24 +01:00
litetex
345ba74d58
Fixed naming
2022-01-21 22:49:24 +01:00
litetex
d2aaf152a0
Removed related import
2022-01-21 22:49:24 +01:00
litetex
7bf1f3dba6
Removed unused field
2022-01-21 22:49:24 +01:00
litetex
452fe3a8e2
Respect disabled animations
2022-01-21 22:49:24 +01:00
litetex
c25e523df6
Removed all animations to be consistent with the current behavior
2022-01-21 22:49:23 +01:00
litetex
65bb1dcdbf
Refactored code
2022-01-21 22:49:23 +01:00
litetex
fe42206e94
Code cleanup and minimization
...
* Deduplicated and simplified a lot of code
* Fixed ``invalidSeekConditions`` so that it's possible to seek while the player is loading (like currently the case)
2022-01-21 22:49:23 +01:00
TobiGr
dac47d9f52
Replace NotNull annotation with NonNull annotation
2022-01-21 22:49:23 +01:00
Stypox
83a3d11f38
Small improvements to player
2022-01-21 22:49:22 +01:00
Stypox
a454a41b51
Fix controls not hiding correctly when switching player
2022-01-21 22:49:22 +01:00
Stypox
95631dba46
Convert SecondsView from kotlin synthetics to view binding
2022-01-21 22:49:22 +01:00
vkay94
3aebfa22e9
SeekOverlay: Switch to merge for SecondsView and other adjustments
2022-01-21 22:49:21 +01:00
vkay94
72eb3b4415
SeekOverlay: Add seek overlay logic to player
2022-01-21 22:49:21 +01:00
vkay94
3a40759cd2
SeekOverlay: Add Views
2022-01-21 22:49:21 +01:00
XiangRongLin
cd265fc31f
Make SearchHistoryEntry.kt fields nullable to match java version ( #7674 )
2022-01-21 16:01:11 +00:00
litetex
f681b0bb5a
Merge pull request #7648 from mhmdanas/small-refactors
...
Fix false warning
2022-01-19 19:48:07 +01:00
XiangRongLin
d7fbddf6f8
Merge pull request #7668 from litetex/fix-video-reset-on-player-switch
...
Workaround: Set recovery before switching player
2022-01-19 16:45:10 +01:00
mhmdanas
402990dd9d
Fix false warning
2022-01-18 07:40:59 +03:00
litetex
41faf70da1
Workaround: Set recovery before switching player
...
Quick fix
2022-01-17 20:52:07 +01:00
litetex
15e3b6301c
Merge pull request #7662 from TiA4f8R/fix-npe-share-button-playlists
...
Fix crash when sharing a playlist which is loading
2022-01-16 19:47:55 +01:00
XiangRongLin
5b9c28b93b
Replace JUnit asserts with AssertJ in HistoryRecordManagerTest ( #7654 )
...
* Replace JUnit asserts with AssertJ in HistoryRecordManagerTest
They provide a wider range of assertions, which allow for more detailed error messages.
Also convert SearchHistoryEntry to kotlin data class for better error messages, since toString() is implemented.
Co-authored-by: Mohammed Anas <triallax@tutanota.com>
2022-01-16 09:10:45 +01:00
TiA4f8R
6672169707
Fix NullPointerException when sharing a playlist which is loading
...
Prevent a NullPointerException by adding a null check for currentInfo when sharing a playlist.
2022-01-15 21:19:04 +01:00
Stypox
7907182e7e
Merge pull request #7036 from Douile/fix/queue-metadata
...
Load full stream info when enqueuing a stream
2022-01-07 21:57:30 +01:00
Douile
064242d962
Remove unecessary interface InfoCallback
...
Co-authored-by: Stypox <stypox@pm.me>
Replace the unecessary callback interface InfoCallback in favour of the
standard type Consumer<SinglePlayQueue>
2022-01-03 17:52:27 +00:00
litetex
ddcbe27fd3
Fixed search not accepting key input after closing player overlay ( #7607 )
...
* Fixed search not accepting key input after closing player overlay
* Made comments easier to understand
* More comments
2022-01-03 11:52:08 +01:00
litetex
ee19ea66b3
Merge pull request #7568 from vhouriet/vhouriet_feature_already-playing-in-backgroud
...
Add Already playing in background toast
2021-12-31 14:54:05 +01:00
litetex
6b490ee547
Merge pull request #7582 from Jaspann/sub-channel-tumbnail-view-fix
...
Fixes view of sub-channel icon when not in use
2021-12-31 14:52:32 +01:00
Jaspann
558c9147a2
Move sub icon visibility line
2021-12-28 15:54:36 -05:00
litetex
fc0e709817
Fixed usage of wrong string
2021-12-27 00:14:04 +01:00
litetex
b67bf16d4f
Minified code
2021-12-26 23:57:54 +01:00
William Parker
fb3be544ce
Fixed code styling
2021-12-26 00:12:48 -05:00
Jaspann
53f5741317
Fixes view of sub-channel icon when not in use
2021-12-25 18:10:05 -05:00
Martin
5134080f87
Merge branch 'TeamNewPipe:dev' into dev
2021-12-25 15:14:24 +01:00
David Kramer
07015973d2
Added ability to see pinned comment
2021-12-24 11:29:34 -06:00
Tobi
215880207e
Merge pull request #7562 from TeamNewPipe/code-quality
...
Small improvements to code quality and readability
2021-12-23 23:54:29 +01:00
vhouriet
989bcbf895
Add Already playing in background toast
2021-12-23 22:12:38 +01:00
