Tobi
14dab85ff0
Merge pull request #6566 from evermind-zz/various-fixes-for-upstream
...
Convert PlayerHolder to Singleton; cleanup in VideoDetailFragment; Player/MainPlayer do not call onDestroy() directly
2021-07-14 09:46:04 +02:00
Tobi
96f5cd9f17
Merge pull request #6463 from Stypox/metadata-tags
...
Improved metadata layout, better tags accessibility
2021-07-12 16:18:11 +02:00
evermind
48c2c156cb
convert PlayerHolder to Singleton, handle context within, bugfix ServiceConnection leak
...
- bugfix: have ServiceConnection created only once!
- select the context within the PlayerHolder to start, stop, bind or unbind the service
-> we have to make sure the Service is started AND stopped within the same context
-> so let PlayerHolder be the one to select the context
- remove removeListener() and replace the call with setListener(null)
- Compatibility: use ContextCompat.startForegroundService instead of startService()
2021-07-06 12:31:26 +02:00
evermind
435813355f
use viewBinding correctly
2021-07-06 07:56:05 +02:00
evermind
e30a552b6c
remove duplicated code for toggle Fullscreen
2021-07-06 07:56:00 +02:00
evermind
22a4a4b2df
move null checks for player and playerService to helper methods
...
- code is easier to read
- duplication of code reduced
2021-07-06 07:55:52 +02:00
Douile
384ca66205
#6522 : Fix null pointer exception when displaying SearchFragment
...
It seems due to #6394 updating the FragmentX library there was a
change to the order of lifecycle calls, as such onResume() was no longer
before onCreateOptionsMenu() creating a null pointer exception when
using service in onCreateOptionsMenu() as it is only set in onResume().
By moving the initialization of service to onStart() which still happens
before onCreateOptionsMenu() this crash can be avoided. This commit also
adds a check for a null service to prevent future crashes for similar
issues.
2021-06-22 16:52:02 +01:00
TacoTheDank
79deff3261
Annotate some overridden methods and parameters as NonNull
2021-06-19 18:37:02 -04:00
Tobi
be676ad93c
Merge pull request #3371 from mauriciocolli/feed-hide-played-items
...
Add ability to hide played items in a feed
2021-06-18 09:18:48 +02:00
Stypox
4698d07323
Do not hide feed buttons (show/hide & help) behind three-dots menu
2021-06-14 19:02:57 +02:00
Stypox
40a2df847b
Move tags layout at the bottom, use multiple lines
2021-06-13 21:56:06 +02:00
Stypox
edfe0f9c30
Fix disposables handling for text linkifier
...
also use differently Markwon methods to convert plain text to markdown
2021-06-11 12:12:12 +02:00
Stypox
eef418a757
Improve text linkifier function parameters
2021-06-11 12:12:11 +02:00
TiA4f8R
d6decc05d7
Move some classes to a new subpackage and adress requested changes
...
Rename URLHandler and KoreUtil classes to InternalUrlsHandler and KoreUtils.
Move InternalUrlsHandler, KoreUtils, TextLinkfier, ShareUtils classes to external_communication subpackage.
Remove unused param showPreviewText in shareText method of ShareUtils class.
Add initial work to be able to display an image preview of the content shared (not for downloads).
Use a better regular expression to parse timestamps in plain text descriptions.
2021-06-11 12:12:02 +02:00
TiA4f8R
d85afd6435
Initial work to add the image of the content in the share sheet
...
Also do some fixes when sharing a file in downloads and some improvements in JavaDocs of ShareUtils class.
2021-06-11 12:12:00 +02:00
TiA4f8R
ae9349e36c
Initial work: add support for opening timestamps in plain text descriptions
...
This commit adds support for opening plain text timestamps by parsing the description text using a regular expression, add a click listener for each timestamp which opens the popup player at the indicated time in the timestamp.
In order to do this, playOnPopup method of the URLHandler class. Also, handleUrl method of this class has been renamed to canHandleUrl.
2021-06-11 12:11:55 +02:00
Stypox
0113ad5e14
Correctly save stream progress at the end of a video
2021-06-09 15:53:51 +02:00
Tobi
63c9308f59
Merge pull request #5946 from Stypox/metadata
...
Show content metadata below the description
2021-06-03 20:51:33 +02:00
TiA4f8R
b4d6015464
Add the Open in browser option when long-pressing a stream for local and online playlists and for history
2021-06-03 13:21:31 +02:00
TiA4f8R
b9aaafdb30
Add Open in browser option to long-press menu
...
Add Open in browser option to long-press menu when long pressing a stream and a subscription
2021-06-03 13:15:08 +02:00
Tobi
71aa6c6e92
Merge pull request #6309 from mhmdanas/fix-channel-details-long-press-menu-on-feeds
...
Add "Show channel details" option in remote (non-local) playlists
2021-06-03 12:25:50 +02:00
Tobi
f98d2631e5
Merge pull request #6242 from evermind-zz/fixes-for-upstream
...
fix Rotation crash on „Video not available“ page (#5941 )
2021-06-03 12:22:23 +02:00
Stypox
d025ef11f8
Sort tags in metadata section
2021-06-02 21:23:42 +02:00
Stypox
14256137e8
Use chips to show tags in metadata section
...
Clicking on chips opens the search fragment
Long clicking copies to clipboard
2021-06-02 16:15:02 +02:00
Stypox
bc3e43ac58
Add button to allow selecting text in the description
...
Since now selection is disabled by default, this fixes #5453
2021-06-02 14:36:34 +02:00
Stypox
d0d5373be9
Allow copying metadata to clipboard
2021-06-02 14:19:25 +02:00
Stypox
997267bad1
Show video metadata below the decription
2021-06-02 14:19:25 +02:00
Zhiheng Xu
ea1b910d7e
Simplify code
2021-05-26 12:01:58 -04:00
Zhiheng Xu
8f4c6fb6ac
Add comment
2021-05-26 12:01:58 -04:00
Zhiheng Xu
9b1861417c
Add formatting removal on paste for search
...
Closes #5912
2021-05-26 12:01:58 -04:00
mhmdanas
b2b9938484
Put show channel details option in more long-press menus
2021-05-15 19:20:27 +03:00
evermind
a012e26d63
fix Rotation crash on „Video not available“ page ( #5941 )
...
The EmptyFragment should not have a constructor at all.
Now a static methods creates the Fragment and arguments
are handled via a Bundle.
2021-05-05 08:55:54 +02:00
camo0112
8f9eaa22e6
Fix display of channel details when it has no videos
2021-04-09 12:45:43 +05:30
krlvm
e484339cca
Merge branch 'dev' into daynight
2021-04-03 00:08:26 +03:00
Stypox
2af20d5c40
Merge pull request #5974 from fynngodau/related-items
...
Rename related streams to related items
2021-04-02 20:34:39 +02:00
Saurav Rao
8df935f5fe
NullPointerException on screen rotation during exit fix ( #5976 )
2021-04-01 15:07:21 +02:00
Fynn Godau
c9766d25ef
Rename related streams to related items
2021-03-31 22:33:22 +02:00
Stypox
43f85408be
Merge pull request #5944 from Stypox/fix-search-menu
...
Fix some random NullPointerExceptions
2021-03-31 15:21:13 +02:00
Stypox
3e8cba745a
Fix random NullPointerException in PlaylistFragment
2021-03-31 09:12:47 +02:00
Stypox
be4d12789d
Fix random NullPointerException in SearchFragment
2021-03-31 09:12:45 +02:00
Mohammed Anas
6a9cae3de8
Add channel details option to long-press menu ( #5851 )
...
Add dialog item to open channel details
Use `List` as type of `entries`
Put channel details item last
Only show channel option when channel is present
2021-03-28 18:32:40 +02:00
krlvm
609d09a8e2
Remove unused SuggestionListAdapter.resolveResourceIdFromAttr
2021-03-28 15:12:59 +03:00
krlvm
01e8654fbd
Fix Search colors on KitKat
2021-03-28 14:55:54 +03:00
krlvm
f477ab84d5
Fix tab highlight opacity on KitKat
2021-03-28 14:43:11 +03:00
krlvm
fd14c8cdce
Fix Dark elements in Light Theme
2021-03-27 17:46:05 +03:00
Stypox
0277b94b37
Fix error panel created in onViewCreated() but disposed in onDestroy()
2021-03-24 09:27:17 +01:00
Stypox
93592d23f4
Merge pull request #5820 from TeamNewPipe/mini_player_title
...
Fix empty stream title in minimized player
2021-03-17 08:56:50 +01:00
TobiGr
292e103073
Ignore ContentNotSupportedException caused by Bandcamp fan pages
2021-03-14 17:52:15 +01:00
Tobi
404a6c12a6
Merge pull request #5148 from Stypox/error-panel
...
Show improved error panel instead of annoying snackbar or crashing
2021-03-14 17:41:27 +01:00
Tobi
8271409afe
Merge pull request #5562 from mbarashkov/hardware_keyboard_space_shortcut_v2
...
Implement "pause/play" toggle on hardware keyboard space button.
2021-03-14 13:08:44 +01:00
