We provide visual feedback via a toast to the user that, well, they're supposed to wait; but with the benefit of the cache openAddToPlaylistDialog() may return (almost) immediately, which would render the toast otiose (if not a bit confusing). This commit improves that by cancelling the toast once the wait's over
... (by 'abusing' RxJava's ambWith();
ref on compose() and Transformer: https://blog.danlew.net/2015/03/02/dont-break-the-chain/
and for me, first time laying my hands at RxJava so kindly bear with me; open for suggestions)
pending result for openAddToPlaylistDialog() and openDownloadDialog()
Despite marked deprecated, setRetainInstance(true) is probably our best bet (since a ViewModel is probably too overkill for our present purpose)
so we won't hold up UI while fetching media info for Add to Playlist or Download actions
lest user might think it freezes when in fact a network request is underway
- Handle finish() call instead of passing around callbacks to setOnDismissListener()
- Don't start over again if returning to DialogFragment before orientation change
This seems to solve a bug where the Open action menu dialog does not appear the first time on cold start on older Android (8.0).
This is also the order of things in MainActivity and probably good practice.
Currently translated at 93.0% (67 of 72 strings)
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (72 of 72 strings)
Translated using Weblate (Ukrainian)
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (French)
Currently translated at 91.6% (66 of 72 strings)
Translated using Weblate (Urdu)
Currently translated at 66.9% (434 of 648 strings)
Translated using Weblate (Hungarian)
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (Portuguese (Portugal))
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (Punjabi)
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (Azerbaijani)
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (Hindi)
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (Romanian)
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (Italian)
Currently translated at 100.0% (72 of 72 strings)
Translated using Weblate (Telugu)
Currently translated at 6.9% (5 of 72 strings)
Translated using Weblate (Telugu)
Currently translated at 66.9% (434 of 648 strings)
Translated using Weblate (Russian)
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (Dutch)
Currently translated at 100.0% (648 of 648 strings)
Translated using Weblate (Tamil)
Currently translated at 54.0% (350 of 648 strings)
Translated using Weblate (Chinese (Traditional, Hong Kong))
Currently translated at 100.0% (648 of 648 strings)
Co-authored-by: Ahmad Raza <ahmadrazaxm@gmail.com>
Co-authored-by: Dan <denqwerta@gmail.com>
Co-authored-by: Florian <flo.site@zaclys.net>
Co-authored-by: Hosted Weblate <hosted@weblate.org>
Co-authored-by: Igor Nedoboy <i.nedoboy@mail.ru>
Co-authored-by: Igor Sorocean <sorocean.igor@gmail.com>
Co-authored-by: K.B.Dharun Krishna <kbdharunkrishna@gmail.com>
Co-authored-by: Kiss Attila <gaxeco4855@pro5g.com>
Co-authored-by: Nidi <nizamismidov4@gmail.com>
Co-authored-by: Ray <ray.cfu@protonmail.com>
Co-authored-by: ShareASmile <aapshergill@gmail.com>
Co-authored-by: Terry Louwers <t.louwers@gmail.com>
Co-authored-by: Translator <kvb@tuta.io>
Co-authored-by: pjammo <adrianoghr@hotmail.it>
Co-authored-by: ssantos <ssantos@web.de>
Co-authored-by: subba raidu <raidu4u@gmail.com>
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/fr/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/it/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/te/
Translate-URL: https://hosted.weblate.org/projects/newpipe/metadata/uk/
Translation: NewPipe/Metadata
