From fea9cbd34e473bdc1c8360778588c09d50bef2aa Mon Sep 17 00:00:00 2001 From: Atemu Date: Fri, 15 May 2020 21:40:22 +0200 Subject: [PATCH] SponsorBlock: Add link to privacy policy Using the SponsorBlock has a slight privacy implication which the user should be able to inform themself on. --- .../newpipe/settings/ContentSettingsFragment.java | 11 +++++++++++ app/src/main/res/values/settings_keys.xml | 1 + app/src/main/res/values/strings.xml | 2 ++ app/src/main/res/xml/content_settings.xml | 6 ++++++ 4 files changed, 20 insertions(+) diff --git a/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java b/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java index a88b6386d..1f57eceda 100644 --- a/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java +++ b/app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java @@ -140,6 +140,17 @@ public class ContentSettingsFragment extends BasePreferenceFragment { return true; }); + Preference sponsorblockPrivacyPreference = + findPreference(getString(R.string.sponsorblock_privacy)); + sponsorblockPrivacyPreference.setOnPreferenceClickListener((Preference p) -> { + Intent i = new Intent(Intent.ACTION_VIEW, + Uri.parse( + "https://gist.github.com/ajayyy/aa9f8ded2b573d4f73a3ffa0ef74f796" + + "#requests-sent-to-the-server-while-using-the-extension")); + startActivity(i); + return true; + }); + Preference sponsorblockStatusPreference = findPreference(getString(R.string.sponsorblock_status)); sponsorblockStatusPreference.setOnPreferenceClickListener((Preference p) -> { diff --git a/app/src/main/res/values/settings_keys.xml b/app/src/main/res/values/settings_keys.xml index 2fb422ceb..371c280f3 100644 --- a/app/src/main/res/values/settings_keys.xml +++ b/app/src/main/res/values/settings_keys.xml @@ -226,6 +226,7 @@ skip_sponsors sponsorblock_notifications sponsorblock_status + sponsorblock_privacy file_rename_charset diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 6fc7ab468..a8f1693fc 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -665,6 +665,8 @@ Use the SponsorBlock API to automatically skip sponsors in videos. Notify when sponsors are skipped Send a notification to your device when a sponsor is automatically skipped. + View Privacy Policy + View the privacy policy of the SponsorBlock service. View Online Status View the online status of the SponsorBlock servers. \ No newline at end of file diff --git a/app/src/main/res/xml/content_settings.xml b/app/src/main/res/xml/content_settings.xml index fedb9bfff..64f976058 100644 --- a/app/src/main/res/xml/content_settings.xml +++ b/app/src/main/res/xml/content_settings.xml @@ -137,6 +137,12 @@ android:title="@string/sponsorblock_notifications_title" app:iconSpaceReserved="false" /> + +