baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity

Fix crash on startup caused by no implementation of onError() method

Browse source
This commit is contained in:
TobiGr 2020-11-22 11:46:19 +01:00
parent 17866c29ae
commit fd4c37e9b3
1 changed files with 29 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
app/src/main/java/org/schabi/newpipe/CheckForNewAppVersion.java
View file

@ -198,24 +198,36 @@ public final class CheckForNewAppVersion {
}) })
.subscribeOn(Schedulers.io()) .subscribeOn(Schedulers.io())
.observeOn(AndroidSchedulers.mainThread()) .observeOn(AndroidSchedulers.mainThread())
.subscribe(response -> { .subscribe(
// Parse the json from the response. response -> {
try { // Parse the json from the response.
final JsonObject githubStableObject = JsonParser.object().from(response) try {
.getObject("flavors").getObject("github").getObject("stable"); final JsonObject githubStableObject = JsonParser.object()
.from(response).getObject("flavors").getObject("github")
.getObject("stable");
final String versionName = githubStableObject.getString("version"); final String versionName = githubStableObject
final int versionCode = githubStableObject.getInt("version_code"); .getString("version");
final String apkLocationUrl = githubStableObject.getString("apk"); final int versionCode = githubStableObject
.getInt("version_code");
final String apkLocationUrl = githubStableObject
.getString("apk");
compareAppVersionAndShowNotification(app, versionName, apkLocationUrl, compareAppVersionAndShowNotification(app, versionName,
versionCode); apkLocationUrl, versionCode);
} catch (final JsonParserException e) { } catch (final JsonParserException e) {
// connectivity problems, do not alarm user and fail silently // connectivity problems, do not alarm user and fail silently
if (DEBUG) { if (DEBUG) {
Log.w(TAG, Log.getStackTraceString(e)); Log.w(TAG, Log.getStackTraceString(e));
} }
} }
}); },
throwable -> {
// connectivity problems, do not alarm user and fail silently
if (DEBUG) {
Log.i(TAG, "Could not get NewPipe API: network problem");
Log.i(TAG, Log.getStackTraceString(throwable));
}
});
} }
} }