Couple more code review changes
This commit is contained in:
parent
c46a0f7b2e
commit
eb5fb42da9
2 changed files with 8 additions and 4 deletions
|
@ -403,9 +403,13 @@ public final class BackgroundPlayer extends Service {
|
||||||
updateProgress(currentProgress, duration, bufferPercent);
|
updateProgress(currentProgress, duration, bufferPercent);
|
||||||
|
|
||||||
if (!shouldUpdateOnProgress) return;
|
if (!shouldUpdateOnProgress) return;
|
||||||
if (timesNotificationUpdated > NOTIFICATION_UPDATES_BEFORE_RESET) {resetNotification();
|
if (timesNotificationUpdated > NOTIFICATION_UPDATES_BEFORE_RESET) {
|
||||||
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O /*Oreo*/)
|
resetNotification();
|
||||||
updateNotificationThumbnail();}
|
|
||||||
|
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O /*Oreo*/) {
|
||||||
|
updateNotificationThumbnail();
|
||||||
|
}
|
||||||
|
}
|
||||||
if (bigNotRemoteView != null) {
|
if (bigNotRemoteView != null) {
|
||||||
if (cachedDuration != duration) {
|
if (cachedDuration != duration) {
|
||||||
cachedDuration = duration;
|
cachedDuration = duration;
|
||||||
|
|
|
@ -82,7 +82,7 @@ public class MediaSessionManager {
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Should be called on player destruction to prevent leakage.BitmapUtils
|
* Should be called on player destruction to prevent leakage.
|
||||||
*/
|
*/
|
||||||
public void dispose() {
|
public void dispose() {
|
||||||
this.sessionConnector.setPlayer(null);
|
this.sessionConnector.setPlayer(null);
|
||||||
|
|
Loading…
Reference in a new issue