baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity

Fix sonar warning

Browse source
This commit is contained in:
GGAutomaton 2022-04-16 12:44:24 +08:00
parent c24aed054f
commit bd1aae8d66
1 changed files with 6 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
app/src/main/java/org/schabi/newpipe/local/bookmark/BookmarkFragment.java
View file

@ -446,13 +446,11 @@ public final class BookmarkFragment extends BaseLocalListFragment<List<PlaylistL
final Long databaseIndex = displayIndexInDatabase.remove(key); final Long databaseIndex = displayIndexInDatabase.remove(key);
// The database index should not be null because inserting new item into database // The database index should not be null because inserting new item into database
// is not dealt here. NullPointerException has occurred once, but I can't reproduce // is not handled here. NullPointerException has occurred once, but I can't
// it. Enhance robustness here. // reproduce it. Enhance robustness here.
if (databaseIndex != null) { if (databaseIndex != null && databaseIndex != i) {
if (databaseIndex != i) {
localItemsUpdate.add((PlaylistMetadataEntry) item); localItemsUpdate.add((PlaylistMetadataEntry) item);
} }
}
} else if (item instanceof PlaylistRemoteEntity) { } else if (item instanceof PlaylistRemoteEntity) {
((PlaylistRemoteEntity) item).setDisplayIndex(i); ((PlaylistRemoteEntity) item).setDisplayIndex(i);
@ -461,13 +459,11 @@ public final class BookmarkFragment extends BaseLocalListFragment<List<PlaylistL
LocalItem.LocalItemType.PLAYLIST_REMOTE_ITEM); LocalItem.LocalItemType.PLAYLIST_REMOTE_ITEM);
final Long databaseIndex = displayIndexInDatabase.remove(key); final Long databaseIndex = displayIndexInDatabase.remove(key);
if (databaseIndex != null) { if (databaseIndex != null && databaseIndex != i) {
if (databaseIndex != i) {
remoteItemsUpdate.add((PlaylistRemoteEntity) item); remoteItemsUpdate.add((PlaylistRemoteEntity) item);
} }
} }
} }
}
// Find deleted items // Find deleted items
for (final Pair<Long, LocalItem.LocalItemType> key : displayIndexInDatabase.keySet()) { for (final Pair<Long, LocalItem.LocalItemType> key : displayIndexInDatabase.keySet()) {