baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 5 Packages Wiki Activity

Merge pull request #2423 from Redirion/patch-2

Browse source 
Silence CheckForNewAppVersionTask
This commit is contained in:
Tobias Groza 2019-07-07 21:08:01 +02:00 committed by GitHub
commit ad79a71fbd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
app/src/main/java/org/schabi/newpipe/CheckForNewAppVersionTask.java
View file

@ -14,6 +14,7 @@ import android.os.AsyncTask;
import android.preference.PreferenceManager; import android.preference.PreferenceManager;
import android.support.v4.app.NotificationCompat; import android.support.v4.app.NotificationCompat;
import android.support.v4.app.NotificationManagerCompat; import android.support.v4.app.NotificationManagerCompat;
import android.util.Log;
import org.json.JSONException; import org.json.JSONException;
import org.json.JSONObject; import org.json.JSONObject;
@ -47,6 +48,8 @@ import okhttp3.Response;
*/ */
public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> { public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> {
private static final boolean DEBUG = MainActivity.DEBUG;
private static final String TAG = CheckForNewAppVersionTask.class.getSimpleName();
private static final Application app = App.getApp(); private static final Application app = App.getApp();
private static final String GITHUB_APK_SHA1 = "B0:2E:90:7C:1C:D6:FC:57:C3:35:F0:88:D0:8F:50:5F:94:E4:D2:15"; private static final String GITHUB_APK_SHA1 = "B0:2E:90:7C:1C:D6:FC:57:C3:35:F0:88:D0:8F:50:5F:94:E4:D2:15";
private static final String newPipeApiUrl = "https://newpipe.schabi.org/api/data.json"; private static final String newPipeApiUrl = "https://newpipe.schabi.org/api/data.json";
@ -90,9 +93,8 @@ public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> {
Response response = client.newCall(request).execute(); Response response = client.newCall(request).execute();
return response.body().string(); return response.body().string();
} catch (IOException ex) { } catch (IOException ex) {
ErrorActivity.reportError(app, ex, null, null, // connectivity problems, do not alarm user and fail silently
ErrorActivity.ErrorInfo.make(UserAction.SOMETHING_ELSE, "none", if (DEBUG) Log.w(TAG, Log.getStackTraceString(ex));
"app update API fail", R.string.app_ui_crash));
} }
return null; return null;
@ -117,9 +119,8 @@ public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> {
compareAppVersionAndShowNotification(versionName, apkLocationUrl, versionCode); compareAppVersionAndShowNotification(versionName, apkLocationUrl, versionCode);
} catch (JSONException ex) { } catch (JSONException ex) {
ErrorActivity.reportError(app, ex, null, null, // connectivity problems, do not alarm user and fail silently
ErrorActivity.ErrorInfo.make(UserAction.SOMETHING_ELSE, "none", if (DEBUG) Log.w(TAG, Log.getStackTraceString(ex));
"could not parse app update JSON data", R.string.app_ui_crash));
} }
} }
} }