baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity

correctness

Browse source 
use apply() on SharedPreferences
use dp instead of sp for text sizes

BUILD SUCCESSFUL in 22s
39 actionable tasks: 10 executed, 29 up-to-date
This commit is contained in:
BO41 2018-08-28 19:30:44 +02:00
parent 5660b5ddc6
commit a588ec084b
3 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/org/schabi/newpipe/settings/ContentSettingsFragment.java
View file

@ -264,7 +264,7 @@ public class ContentSettingsFragment extends BasePreferenceFragment {
else if (v instanceof String) else if (v instanceof String)
prefEdit.putString(key, ((String) v)); prefEdit.putString(key, ((String) v));
} }
prefEdit.commit(); prefEdit.apply();
} catch (FileNotFoundException e) { } catch (FileNotFoundException e) {
e.printStackTrace(); e.printStackTrace();
} catch (IOException e) { } catch (IOException e) {

4
app/src/main/res/layout-v21/drawer_header.xml
View file

@ -40,7 +40,7 @@
android:layout_toRightOf="@id/drawer_header_np_nude_view" android:layout_toRightOf="@id/drawer_header_np_nude_view"
android:gravity="center" android:gravity="center"
android:text="@string/app_name" android:text="@string/app_name"
android:textSize="30dp" android:textSize="30sp"
android:textColor="@color/drawer_header_font_color" android:textColor="@color/drawer_header_font_color"
android:textStyle="bold|italic" /> android:textStyle="bold|italic" />
@ -52,7 +52,7 @@
android:layout_alignStart="@id/drawer_header_np_text_view" android:layout_alignStart="@id/drawer_header_np_text_view"
android:layout_below="@id/drawer_header_np_text_view" android:layout_below="@id/drawer_header_np_text_view"
android:text="YouTube" android:text="YouTube"
android:textSize="18dp" android:textSize="18sp"
android:textColor="@color/drawer_header_font_color" android:textColor="@color/drawer_header_font_color"
android:textStyle="italic" /> android:textStyle="italic" />

4
app/src/main/res/layout/drawer_header.xml
View file

@ -40,7 +40,7 @@ android:focusable="true">
android:layout_alignTop="@id/drawer_header_np_nude_view" android:layout_alignTop="@id/drawer_header_np_nude_view"
android:layout_alignBottom="@id/drawer_header_np_nude_view" android:layout_alignBottom="@id/drawer_header_np_nude_view"
android:gravity="center" android:gravity="center"
android:textSize="30dp" android:textSize="30sp"
android:textColor="@color/drawer_header_font_color" android:textColor="@color/drawer_header_font_color"
android:textStyle="bold|italic"/> android:textStyle="bold|italic"/>
@ -52,7 +52,7 @@ android:focusable="true">
android:layout_below="@id/drawer_header_np_text_view" android:layout_below="@id/drawer_header_np_text_view"
android:layout_alignLeft="@id/drawer_header_np_text_view" android:layout_alignLeft="@id/drawer_header_np_text_view"
android:layout_alignStart="@id/drawer_header_np_text_view" android:layout_alignStart="@id/drawer_header_np_text_view"
android:textSize="18dp" android:textSize="18sp"
android:textColor="@color/drawer_header_font_color" android:textColor="@color/drawer_header_font_color"
android:textStyle="italic"/> android:textStyle="italic"/>