baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity

Change heart color to be red, add else clause for non hearted comments, and apply some code style suggestions.

Browse source
This commit is contained in:
Kalle Struik 2021-07-23 19:43:25 +02:00
parent 3874e16187
commit 74173317de
5 changed files with 10 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/src/main/java/org/schabi/newpipe/info_list/holder/CommentsMiniInfoItemHolder.java
View file

@ -82,7 +82,7 @@ public class CommentsMiniInfoItemHolder extends InfoItemHolder {
itemDislikesCountView = itemView.findViewById(R.id.detail_thumbs_down_count_view); itemDislikesCountView = itemView.findViewById(R.id.detail_thumbs_down_count_view);
itemPublishedTime = itemView.findViewById(R.id.itemPublishedTime); itemPublishedTime = itemView.findViewById(R.id.itemPublishedTime);
itemContentView = itemView.findViewById(R.id.itemCommentContentView); itemContentView = itemView.findViewById(R.id.itemCommentContentView);
itemHeartView = itemView.findViewById(R.id.detail_heart_img_view); itemHeartView = itemView.findViewById(R.id.detail_heart_image_view);
downloadThumbnailKey = infoItemBuilder.getContext(). downloadThumbnailKey = infoItemBuilder.getContext().
getString(R.string.download_thumbnail_key); getString(R.string.download_thumbnail_key);
@ -157,6 +157,8 @@ public class CommentsMiniInfoItemHolder extends InfoItemHolder {
if (item.isHeartedByUploader()) { if (item.isHeartedByUploader()) {
itemHeartView.setVisibility(View.VISIBLE); itemHeartView.setVisibility(View.VISIBLE);
} else {
itemHeartView.setVisibility(View.GONE);
} }
itemView.setOnClickListener(view -> { itemView.setOnClickListener(view -> {

2
app/src/main/res/drawable-night/ic_heart.xml
View file

@ -1,7 +1,7 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android" <vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp" android:width="24dp"
android:height="24dp" android:height="24dp"
android:tint="#FFFFFF" android:tint="#FF5252"
android:viewportWidth="24.0" android:viewportWidth="24.0"
android:viewportHeight="24.0"> android:viewportHeight="24.0">
<path <path

1
app/src/main/res/drawable/ic_heart.xml
View file

@ -1,6 +1,7 @@
<vector xmlns:android="http://schemas.android.com/apk/res/android" <vector xmlns:android="http://schemas.android.com/apk/res/android"
android:width="24dp" android:width="24dp"
android:height="24dp" android:height="24dp"
android:tint="#E53935"
android:viewportWidth="24.0" android:viewportWidth="24.0"
android:viewportHeight="24.0"> android:viewportHeight="24.0">
<path <path

8
app/src/main/res/layout/list_comments_item.xml
View file

@ -72,9 +72,9 @@
tools:text="12M" /> tools:text="12M" />
<ImageView <ImageView
android:id="@+id/detail_heart_img_view" android:id="@+id/detail_heart_image_view"
android:layout_width="@dimen/video_item_detail_heart_image_width" android:layout_width="@dimen/video_item_detail_heart_image_size"
android:layout_height="@dimen/video_item_detail_heart_image_height" android:layout_height="@dimen/video_item_detail_heart_image_size"
android:layout_below="@id/itemCommentContentView" android:layout_below="@id/itemCommentContentView"
android:layout_marginLeft="@dimen/video_item_detail_heart_margin" android:layout_marginLeft="@dimen/video_item_detail_heart_margin"
android:layout_toRightOf="@+id/detail_thumbs_up_count_view" android:layout_toRightOf="@+id/detail_thumbs_up_count_view"
@ -116,7 +116,7 @@
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_below="@id/itemCommentContentView" android:layout_below="@id/itemCommentContentView"
android:layout_marginLeft="12dp" android:layout_marginLeft="12dp"
android:layout_toRightOf="@id/detail_heart_img_view" android:layout_toRightOf="@id/detail_heart_image_view"
android:lines="1" android:lines="1"
android:textAppearance="?android:attr/textAppearanceSmall" android:textAppearance="?android:attr/textAppearanceSmall"
android:textSize="@dimen/video_item_search_upload_date_text_size" android:textSize="@dimen/video_item_search_upload_date_text_size"

3
app/src/main/res/values/dimens.xml
View file

@ -81,8 +81,7 @@
<dimen name="video_item_detail_sub_channel_image_size">16dp</dimen> <dimen name="video_item_detail_sub_channel_image_size">16dp</dimen>
<dimen name="video_item_detail_like_image_height">18sp</dimen> <dimen name="video_item_detail_like_image_height">18sp</dimen>
<dimen name="video_item_detail_like_image_width">18sp</dimen> <dimen name="video_item_detail_like_image_width">18sp</dimen>
<dimen name="video_item_detail_heart_image_width">18sp</dimen> <dimen name="video_item_detail_heart_image_size">18sp</dimen>
<dimen name="video_item_detail_heart_image_height">18sp</dimen>
<dimen name="channel_avatar_size">70dp</dimen> <dimen name="channel_avatar_size">70dp</dimen>
<dimen name="sub_channel_avatar_size">35dp</dimen> <dimen name="sub_channel_avatar_size">35dp</dimen>
<dimen name="mini_player_height">60dp</dimen> <dimen name="mini_player_height">60dp</dimen>