baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity

Merge pull request #10275 from J-Stutzmann/fix/audio-focus

Browse source 
Fix player audio focus not respecting mute
This commit is contained in:
Tobi 2023-08-03 11:55:40 +02:00 committed by GitHub
commit 50d7d1b7b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
app/src/main/java/org/schabi/newpipe/player/Player.java
View file

@ -1082,7 +1082,7 @@ public final class Player implements PlaybackListener, Listener {
UIs.call(PlayerUi::onPrepared); UIs.call(PlayerUi::onPrepared);
if (playWhenReady) { if (playWhenReady && !isMuted()) {
audioReactor.requestAudioFocus(); audioReactor.requestAudioFocus();
} }
} }
@ -1223,6 +1223,11 @@ public final class Player implements PlaybackListener, Listener {
public void toggleMute() { public void toggleMute() {
final boolean wasMuted = isMuted(); final boolean wasMuted = isMuted();
simpleExoPlayer.setVolume(wasMuted ? 1 : 0); simpleExoPlayer.setVolume(wasMuted ? 1 : 0);
if (wasMuted) {
audioReactor.requestAudioFocus();
} else {
audioReactor.abandonAudioFocus();
}
UIs.call(playerUi -> playerUi.onMuteUnmuteChanged(!wasMuted)); UIs.call(playerUi -> playerUi.onMuteUnmuteChanged(!wasMuted));
notifyPlaybackUpdateToListeners(); notifyPlaybackUpdateToListeners();
} }
@ -1620,7 +1625,9 @@ public final class Player implements PlaybackListener, Listener {
return; return;
} }
if (!isMuted()) {
audioReactor.requestAudioFocus(); audioReactor.requestAudioFocus();
}
if (currentState == STATE_COMPLETED) { if (currentState == STATE_COMPLETED) {
if (playQueue.getIndex() == 0) { if (playQueue.getIndex() == 0) {