baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 8 Packages Wiki Activity

Change shuffle() guard to check for size <= 2

Browse source 
After testing the app, I realized that shuffling a queue with size 2
does nothing
This commit is contained in:
Zhiheng Xu 2021-05-22 13:56:02 -04:00
parent 5ab6e84044
commit 2e161a1f45
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
app/src/main/java/org/schabi/newpipe/player/playqueue/PlayQueue.java
View file

@ -432,11 +432,12 @@ public abstract class PlayQueue implements Serializable {
* Will emit a {@link ReorderEvent} if shuffled. * Will emit a {@link ReorderEvent} if shuffled.
* </p> * </p>
* *
* @implNote Does nothing if the queue is empty or has a size of 1 * @implNote Does nothing if the queue has a size <= 2 (the currently playing video must stay on
* top, so shuffling a size-2 list does nothing)
*/ */
public synchronized void shuffle() { public synchronized void shuffle() {
// Can't shuffle an list that's empty or only has one element // Can't shuffle an list that's empty or only has one element
if (size() <= 1) { if (size() <= 2) {
return; return;
} }
// Create a backup if it doesn't already exist // Create a backup if it doesn't already exist