baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 8 Packages Wiki Activity

More refactoring.

Browse source
This commit is contained in:
Kartikey Kushwaha 2018-08-12 20:57:30 +05:30
parent af42e32ae6
commit 2a18eacf62
2 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
app/src/main/java/org/schabi/newpipe/CheckForNewAppVersionTask.java
View file

@ -25,13 +25,15 @@ import java.net.URL;
*/ */
public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> { public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> {
private Application app = App.getContext();
private String newPipeApiUrl = "https://newpipe.schabi.org/api/data.json"; private String newPipeApiUrl = "https://newpipe.schabi.org/api/data.json";
private int timeoutPeriod = 10000; private int timeoutPeriod = 10000;
@Override @Override
protected void onPreExecute() { protected void onPreExecute() {
// Continue with version check only if the build variant is of type "github". // Continue with version check only if the build variant is of type "github".
if (!BuildConfig.FLAVOR.equals("github")) { if (!BuildConfig.FLAVOR.equals(app.getString(R.string.app_flavor_github))) {
this.cancel(true); this.cancel(true);
} }
} }
@ -63,8 +65,7 @@ public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> {
case 200: case 200:
case 201: case 201:
BufferedReader bufferedReader BufferedReader bufferedReader = new BufferedReader(
= new BufferedReader(
new InputStreamReader(connection.getInputStream())); new InputStreamReader(connection.getInputStream()));
StringBuilder stringBuilder = new StringBuilder(); StringBuilder stringBuilder = new StringBuilder();
@ -134,8 +135,6 @@ public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> {
if (!BuildConfig.VERSION_NAME.equals(versionName.replace("v", ""))) { if (!BuildConfig.VERSION_NAME.equals(versionName.replace("v", ""))) {
Application app = App.getContext();
// A pending intent to open the apk location url in the browser. // A pending intent to open the apk location url in the browser.
Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(apkLocationUrl)); Intent intent = new Intent(Intent.ACTION_VIEW, Uri.parse(apkLocationUrl));
PendingIntent pendingIntent PendingIntent pendingIntent
@ -152,8 +151,6 @@ public class CheckForNewAppVersionTask extends AsyncTask<Void, Void, String> {
+ " " + versionName); + " " + versionName);
NotificationManagerCompat notificationManager = NotificationManagerCompat.from(app); NotificationManagerCompat notificationManager = NotificationManagerCompat.from(app);
// notificationId is a unique int for each notification that you must define
notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build()); notificationManager.notify(NOTIFICATION_ID, notificationBuilder.build());
} }
} }

4
app/src/main/res/values/strings.xml
View file

@ -512,4 +512,8 @@
<string name="app_update_notification_content_title">NewPipe Update Available</string> <string name="app_update_notification_content_title">NewPipe Update Available</string>
<string name="app_update_notification_content_text">Tap to download</string> <string name="app_update_notification_content_text">Tap to download</string>
<!-- Flavor names -->
<string name="app_flavor_github">github</string>
<string name="app_flavor_fdroid">fdroid</string>
</resources> </resources>