baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity

Merge pull request #4130 from Stypox/swipe-queueitem-fix

Browse source 
[regression] Close player in onPlaybackShutdown()
This commit is contained in:
Tobias Groza 2020-08-15 20:25:54 +02:00 committed by GitHub
commit 13c9096417
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/org/schabi/newpipe/player/BasePlayer.java
View file

@ -1068,14 +1068,6 @@ public abstract class BasePlayer implements
registerView(); registerView();
} }
@Override
public void onPlaybackShutdown() {
if (DEBUG) {
Log.d(TAG, "Shutting down...");
}
destroy();
}
/*////////////////////////////////////////////////////////////////////////// /*//////////////////////////////////////////////////////////////////////////
// General Player // General Player
//////////////////////////////////////////////////////////////////////////*/ //////////////////////////////////////////////////////////////////////////*/

2
app/src/main/java/org/schabi/newpipe/player/VideoPlayerImpl.java
View file

@ -622,7 +622,7 @@ public class VideoPlayerImpl extends VideoPlayer
if (DEBUG) { if (DEBUG) {
Log.d(TAG, "onPlaybackShutdown() called"); Log.d(TAG, "onPlaybackShutdown() called");
} }
// Override it because we don't want playerImpl destroyed service.onDestroy();
} }
@Override @Override