baalajimaestro/NewPipe
1
0
Fork 0
Code Issues Pull requests Projects Releases 7 Packages Wiki Activity

Merge pull request #2771 from atpamat/background-player-notif-lag

Browse source 
Limit amount of notification thumbnail updates in background player
This commit is contained in:
Tobias Groza 2020-01-01 23:01:11 +01:00 committed by GitHub
commit 0afc8005d0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
app/src/main/java/org/schabi/newpipe/player/BackgroundPlayer.java
View file

@ -95,6 +95,9 @@ public final class BackgroundPlayer extends Service {
private boolean shouldUpdateOnProgress; private boolean shouldUpdateOnProgress;
private static final int NOTIFICATION_UPDATES_BEFORE_RESET = 60;
private int timesNotificationUpdated;
/*////////////////////////////////////////////////////////////////////////// /*//////////////////////////////////////////////////////////////////////////
// Service's LifeCycle // Service's LifeCycle
//////////////////////////////////////////////////////////////////////////*/ //////////////////////////////////////////////////////////////////////////*/
@ -180,6 +183,7 @@ public final class BackgroundPlayer extends Service {
private void resetNotification() { private void resetNotification() {
notBuilder = createNotification(); notBuilder = createNotification();
timesNotificationUpdated = 0;
} }
private NotificationCompat.Builder createNotification() { private NotificationCompat.Builder createNotification() {
@ -252,6 +256,7 @@ public final class BackgroundPlayer extends Service {
if (bigNotRemoteView != null) bigNotRemoteView.setImageViewResource(R.id.notificationPlayPause, drawableId); if (bigNotRemoteView != null) bigNotRemoteView.setImageViewResource(R.id.notificationPlayPause, drawableId);
} }
notificationManager.notify(NOTIFICATION_ID, notBuilder.build()); notificationManager.notify(NOTIFICATION_ID, notBuilder.build());
timesNotificationUpdated++;
} }
/*////////////////////////////////////////////////////////////////////////// /*//////////////////////////////////////////////////////////////////////////
@ -351,8 +356,10 @@ public final class BackgroundPlayer extends Service {
updateProgress(currentProgress, duration, bufferPercent); updateProgress(currentProgress, duration, bufferPercent);
if (!shouldUpdateOnProgress) return; if (!shouldUpdateOnProgress) return;
if (timesNotificationUpdated > NOTIFICATION_UPDATES_BEFORE_RESET) {
resetNotification(); resetNotification();
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O /*Oreo*/) updateNotificationThumbnail(); if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O /*Oreo*/) updateNotificationThumbnail();
}
if (bigNotRemoteView != null) { if (bigNotRemoteView != null) {
if(cachedDuration != duration) { if(cachedDuration != duration) {
cachedDuration = duration; cachedDuration = duration;